Correctly Call Layout

Author: thecoolwinter

…rceEditor/Minimap/MinimapView+Draw.swift …eEditor/Minimap/MinimapContentView.swiftSources/CodeEditSourceEditor/Minimap/MinimapView+Draw.swift renamed to Sources/CodeEditSourceEditor/Minimap/MinimapContentView.swift Sources/CodeEditSourceEditor/Minimap/MinimapView+Draw.swift renamed to Sources/CodeEditSourceEditor/Minimap/MinimapContentView.swift

@@ -1,5 +1,5 @@
 //
-//  MinimapView+Draw.swift
+//  MinimapContentView.swift
 //  CodeEditSourceEditor
 //
 //  Created by Khan Winter on 4/16/25.
@@ -8,8 +8,13 @@
 import AppKit
 import CodeEditTextView
 
+/// Displays the real contents of the minimap. The layout manager and selection manager place views and draw into this
+/// view.
+///
+/// Height and position are managed by ``MinimapView``.
 public class MinimapContentView: FlippedNSView {
     weak var textView: TextView?
+    weak var layoutManager: TextLayoutManager?
     weak var selectionManager: TextSelectionManager?
 
     override public func draw(_ dirtyRect: NSRect) {
@@ -18,4 +23,9 @@ public class MinimapContentView: FlippedNSView {
             selectionManager?.drawSelections(in: dirtyRect)
         }
     }
+
+    override public func layout() {
+        super.layout()
+        layoutManager?.layoutLines()
+    }
 }

Sources/CodeEditSourceEditor/Minimap/MinimapView+DocumentVisibleView.swift

@@ -58,8 +58,6 @@ extension MinimapView {
         if minimapHeight > containerHeight {
             setScrollViewPosition(scrollPercentage: scrollPercentage)
         }
-
-        layoutManager.layoutLines()
     }
 
     private func setScrollViewPosition(scrollPercentage: CGFloat) {

Sources/CodeEditSourceEditor/Minimap/MinimapView.swift

@@ -137,6 +137,7 @@ public class MinimapView: FlippedNSView {
             renderDelegate: lineRenderer
         )
         self.layoutManager = layoutManager
+        self.contentView.layoutManager = layoutManager
         (textView.textStorage.delegate as? MultiStorageDelegate)?.addDelegate(layoutManager)
     }
 
@@ -244,7 +245,6 @@ public class MinimapView: FlippedNSView {
     }
 
     override public func layout() {
-        layoutManager?.layoutLines()
         super.layout()
         updateContentViewHeight()
         updateDocumentVisibleViewPosition()
@@ -279,9 +279,15 @@ public class MinimapView: FlippedNSView {
         let overscroll = containerHeight * overscrollAmount * (estimatedContentHeight / editorEstimatedHeight)
         let height = estimatedContentHeight + overscroll
 
+        // This seems odd, but this reduces layout passes drastically
+        let newFrame = CGRect(
+            origin: contentView.frame.origin,
+            size: CGSize(width: contentView.frame.width, height: height)
+        ).pixelAligned
+
         // Only update a frame if needed
-        if contentView.frame.height != height && height.isFinite && height < (textView?.frame.height ?? 0.0) {
-            contentView.frame.size.height = height
+        if contentView.frame != newFrame && height.isFinite && height < (textView?.frame.height ?? 0.0) {
+            contentView.frame = newFrame
         }
     }