undefined method `_ct_reorder_siblings' for an instance of Tag

[tbrammar]

In the latest version of Closuretree (v9.6.0), when updating a tag, we're getting a undefined method '_ct_reorder_siblings' for an instance of Tag

Example here:

3.3.4 :001 > tag = FactoryBot.create(:tag)
 => 
#<Tag:0x000000012e9ecbe8
 id: 844,
 name: "inventore ducimus",
 parent_id: 843,
 created_at: "2026-02-23 15:22:48.728267000 +0100",
 updated_at: "2026-02-23 15:22:48.728267000 +0100",
 title: nil,
 description: nil> 
3.3.4 :002 > tag.update(name: 'Foobar')
(rails-app):3:in `<top (required)>': undefined method `_ct_reorder_siblings' for an instance of Tag (NoMethodError)

It seems that this change is the root cause: https://github.com/ClosureTree/closure_tree/pull/484/changes#diff-2423b183850e1772ca6dbbcb3a612936b6f92ab76b9d7c650efe95cfcfe7e8b5R44-R54

[tbrammar]

It looks like this is being caused because @sampatbadhe's PR #484 added the following logic to the hierachy_maintenance.rb file:

closure_tree/lib/closure_tree/hierarchy_maintenance.rb

Lines 52 to 53 in e2bc781

	elsif _ct.order_option? && saved_changes[_ct.order_column_sym]
	_ct_reorder_siblings(saved_changes[_ct.order_column_sym].min)

However, the NumericDeterministicOrdering module where the _ct_reorder_siblings method is defined is only included if the order column is an integer:

closure_tree/lib/closure_tree/numeric_deterministic_ordering.rb

Line 5 in e2bc781

# This module is only included if the order column is an integer.

In our case, we have an ordering column which is alphabetical (as specified in the docs), and so this method is therefore not loaded.

Therefore the _ct_after_save method in the hierachy_maintenance.rb file needs to be refactored to handle this, as it's a supported and commonly used option with this gem.

[sampatbadhe]

@tbrammar Thank you for catching that. I had missed handling this case. I’ve opened #486 with a fix, Please let me know if you find anything else.