Skip to content

Commit 2ff0dd5

Browse files
author
ChidcGithub
committed
Fix ruff lint errors in observability.py
- Remove unused Union import - Use importlib.util.find_spec for opentelemetry check - Remove unused imports in export_span/export_metric - Fix unused variable e in exception handlers
1 parent 6801983 commit 2ff0dd5

File tree

1 file changed

+10
-15
lines changed

1 file changed

+10
-15
lines changed

codegnipy/observability.py

Lines changed: 10 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@
1919
List,
2020
Optional,
2121
TypeVar,
22-
Union,
2322
)
2423
from contextlib import contextmanager
2524
from contextvars import ContextVar
@@ -521,8 +520,8 @@ def __init__(
521520
def _check_opentelemetry(self) -> bool:
522521
"""检查 OpenTelemetry 是否可用"""
523522
try:
524-
import opentelemetry
525-
return True
523+
import importlib.util
524+
return importlib.util.find_spec("opentelemetry") is not None
526525
except ImportError:
527526
return False
528527

@@ -532,13 +531,10 @@ def export_span(self, span: SpanContext) -> bool:
532531
return False
533532

534533
try:
535-
from opentelemetry import trace
536-
from opentelemetry.sdk.trace import TracerProvider
537-
from opentelemetry.sdk.trace.export import BatchSpanProcessor
538-
from opentelemetry.exporter.otlp.proto.grpc.trace_exporter import OTLPSpanExporter
534+
from opentelemetry.exporter.otlp.proto.grpc.trace_exporter import OTLPSpanExporter # noqa: F401
539535

540-
# 创建导出器
541-
otlp_exporter = OTLPSpanExporter(
536+
# 创建导出器(验证配置有效)
537+
OTLPSpanExporter(
542538
endpoint=self.endpoint,
543539
headers=self.headers,
544540
)
@@ -554,11 +550,10 @@ def export_metric(self, metric: Metric) -> bool:
554550
return False
555551

556552
try:
557-
from opentelemetry import metrics
558-
from opentelemetry.sdk.metrics import MeterProvider
559-
from opentelemetry.exporter.otlp.proto.grpc.metric_exporter import OTLPMetricExporter
553+
from opentelemetry.exporter.otlp.proto.grpc.metric_exporter import OTLPMetricExporter # noqa: F401
560554

561-
otlp_exporter = OTLPMetricExporter(
555+
# 创建导出器(验证配置有效)
556+
OTLPMetricExporter(
562557
endpoint=self.endpoint,
563558
headers=self.headers,
564559
)
@@ -852,7 +847,7 @@ def sync_wrapper(*args, **kwargs):
852847
duration = (time.time() - start_time) * 1000
853848
_manager.record_histogram(f"{name}.duration", duration, unit="ms")
854849
return result
855-
except Exception as e:
850+
except Exception:
856851
_manager.record_counter(f"{name}.errors")
857852
raise
858853

@@ -869,7 +864,7 @@ async def async_wrapper(*args, **kwargs):
869864
duration = (time.time() - start_time) * 1000
870865
_manager.record_histogram(f"{name}.duration", duration, unit="ms")
871866
return result
872-
except Exception as e:
867+
except Exception:
873868
_manager.record_counter(f"{name}.errors")
874869
raise
875870

0 commit comments

Comments
 (0)