From ed26c8738dcd2b0b710e51fb9ff1a30fc86ce1b6 Mon Sep 17 00:00:00 2001 From: Aditya <112334043+AJaccP@users.noreply.github.com> Date: Mon, 23 Jun 2025 01:54:35 -0400 Subject: [PATCH 1/3] Remove links if there are too many tasks --- src/reminders/messages/simpleTaskReportMessage.ts | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/reminders/messages/simpleTaskReportMessage.ts b/src/reminders/messages/simpleTaskReportMessage.ts index 105960e..25e684e 100644 --- a/src/reminders/messages/simpleTaskReportMessage.ts +++ b/src/reminders/messages/simpleTaskReportMessage.ts @@ -23,7 +23,8 @@ export const simpleTaskReportMessage = async ({ !hasUrgent && !hasUnassigned ? "Nothing urgent or unassigned today! šŸ€šŸ„‚" : "Check out all upcoming tasks [here.](https://github.com/orgs/CarletonComputerScienceSociety/projects/18) šŸ‘€"; - + const urgentItemsLinkThreshold = 5 + const urgentItemsLinkBool = urgentItems.length <= urgentItemsLinkThreshold return { title: `Daily Task Reminder ${randomEmoji}`, message: `${baseMessage}\n\nšŸ’” **Fun Fact**: ${randomFact}.`, @@ -33,7 +34,7 @@ export const simpleTaskReportMessage = async ({ { title: "šŸ”„ Urgent & Overdue", items: urgentItems, - includeLinks: true, + includeLinks: urgentItemsLinkBool, }, ] : []), From 850c4d2e0b15952863c139be7469e1ffbe68073d Mon Sep 17 00:00:00 2001 From: AJaccP Date: Mon, 23 Jun 2025 02:01:36 -0400 Subject: [PATCH 2/3] linting fix --- src/reminders/messages/simpleTaskReportMessage.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/reminders/messages/simpleTaskReportMessage.ts b/src/reminders/messages/simpleTaskReportMessage.ts index 25e684e..bc076dc 100644 --- a/src/reminders/messages/simpleTaskReportMessage.ts +++ b/src/reminders/messages/simpleTaskReportMessage.ts @@ -23,8 +23,8 @@ export const simpleTaskReportMessage = async ({ !hasUrgent && !hasUnassigned ? "Nothing urgent or unassigned today! šŸ€šŸ„‚" : "Check out all upcoming tasks [here.](https://github.com/orgs/CarletonComputerScienceSociety/projects/18) šŸ‘€"; - const urgentItemsLinkThreshold = 5 - const urgentItemsLinkBool = urgentItems.length <= urgentItemsLinkThreshold + const urgentItemsLinkThreshold = 5; + const urgentItemsLinkBool = urgentItems.length <= urgentItemsLinkThreshold; return { title: `Daily Task Reminder ${randomEmoji}`, message: `${baseMessage}\n\nšŸ’” **Fun Fact**: ${randomFact}.`, From 6121b310235caad3843778cc79aeb1173e36eb4c Mon Sep 17 00:00:00 2001 From: AJaccP Date: Thu, 31 Jul 2025 07:13:16 -0400 Subject: [PATCH 3/3] remove links from biweekly reminder and filter out icebox --- src/reminders/messages/completeTaskReportMessage.ts | 4 +++- src/reminders/tasks/dailyTasksReminder.ts | 4 ++-- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/src/reminders/messages/completeTaskReportMessage.ts b/src/reminders/messages/completeTaskReportMessage.ts index a672821..8986c18 100644 --- a/src/reminders/messages/completeTaskReportMessage.ts +++ b/src/reminders/messages/completeTaskReportMessage.ts @@ -20,6 +20,8 @@ export const completeTaskReportMessage = async ({ !hasUrgent && hasUpcoming && !hasUnassigned ? "Nothing urgent or unassigned upcoming! šŸ€šŸ„‚" : "Check out all upcoming tasks [here.](https://github.com/orgs/CarletonComputerScienceSociety/projects/18) šŸ€šŸ€"; + const urgentItemsLinkThreshold = 5; + const urgentItemsLinkBool = urgentItems.length <= urgentItemsLinkThreshold; return { title: "Biweekly Tasks Reminder ā˜€ļøšŸŒ±", @@ -30,7 +32,7 @@ export const completeTaskReportMessage = async ({ { title: "šŸ”„ Urgent & Overdue", items: urgentItems, - includeLinks: true, + includeLinks: urgentItemsLinkBool, }, ] : []), diff --git a/src/reminders/tasks/dailyTasksReminder.ts b/src/reminders/tasks/dailyTasksReminder.ts index 5948424..c1b1383 100644 --- a/src/reminders/tasks/dailyTasksReminder.ts +++ b/src/reminders/tasks/dailyTasksReminder.ts @@ -31,8 +31,8 @@ export const dailyTasksReminder = async () => { if (githubItemsResult.err) { return githubItemsResult; } - - const nonBacklogItems = filterOutStatus(githubItemsResult.val, "Backlog"); + const nonIceboxItems = filterOutStatus(githubItemsResult.val, "Icebox"); + const nonBacklogItems = filterOutStatus(nonIceboxItems, "Backlog"); const unassignedItems = filterForUnassigned(nonBacklogItems); const upcomingItems = filterUpcomingItems(nonBacklogItems); const urgentItems = filterForUrgentItems(nonBacklogItems);