Skip to content

Commit 3f07e53

Browse files
cfsmp3claude
authored andcommitted
fix: Clarify PR comment when only pre-existing test failures exist
Fixes #535 The PR comment template only checked extra_failed_tests (new failures introduced by the PR) when deciding what summary message to display. When there were common_failed_tests (tests failing on both master and the PR) but no extra_failed_tests, it would confusingly show a list of failing tests followed by "All tests passing". Now uses three-way logic: - extra_failed_tests present: "not all tests passed" (PR has regressions) - common_failed_tests only: "no new failures, but pre-existing failures" - neither: "all tests passed" 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
1 parent 09dc049 commit 3f07e53

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

templates/ci/pr_comment.txt

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -53,9 +53,11 @@ Congratulations: Merging this PR would fix the following tests:
5353
</details>
5454

5555
{% if comment_info.extra_failed_tests | length %}
56-
It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you).
56+
It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you).
57+
{% elif comment_info.common_failed_tests | length %}
58+
This PR does not introduce any new test failures. However, some tests are failing on both master and this PR (see above).
5759
{% else %}
58-
All tests passing on the master branch were passed completely.
60+
All tests passed completely.
5961
{% endif %}
6062

6163
Check the <a href="{{ url_for('test.by_id', test_id=test_id, _external=True) }}">result</a> page for more info.

0 commit comments

Comments
 (0)