From 3cb0f61b0c24ce515f4d65ddeeb0ef8b89a72572 Mon Sep 17 00:00:00 2001 From: Harshdhall01 Date: Mon, 29 Dec 2025 15:01:40 +0530 Subject: [PATCH 1/3] Clean up VCL HRD TODO comment Replace unclear TODO with explanation of why VCL HRD parameters are skipped. VCL HRD is for video buffering compliance and not needed for caption extraction. Changes: - Replace TODO comment with clear explanation - Update mprint message to be more informative - Remove commented-out exit(1) Addresses #1894 --- src/lib_ccx/avc_functions.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/lib_ccx/avc_functions.c b/src/lib_ccx/avc_functions.c index aa58e991d..2ef37591d 100644 --- a/src/lib_ccx/avc_functions.c +++ b/src/lib_ccx/avc_functions.c @@ -904,10 +904,11 @@ void seq_parameter_set_rbsp(struct avc_ctx *ctx, unsigned char *seqbuf, unsigned dvprint("vcl_hrd_parameters_present_flag= %llX\n", tmp1); if (tmp) { - // TODO. - mprint("vcl_hrd. Not implemented for now. Hopefully not needed. Skipping rest of NAL\n"); + // VCL HRD parameters are for video buffering compliance, not needed for caption extraction. + // Just skip and continue - this doesn't affect our ability to extract captions. + mprint("Skipping VCL HRD parameters (not needed for caption extraction)\n"); ctx->num_vcl_hrd++; - // exit(1); + } if (tmp || tmp1) { From 5352a8b8770cb0b812a730991ef1705eaa069783 Mon Sep 17 00:00:00 2001 From: Harshdhall01 Date: Mon, 29 Dec 2025 21:05:17 +0530 Subject: [PATCH 2/3] Fix formatting: use consistent tab indentation and remove trailing whitespace - Line 908: Changed spaces+tabs to consistent tabs only - Line 911: Removed trailing tabs on empty line --- src/lib_ccx/avc_functions.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/lib_ccx/avc_functions.c b/src/lib_ccx/avc_functions.c index 2ef37591d..7dc103f9d 100644 --- a/src/lib_ccx/avc_functions.c +++ b/src/lib_ccx/avc_functions.c @@ -905,10 +905,10 @@ void seq_parameter_set_rbsp(struct avc_ctx *ctx, unsigned char *seqbuf, unsigned if (tmp) { // VCL HRD parameters are for video buffering compliance, not needed for caption extraction. - // Just skip and continue - this doesn't affect our ability to extract captions. + // Just skip and continue - this doesn't affect our ability to extract captions. mprint("Skipping VCL HRD parameters (not needed for caption extraction)\n"); ctx->num_vcl_hrd++; - + } if (tmp || tmp1) { From 8bf1bc16de51997c8dee6a7e6a135d4b5646fccf Mon Sep 17 00:00:00 2001 From: Harshdhall01 Date: Mon, 29 Dec 2025 21:14:35 +0530 Subject: [PATCH 3/3] Remove blank line to fix formatting check --- src/lib_ccx/avc_functions.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/lib_ccx/avc_functions.c b/src/lib_ccx/avc_functions.c index 7dc103f9d..93d602eb8 100644 --- a/src/lib_ccx/avc_functions.c +++ b/src/lib_ccx/avc_functions.c @@ -908,7 +908,6 @@ void seq_parameter_set_rbsp(struct avc_ctx *ctx, unsigned char *seqbuf, unsigned // Just skip and continue - this doesn't affect our ability to extract captions. mprint("Skipping VCL HRD parameters (not needed for caption extraction)\n"); ctx->num_vcl_hrd++; - } if (tmp || tmp1) {