feat: add async mode config and env vars#224
Open
pranishnepal wants to merge 1 commit into
Open
Conversation
pranavjain97
requested changes
Jun 8, 2026
pranavjain97
left a comment
pranavjain97
left a comment
Contributor
There was a problem hiding this comment.
Let's call it async mode, since OSO woudn't mean much for akm readers and specific to IBM. Similarly lets remove all 'oso' / bridge instances in the naming
pranishnepal
force-pushed
the
WCN-743
branch
2 times, most recently
from
1c18227 to
7e5de35
Compare
pranavjain97
reviewed
Jun 8, 2026
pranavjain97
left a comment
pranavjain97
left a comment
Contributor
There was a problem hiding this comment.
still using AWM_BRIDGE_URL
|
|
||
| export const DEFAULT_ASYNC_MODE_CONFIG: AsyncModeConfig = { | ||
| enabled: false, | ||
| awmBridgeUrl: '', |
Contributor
There was a problem hiding this comment.
Suggested change
| awmBridgeUrl: '', | |
| awmAsyncUrl: '', |
Contributor
Author
There was a problem hiding this comment.
whoops, missed that. Fixed now
danielpeng1
changed the title
Introduces ASYNC_MODE configuration support to Master BitGo Express. `ADVANCED_WALLET_MANAGER_URL` isn't required when `ASYNC_MODE=true` now. Instead, `AWM_BRIDGE_URL` is required when ASYNC mode is enabled. Ticket: WCN-743
danielpeng1
approved these changes
Jun 9, 2026
| } | ||
| }); | ||
|
|
||
| it('should use default numeric values when OSO numeric env vars are not set', () => { |
Contributor
There was a problem hiding this comment.
it('should use default numeric values when async mode numeric env vars are not set', () => {
| it('should load asyncModeConfig from env vars when ASYNC_MODE is true', () => { | ||
| process.env.TLS_MODE = 'disabled'; | ||
| process.env.ASYNC_MODE = 'true'; | ||
| process.env.AWM_ASYNC_URL = 'http://oso-bridge:8080'; |
Contributor
There was a problem hiding this comment.
can change test fixture url http://oso-bridge:8080 -> http://awm-async:8080 or similar for all references in this file just to remove all oso/bridge naming instances for good
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Introduces IBM OSO configuration support to Master BitGo Express.
ADVANCED_WALLET_MANAGER_URLis no longer required whenOSO_MODE=true.Refactors the tests to use a shared start up config, as opposed to duplication all over the test files
Ticket: WCN-743