Skip to content

Commit fe608bd

Browse files
Update CONVENTIONS.md
Co-authored-by: Otto Allmendinger <otto.allmendinger@googlemail.com>
1 parent b112b53 commit fe608bd

1 file changed

Lines changed: 1 addition & 3 deletions

File tree

CONVENTIONS.md

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -170,9 +170,7 @@ const tx = Transaction.fromBytes(bytes); // Unnecessary round-trip
170170
**What:** Transaction deserialization (for signing) and transaction parsing (decoding instructions) are separate operations with separate entry points. `Transaction.fromBytes()` deserializes for signing. `parseTransaction()` is a standalone function that decodes instructions into structured data.
171171

172172
**Why:**
173-
- Not all use cases need full parsing (e.g., just signing)
174-
- Parsing can be expensive (especially for complex instruction decoding)
175-
- Separation of concerns — Transaction is for signing/serialization, parseTransaction is for decoding
173+
- Separation of concerns: decoding is a protocol-level concept, parsing is a BitGo-level concept
176174
- Matches wasm-utxo pattern (BitGoPsbt doesn't parse on construction)
177175

178176
**Good:**

0 commit comments

Comments
 (0)