ci: test that we pick up error

TICKET: WP-6702

Author: danielzhao122

.github/workflows/ci.yml

@@ -428,8 +428,26 @@ jobs:
       - name: Audit with Vacuum
         working-directory: modules/express
         run: |
+
           vacuum report \
             --no-style \
             --stdout \
             --ruleset ruleset.yaml \
-            api-generated.json | jq '.resultSet.results // []'
+            api-generated.json > vacuum-report.json
+          
+          jq '.resultSet.results // []' vacuum-report.json > vacuum-results.json
+          
+          ERROR_COUNT=$(jq '[.[] | select(.severity == "error")] | length' vacuum-results.json)
+          WARNING_COUNT=$(jq '[.[] | select(.severity == "warn")] | length' vacuum-results.json)
+          
+          echo "Found $ERROR_COUNT error(s) and $WARNING_COUNT warning(s)"
+          
+          if [ "$ERROR_COUNT" -gt 0 ]; then
+            echo "API specification audit failed with $ERROR_COUNT error(s)"
+            echo ""
+            echo "Errors:"
+            jq -r '.[] | select(.severity == "error") | "  - [\(.ruleId)] \(.message) at \(.path)"' vacuum-results.json
+            exit 1
+          else
+            echo "API specification audit passed!"
+          fi

modules/express/src/typedRoutes/api/v2/generateWallet.ts

@@ -103,7 +103,7 @@ export const GenerateWalletV2Query = {
  * @tag Express
  */
 export const PostGenerateWallet = httpRoute({
-  path: '/api/v2/{coin}/wallet/generate',
+  path: '/api/v2/:coin/wallet/generate',
   method: 'POST',
   request: httpRequest({
     params: GenerateWalletV2Params,