refactor(sdk-coin-flrp): remove unused credential extraction methods from Utils class

Author: mohd-kashif

modules/sdk-coin-flrp/src/lib/utils.ts

@@ -1,12 +1,4 @@
-import {
-  Signature,
-  TransferableOutput,
-  TransferOutput,
-  TypeSymbols,
-  Id,
-  Credential,
-  utils as FlareUtils,
-} from '@flarenetwork/flarejs';
+import { Signature, TransferableOutput, TransferOutput, TypeSymbols, Id } from '@flarenetwork/flarejs';
 import {
   BaseUtils,
   Entry,
@@ -397,158 +389,6 @@ export class Utils implements BaseUtils {
     return new Id(Buffer.from(value, 'hex'));
   }
 
-  /**
-   * Extract credentials from raw transaction bytes.
-   * Signed transactions have credentials appended after the transaction body.
-   * This function handles both checking for credentials and extracting them.
-   *
-   * @param rawBytes - The full raw transaction bytes
-   * @param tx - The parsed transaction (must have toBytes method)
-   * @param vmType - The VM type ('EVM' or 'PVM') to get the correct codec
-   * @returns Object with hasCredentials flag and credentials array
-   */
-  extractCredentialsFromRawBytes(
-    rawBytes: Buffer,
-    tx: { toBytes(codec: unknown): Uint8Array },
-    vmType: 'EVM' | 'PVM' = 'EVM'
-  ): { hasCredentials: boolean; credentials: Credential[] } {
-    try {
-      // Get the size of the transaction without credentials using the default codec
-      const codec = FlareUtils.getManagerForVM(vmType).getDefaultCodec();
-      const txBytes = tx.toBytes(codec);
-      const txSize = txBytes.length;
-
-      // If raw bytes are not longer than tx bytes, there are no credentials
-      if (rawBytes.length <= txSize) {
-        return { hasCredentials: false, credentials: [] };
-      }
-
-      // Extract credential bytes (everything after the transaction)
-      const credentialBytes = rawBytes.slice(txSize);
-
-      // Parse credentials
-      // Format: [num_credentials: 4 bytes] [credentials...]
-      if (credentialBytes.length < 4) {
-        return { hasCredentials: false, credentials: [] };
-      }
-
-      const numCredentials = credentialBytes.readUInt32BE(0);
-
-      // Check if there are credentials in raw bytes (for hasCredentials flag)
-      const hasCredentials = numCredentials > 0;
-
-      if (numCredentials === 0) {
-        return { hasCredentials: false, credentials: [] };
-      }
-
-      const credentials: Credential[] = [];
-      let offset = 4;
-
-      for (let i = 0; i < numCredentials; i++) {
-        if (offset + 8 > credentialBytes.length) {
-          break;
-        }
-
-        // Read type ID (4 bytes) - Type ID 9 = secp256k1 credential
-        const typeId = credentialBytes.readUInt32BE(offset);
-        offset += 4;
-
-        // Validate credential type (9 = secp256k1)
-        if (typeId !== 9) {
-          continue; // Skip unsupported credential types
-        }
-
-        // Read number of signatures (4 bytes)
-        const numSigs = credentialBytes.readUInt32BE(offset);
-        offset += 4;
-
-        // Parse all signatures for this credential
-        const signatures: Signature[] = [];
-        for (let j = 0; j < numSigs; j++) {
-          if (offset + 65 > credentialBytes.length) {
-            break;
-          }
-          // Each signature is 65 bytes (64 bytes signature + 1 byte recovery)
-          const sigBytes = Buffer.from(credentialBytes.slice(offset, offset + 65));
-          signatures.push(new Signature(sigBytes));
-          offset += 65;
-        }
-
-        // Create credential with the parsed signatures
-        if (signatures.length > 0) {
-          credentials.push(new Credential(signatures));
-        }
-      }
-
-      return { hasCredentials, credentials };
-    } catch (e) {
-      // If parsing fails, return no credentials
-      return { hasCredentials: false, credentials: [] };
-    }
-  }
-
-  /**
-   * Parse credentials from raw bytes at a specific offset
-   * This is useful when the standard extraction fails due to serialization differences
-   * @param rawBytes Raw transaction bytes including credentials
-   * @param offset Byte offset where credentials start
-   * @returns Array of parsed credentials
-   */
-  parseCredentialsAtOffset(rawBytes: Buffer, offset: number): Credential[] {
-    try {
-      if (rawBytes.length <= offset + 4) {
-        return [];
-      }
-
-      const credentialBytes = rawBytes.slice(offset);
-      const numCredentials = credentialBytes.readUInt32BE(0);
-
-      if (numCredentials === 0) {
-        return [];
-      }
-
-      const credentials: Credential[] = [];
-      let pos = 4;
-
-      for (let i = 0; i < numCredentials; i++) {
-        if (pos + 8 > credentialBytes.length) {
-          break;
-        }
-
-        // Read type ID (4 bytes) - Type ID 9 = secp256k1 credential
-        const typeId = credentialBytes.readUInt32BE(pos);
-        pos += 4;
-
-        if (typeId !== 9) {
-          continue;
-        }
-
-        // Read number of signatures (4 bytes)
-        const numSigs = credentialBytes.readUInt32BE(pos);
-        pos += 4;
-
-        // Parse all signatures for this credential
-        const signatures: Signature[] = [];
-        for (let j = 0; j < numSigs; j++) {
-          if (pos + 65 > credentialBytes.length) {
-            break;
-          }
-          const sigBytes = Buffer.from(credentialBytes.slice(pos, pos + 65));
-          signatures.push(new Signature(sigBytes));
-          pos += 65;
-        }
-
-        if (signatures.length > 0) {
-          credentials.push(new Credential(signatures));
-        }
-      }
-
-      return credentials;
-    } catch {
-      return [];
-    }
-  }
-
   /**
    * FlareJS wrapper to recover signature
    * @param network
@@ -580,45 +420,6 @@ export class Utils implements BaseUtils {
       throw new Error(`Failed to recover signature: ${error}`);
     }
   }
-
-  /**
-   * Find and parse credentials by searching for the credential marker pattern in raw bytes.
-   * This is a more robust method that doesn't rely on calculated offsets.
-   * Credential format: [numCreds: 4 bytes][typeId: 4 bytes = 0x00000009][numSigs: 4 bytes][signatures...]
-   * @param rawBytes Raw transaction bytes including credentials
-   * @returns Array of parsed credentials
-   */
-  findAndParseCredentials(rawBytes: Buffer): Credential[] {
-    try {
-      // Search for the pattern: 00000001 00000009 (1 credential, typeId 9)
-      // or more generally: xxxxxxxx 00000009 (any numCreds, typeId 9)
-      // TypeId 9 = secp256k1 credential
-      const typeIdPattern = Buffer.from([0x00, 0x00, 0x00, 0x09]);
-
-      for (let i = 4; i < rawBytes.length - 12; i++) {
-        // Check if we found typeId 9 at position i
-        if (rawBytes.slice(i, i + 4).equals(typeIdPattern)) {
-          // Check if the 4 bytes before could be numCredentials (should be small positive number)
-          const numCredentials = rawBytes.readUInt32BE(i - 4);
-
-          // Sanity check: numCredentials should be reasonable (1-10)
-          if (numCredentials > 0 && numCredentials <= 10) {
-            // Try to parse credentials from position i - 4
-            const credResult = this.parseCredentialsAtOffset(rawBytes, i - 4);
-
-            // Verify we got the expected number of credentials
-            if (credResult.length === numCredentials) {
-              return credResult;
-            }
-          }
-        }
-      }
-
-      return [];
-    } catch {
-      return [];
-    }
-  }
 }
 
 const utils = new Utils();