feat(sdk-coin-near): reapply consolidation validation

This commit modifies the NEAR consolidation verification flow by:
1. Obtaining the base address directly from wallet.coinSpecific().rootAddress
2. Updating the verifyConsolidationToBaseAddress method signature
3. Adding error handling for missing root address

- Tested native and token consolidation on express

TICKET: WP-3968

Author: mohammadalfaiyazbitgo

modules/sdk-coin-near/src/near.ts

@@ -11,7 +11,6 @@ import * as request from 'superagent';
 import { auditEddsaPrivateKey } from '@bitgo/sdk-lib-mpc';
 import {
   AuditDecryptedKeyParams,
-  BaseAddress,
   BaseCoin,
   BaseTransaction,
   BitGoBase,
@@ -990,7 +989,7 @@ export class Near extends BaseCoin {
   async verifyTransaction(params: VerifyTransactionOptions): Promise<boolean> {
     let totalAmount = new BigNumber(0);
     const coinConfig = coins.get(this.getChain());
-    const { txPrebuild: txPrebuild, txParams: txParams } = params;
+    const { txPrebuild: txPrebuild, txParams: txParams, wallet } = params;
     const transaction = new Transaction(coinConfig);
     const rawTx = txPrebuild.txHex;
     if (!rawTx) {
@@ -1043,7 +1042,10 @@ export class Near extends BaseCoin {
     }
 
     if (params.verification?.consolidationToBaseAddress) {
-      await this.verifyConsolidationToBaseAddress(params, explainedTx);
+      if (!wallet?.coinSpecific()?.rootAddress) {
+        throw new Error('Unable to determine base address for consolidation');
+      }
+      await this.verifyConsolidationToBaseAddress(explainedTx, wallet.coinSpecific()?.rootAddress as string);
     }
 
     return true;
@@ -1061,18 +1063,13 @@ export class Near extends BaseCoin {
     auditEddsaPrivateKey(prv, publicKey ?? '');
   }
 
+  // TODO: Verify token consolidation as well.
   protected async verifyConsolidationToBaseAddress(
-    params: VerifyTransactionOptions,
-    explainedTx: TransactionExplanation
+    explainedTx: TransactionExplanation,
+    baseAddress: string
   ): Promise<void> {
-    const baseAddresses: BaseAddress[] | undefined = await params.wallet.addresses({ sort: -1, limit: 1 });
-    if (!baseAddresses || baseAddresses.length === 0) {
-      throw new Error('No base address found on wallet');
-    }
-    const baseAddress = baseAddresses[0];
-
     for (const output of explainedTx.outputs) {
-      if (output.address !== baseAddress.address) {
+      if (output.address !== baseAddress) {
         throw new Error('tx outputs does not match with expected address');
       }
     }

modules/sdk-coin-near/src/nep141Token.ts

@@ -66,7 +66,7 @@ export class Nep141Token extends Near {
   }
 
   async verifyTransaction(params: VerifyTransactionOptions): Promise<boolean> {
-    const { txPrebuild: txPrebuild, txParams: txParams } = params;
+    const { txPrebuild: txPrebuild, txParams: txParams, wallet } = params;
     const rawTx = txPrebuild.txHex;
     let totalAmount = new BigNumber(0);
     if (!rawTx) {
@@ -106,7 +106,10 @@ export class Nep141Token extends Near {
     }
 
     if (params.verification?.consolidationToBaseAddress) {
-      await this.verifyConsolidationToBaseAddress(params, explainedTx);
+      if (!wallet?.coinSpecific()?.rootAddress) {
+        throw new Error('Unable to determine base address for consolidation');
+      }
+      await this.verifyConsolidationToBaseAddress(explainedTx, wallet.coinSpecific()?.rootAddress as string);
     }
 
     return true;

modules/sdk-coin-near/test/unit/near.ts

@@ -543,7 +543,7 @@ describe('NEAR:', function () {
           '5b3424f91bf349930e34017700000000',
         ],
         coinSpecific: {
-          rootAddress: '3a1b77653ea1705ad297db7abe259953b4ad5d2ecc5b50bee9a486f785dd90db',
+          rootAddress: 'a94e3970aec46bbb156931ca090ed75ff3aade4979ffef6d74c72d5a247ce94f',
         },
         multisigType: 'tss',
       };
@@ -593,16 +593,6 @@ describe('NEAR:', function () {
         consolidateId: '68ae77ec62346a69d0aee5a2dda69c8c',
         coin: 'tnear',
       };
-      const bgUrl = common.Environments['mock'].uri;
-
-      nock(bgUrl)
-        .get('/api/v2/tnear/wallet/62e156dbd641c000076bbabe04041a90/addresses?sort=-1&limit=1')
-        .reply(200, [
-          {
-            address: 'a94e3970aec46bbb156931ca090ed75ff3aade4979ffef6d74c72d5a247ce94f',
-          },
-        ]);
-
       try {
         if (
           !(await basecoin.verifyTransaction({

modules/sdk-coin-near/test/unit/nep141Token.ts

@@ -284,7 +284,7 @@ describe('Nep141Token', () => {
           '5b3424f91bf349930e34017700000000',
         ],
         coinSpecific: {
-          rootAddress: '3a1b77653ea1705ad297db7abe259953b4ad5d2ecc5b50bee9a486f785dd90db',
+          rootAddress: 'a94e3970aec46bbb156931ca090ed75ff3aade4979ffef6d74c72d5a247ce94f',
         },
         multisigType: 'tss',
       };
@@ -335,16 +335,6 @@ describe('Nep141Token', () => {
         coin: 'tnear',
         token: 'tnear:usdc',
       };
-      const bgUrl = common.Environments['mock'].uri;
-
-      nock(bgUrl)
-        .get('/api/v2/tnear:tnep24dp/wallet/62e156dbd641c000076bbabe04041a90/addresses?sort=-1&limit=1')
-        .reply(200, [
-          {
-            address: 'a94e3970aec46bbb156931ca090ed75ff3aade4979ffef6d74c72d5a247ce94f',
-          },
-        ]);
-
       try {
         if (
           !(await baseCoin.verifyTransaction({