refactor(sdk-coin-flrp): remove NotImplementedError from utility methods and add placeholder implementations

TICKET: WIN-8145

Author: mohd-kashif

modules/sdk-coin-flrp/src/lib/utils.ts

@@ -5,7 +5,6 @@ import {
   InvalidTransactionError,
   isValidXprv,
   isValidXpub,
-  NotImplementedError,
   ParseTransactionError,
 } from '@bitgo/sdk-core';
 import { FlareNetwork } from '@bitgo/statics';
@@ -17,6 +16,12 @@ import bs58 from 'bs58';
 import { bech32 } from 'bech32';
 
 export class Utils implements BaseUtils {
+  isValidTransactionId(txId: string): boolean {
+    throw new Error('Method not implemented.');
+  }
+  isValidSignature(signature: string): boolean {
+    throw new Error('Method not implemented.');
+  }
   /**
    * Check if addresses in wallet match UTXO output addresses
    */
@@ -260,15 +265,6 @@ export class Utils implements BaseUtils {
     return parseInt(outputidx.toString('hex'), 16).toString();
   }
 
-  // Required by BaseUtils interface but not implemented
-  isValidSignature(signature: string): boolean {
-    throw new NotImplementedError('isValidSignature not implemented');
-  }
-
-  isValidTransactionId(txId: string): boolean {
-    throw new NotImplementedError('isValidTransactionId not implemented');
-  }
-
   /**
    * Helper method to convert address components to string
    */

modules/sdk-coin-flrp/test/unit/lib/utils.ts

@@ -9,6 +9,7 @@ import {
   INVALID_SHORT_KEYPAIR_KEY,
   INVALID_LONG_KEYPAIR_PRV,
 } from '../../resources/account';
+import { ecc } from '@bitgo/secp256k1';
 import { EXPORT_IN_C } from '../../resources/transactionData/exportInC';
 import { IMPORT_IN_P } from '../../resources/transactionData/importInP';
 
@@ -368,18 +369,6 @@ describe('Utils', function () {
     });
   });
 
-  describe('isValidSignature', function () {
-    it('should throw NotImplementedError', function () {
-      assert.throws(() => utils.isValidSignature(SEED_ACCOUNT.signature), /isValidSignature not implemented/);
-    });
-  });
-
-  describe('isValidTransactionId', function () {
-    it('should throw NotImplementedError', function () {
-      assert.throws(() => utils.isValidTransactionId(EXPORT_IN_C.txhash), /isValidTransactionId not implemented/);
-    });
-  });
-
   describe('addressToString', function () {
     it('should convert address buffer to mainnet bech32 string', function () {
       const address = SEED_ACCOUNT.addressMainnet;
@@ -514,7 +503,6 @@ describe('Utils', function () {
       const privateKey = Buffer.from(SEED_ACCOUNT.privateKey, 'hex');
 
       // Get original public key
-      const { ecc } = require('@bitgo/secp256k1');
       const originalPubKey = Buffer.from(ecc.pointFromScalar(privateKey, true) as Uint8Array);
 
       // Create signature and recover public key
@@ -529,7 +517,6 @@ describe('Utils', function () {
       const message = Buffer.from(SEED_ACCOUNT.message, 'utf8');
       const privateKey = Buffer.from(ACCOUNT_1.privateKey, 'hex');
 
-      const { ecc } = require('@bitgo/secp256k1');
       const originalPubKey = Buffer.from(ecc.pointFromScalar(privateKey, true) as Uint8Array);
 
       const signature = utils.createSignature(network, message, privateKey);