From cf787e1e6c5696d014ce04e9a086fe7a08180274 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Wed, 12 Nov 2025 21:18:10 +0000 Subject: [PATCH 1/5] Initial plan From a40b2a498eef6b6b85c3b8c14c599483134bc30d Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Wed, 12 Nov 2025 21:28:49 +0000 Subject: [PATCH 2/5] Remove unnecessary throws Exception declarations from sample applications Co-authored-by: thomasturrell <1552612+thomasturrell@users.noreply.github.com> --- .../deleteactivityprofile/DeleteActivityProfileApplication.java | 2 +- .../deleteagentprofile/DeleteAgentProfileApplication.java | 2 +- .../xapi/samples/deletestate/DeleteStateApplication.java | 2 +- .../xapi/samples/deletestates/DeleteStatesApplication.java | 2 +- .../dev/learning/xapi/samples/getabout/GetAboutApplication.java | 2 +- .../getactivityprofile/GetActivityProfileApplication.java | 2 +- .../getactivityprofiles/GetActivityProfilesApplication.java | 2 +- .../xapi/samples/getactivity/GetActivityApplication.java | 2 +- .../samples/getagentprofile/GetAgentProfileApplication.java | 2 +- .../samples/getagentprofiles/GetAgentProfilesApplication.java | 2 +- .../learning/xapi/samples/getagents/GetAgentsApplication.java | 2 +- .../samples/getmorestatements/GetMoreStatementsApplication.java | 2 +- .../dev/learning/xapi/samples/getstate/GetStateApplication.java | 2 +- .../samples/getstatements/GetStatementIteratorApplication.java | 2 +- .../xapi/samples/getstatement/GetStatementApplication.java | 2 +- .../xapi/samples/getstatements/GetStatementsApplication.java | 2 +- .../learning/xapi/samples/getstates/GetStatesApplication.java | 2 +- .../getvoidedstatement/GetVoidedStatementApplication.java | 2 +- .../postactivityprofile/PostActivityProfileApplication.java | 2 +- .../samples/postagentprofile/PostAgentProfileApplication.java | 2 +- .../learning/xapi/samples/poststate/PostStateApplication.java | 2 +- .../xapi/samples/poststatement/PostStatementApplication.java | 2 +- .../xapi/samples/poststatements/PostStatementsApplication.java | 2 +- .../putactivityprofile/PutActivityProfileApplication.java | 2 +- .../samples/putagentprofile/PutAgentProfileApplication.java | 2 +- .../dev/learning/xapi/samples/putstate/PutStateApplication.java | 2 +- 26 files changed, 26 insertions(+), 26 deletions(-) diff --git a/samples/delete-activity-profile/src/main/java/dev/learning/xapi/samples/deleteactivityprofile/DeleteActivityProfileApplication.java b/samples/delete-activity-profile/src/main/java/dev/learning/xapi/samples/deleteactivityprofile/DeleteActivityProfileApplication.java index cad056d0..1f0e20e5 100644 --- a/samples/delete-activity-profile/src/main/java/dev/learning/xapi/samples/deleteactivityprofile/DeleteActivityProfileApplication.java +++ b/samples/delete-activity-profile/src/main/java/dev/learning/xapi/samples/deleteactivityprofile/DeleteActivityProfileApplication.java @@ -31,7 +31,7 @@ public static void main(String[] args) { } @Override - public void run(String... args) throws Exception { + public void run(String... args) { // Post activity profile for later deletion postActivityProfile(); diff --git a/samples/delete-agent-profile/src/main/java/dev/learning/xapi/samples/deleteagentprofile/DeleteAgentProfileApplication.java b/samples/delete-agent-profile/src/main/java/dev/learning/xapi/samples/deleteagentprofile/DeleteAgentProfileApplication.java index f22a5486..15ddb221 100644 --- a/samples/delete-agent-profile/src/main/java/dev/learning/xapi/samples/deleteagentprofile/DeleteAgentProfileApplication.java +++ b/samples/delete-agent-profile/src/main/java/dev/learning/xapi/samples/deleteagentprofile/DeleteAgentProfileApplication.java @@ -31,7 +31,7 @@ public static void main(String[] args) { } @Override - public void run(String... args) throws Exception { + public void run(String... args) { // Post Example agent profile for later deletion postAgentProfile(); diff --git a/samples/delete-state/src/main/java/dev/learning/xapi/samples/deletestate/DeleteStateApplication.java b/samples/delete-state/src/main/java/dev/learning/xapi/samples/deletestate/DeleteStateApplication.java index fda47d8b..adf6c7af 100644 --- a/samples/delete-state/src/main/java/dev/learning/xapi/samples/deletestate/DeleteStateApplication.java +++ b/samples/delete-state/src/main/java/dev/learning/xapi/samples/deletestate/DeleteStateApplication.java @@ -31,7 +31,7 @@ public static void main(String[] args) { } @Override - public void run(String... args) throws Exception { + public void run(String... args) { // Post Example state for later deletion postState(); diff --git a/samples/delete-states/src/main/java/dev/learning/xapi/samples/deletestates/DeleteStatesApplication.java b/samples/delete-states/src/main/java/dev/learning/xapi/samples/deletestates/DeleteStatesApplication.java index 596cd656..f46985db 100644 --- a/samples/delete-states/src/main/java/dev/learning/xapi/samples/deletestates/DeleteStatesApplication.java +++ b/samples/delete-states/src/main/java/dev/learning/xapi/samples/deletestates/DeleteStatesApplication.java @@ -31,7 +31,7 @@ public static void main(String[] args) { } @Override - public void run(String... args) throws Exception { + public void run(String... args) { // Post state for later deletion postState(); diff --git a/samples/get-about/src/main/java/dev/learning/xapi/samples/getabout/GetAboutApplication.java b/samples/get-about/src/main/java/dev/learning/xapi/samples/getabout/GetAboutApplication.java index dabe3866..cf2fcd40 100644 --- a/samples/get-about/src/main/java/dev/learning/xapi/samples/getabout/GetAboutApplication.java +++ b/samples/get-about/src/main/java/dev/learning/xapi/samples/getabout/GetAboutApplication.java @@ -31,7 +31,7 @@ public static void main(String[] args) { } @Override - public void run(String... args) throws Exception { + public void run(String... args) { // Get About ResponseEntity response = client.getAbout().block(); diff --git a/samples/get-activity-profile/src/main/java/dev/learning/xapi/samples/getactivityprofile/GetActivityProfileApplication.java b/samples/get-activity-profile/src/main/java/dev/learning/xapi/samples/getactivityprofile/GetActivityProfileApplication.java index af7ccde5..2dfceb9b 100644 --- a/samples/get-activity-profile/src/main/java/dev/learning/xapi/samples/getactivityprofile/GetActivityProfileApplication.java +++ b/samples/get-activity-profile/src/main/java/dev/learning/xapi/samples/getactivityprofile/GetActivityProfileApplication.java @@ -32,7 +32,7 @@ public static void main(String[] args) { } @Override - public void run(String... args) throws Exception { + public void run(String... args) { // Post activity profile for later retrieval postActivityProfile(); diff --git a/samples/get-activity-profiles/src/main/java/dev/learning/xapi/samples/getactivityprofiles/GetActivityProfilesApplication.java b/samples/get-activity-profiles/src/main/java/dev/learning/xapi/samples/getactivityprofiles/GetActivityProfilesApplication.java index 20e18dcc..2604d71d 100644 --- a/samples/get-activity-profiles/src/main/java/dev/learning/xapi/samples/getactivityprofiles/GetActivityProfilesApplication.java +++ b/samples/get-activity-profiles/src/main/java/dev/learning/xapi/samples/getactivityprofiles/GetActivityProfilesApplication.java @@ -33,7 +33,7 @@ public static void main(String[] args) { } @Override - public void run(String... args) throws Exception { + public void run(String... args) { // Post Example Activity profile for later retrieval postActivityProfile(); diff --git a/samples/get-activity/src/main/java/dev/learning/xapi/samples/getactivity/GetActivityApplication.java b/samples/get-activity/src/main/java/dev/learning/xapi/samples/getactivity/GetActivityApplication.java index 8c8bdb69..1f951dfb 100644 --- a/samples/get-activity/src/main/java/dev/learning/xapi/samples/getactivity/GetActivityApplication.java +++ b/samples/get-activity/src/main/java/dev/learning/xapi/samples/getactivity/GetActivityApplication.java @@ -35,7 +35,7 @@ public static void main(String[] args) { } @Override - public void run(String... args) throws Exception { + public void run(String... args) { // Post statement for later retrieval of activity postStatement(); diff --git a/samples/get-agent-profile/src/main/java/dev/learning/xapi/samples/getagentprofile/GetAgentProfileApplication.java b/samples/get-agent-profile/src/main/java/dev/learning/xapi/samples/getagentprofile/GetAgentProfileApplication.java index d66d5a09..5eac0322 100644 --- a/samples/get-agent-profile/src/main/java/dev/learning/xapi/samples/getagentprofile/GetAgentProfileApplication.java +++ b/samples/get-agent-profile/src/main/java/dev/learning/xapi/samples/getagentprofile/GetAgentProfileApplication.java @@ -32,7 +32,7 @@ public static void main(String[] args) { } @Override - public void run(String... args) throws Exception { + public void run(String... args) { // Post Example profile for later retrieval postAgentProfile(); diff --git a/samples/get-agent-profiles/src/main/java/dev/learning/xapi/samples/getagentprofiles/GetAgentProfilesApplication.java b/samples/get-agent-profiles/src/main/java/dev/learning/xapi/samples/getagentprofiles/GetAgentProfilesApplication.java index 95b8c1ab..46351550 100644 --- a/samples/get-agent-profiles/src/main/java/dev/learning/xapi/samples/getagentprofiles/GetAgentProfilesApplication.java +++ b/samples/get-agent-profiles/src/main/java/dev/learning/xapi/samples/getagentprofiles/GetAgentProfilesApplication.java @@ -31,7 +31,7 @@ public static void main(String[] args) { } @Override - public void run(String... args) throws Exception { + public void run(String... args) { // Get Profiles ResponseEntity> response = client diff --git a/samples/get-agents/src/main/java/dev/learning/xapi/samples/getagents/GetAgentsApplication.java b/samples/get-agents/src/main/java/dev/learning/xapi/samples/getagents/GetAgentsApplication.java index e8454e9e..fa89cefd 100644 --- a/samples/get-agents/src/main/java/dev/learning/xapi/samples/getagents/GetAgentsApplication.java +++ b/samples/get-agents/src/main/java/dev/learning/xapi/samples/getagents/GetAgentsApplication.java @@ -34,7 +34,7 @@ public static void main(String[] args) { } @Override - public void run(String... args) throws Exception { + public void run(String... args) { // Post statement for later retrieval of Agent postStatement(); diff --git a/samples/get-more-statements/src/main/java/dev/learning/xapi/samples/getmorestatements/GetMoreStatementsApplication.java b/samples/get-more-statements/src/main/java/dev/learning/xapi/samples/getmorestatements/GetMoreStatementsApplication.java index 0ba5e321..3692eeba 100644 --- a/samples/get-more-statements/src/main/java/dev/learning/xapi/samples/getmorestatements/GetMoreStatementsApplication.java +++ b/samples/get-more-statements/src/main/java/dev/learning/xapi/samples/getmorestatements/GetMoreStatementsApplication.java @@ -32,7 +32,7 @@ public static void main(String[] args) { } @Override - public void run(String... args) throws Exception { + public void run(String... args) { // Get Statements ResponseEntity response = client.getStatements(r -> r.limit(1)).block(); diff --git a/samples/get-state/src/main/java/dev/learning/xapi/samples/getstate/GetStateApplication.java b/samples/get-state/src/main/java/dev/learning/xapi/samples/getstate/GetStateApplication.java index a5b57372..d59967a2 100644 --- a/samples/get-state/src/main/java/dev/learning/xapi/samples/getstate/GetStateApplication.java +++ b/samples/get-state/src/main/java/dev/learning/xapi/samples/getstate/GetStateApplication.java @@ -32,7 +32,7 @@ public static void main(String[] args) { } @Override - public void run(String... args) throws Exception { + public void run(String... args) { // Post Example state for later retrieval postState(); diff --git a/samples/get-statement-iterator/src/main/java/dev/learning/xapi/samples/getstatements/GetStatementIteratorApplication.java b/samples/get-statement-iterator/src/main/java/dev/learning/xapi/samples/getstatements/GetStatementIteratorApplication.java index 4062c83a..dc2b7eda 100644 --- a/samples/get-statement-iterator/src/main/java/dev/learning/xapi/samples/getstatements/GetStatementIteratorApplication.java +++ b/samples/get-statement-iterator/src/main/java/dev/learning/xapi/samples/getstatements/GetStatementIteratorApplication.java @@ -31,7 +31,7 @@ public static void main(String[] args) { } @Override - public void run(String... args) throws Exception { + public void run(String... args) { // Get Statements as StatementIterator var statements = client.getStatementIterator().block(); diff --git a/samples/get-statement/src/main/java/dev/learning/xapi/samples/getstatement/GetStatementApplication.java b/samples/get-statement/src/main/java/dev/learning/xapi/samples/getstatement/GetStatementApplication.java index 0275fb60..53cb88a1 100644 --- a/samples/get-statement/src/main/java/dev/learning/xapi/samples/getstatement/GetStatementApplication.java +++ b/samples/get-statement/src/main/java/dev/learning/xapi/samples/getstatement/GetStatementApplication.java @@ -34,7 +34,7 @@ public static void main(String[] args) { } @Override - public void run(String... args) throws Exception { + public void run(String... args) { // Get Statements ResponseEntity response = client.getStatement(r -> r.id(postStatement())).block(); diff --git a/samples/get-statements/src/main/java/dev/learning/xapi/samples/getstatements/GetStatementsApplication.java b/samples/get-statements/src/main/java/dev/learning/xapi/samples/getstatements/GetStatementsApplication.java index 17619281..1c7f3789 100644 --- a/samples/get-statements/src/main/java/dev/learning/xapi/samples/getstatements/GetStatementsApplication.java +++ b/samples/get-statements/src/main/java/dev/learning/xapi/samples/getstatements/GetStatementsApplication.java @@ -32,7 +32,7 @@ public static void main(String[] args) { } @Override - public void run(String... args) throws Exception { + public void run(String... args) { // Get Statements ResponseEntity response = client.getStatements().block(); diff --git a/samples/get-states/src/main/java/dev/learning/xapi/samples/getstates/GetStatesApplication.java b/samples/get-states/src/main/java/dev/learning/xapi/samples/getstates/GetStatesApplication.java index 86ff110c..25ff61fe 100644 --- a/samples/get-states/src/main/java/dev/learning/xapi/samples/getstates/GetStatesApplication.java +++ b/samples/get-states/src/main/java/dev/learning/xapi/samples/getstates/GetStatesApplication.java @@ -33,7 +33,7 @@ public static void main(String[] args) { } @Override - public void run(String... args) throws Exception { + public void run(String... args) { // Post Example state for later retrieval postState(); diff --git a/samples/get-voided-statement/src/main/java/dev/learning/xapi/samples/getvoidedstatement/GetVoidedStatementApplication.java b/samples/get-voided-statement/src/main/java/dev/learning/xapi/samples/getvoidedstatement/GetVoidedStatementApplication.java index 068016af..a96dbaf2 100644 --- a/samples/get-voided-statement/src/main/java/dev/learning/xapi/samples/getvoidedstatement/GetVoidedStatementApplication.java +++ b/samples/get-voided-statement/src/main/java/dev/learning/xapi/samples/getvoidedstatement/GetVoidedStatementApplication.java @@ -34,7 +34,7 @@ public static void main(String[] args) { } @Override - public void run(String... args) throws Exception { + public void run(String... args) { // Get Voided Statement ResponseEntity response = diff --git a/samples/post-activity-profile/src/main/java/dev/learning/xapi/samples/postactivityprofile/PostActivityProfileApplication.java b/samples/post-activity-profile/src/main/java/dev/learning/xapi/samples/postactivityprofile/PostActivityProfileApplication.java index a3953064..f99d14c5 100644 --- a/samples/post-activity-profile/src/main/java/dev/learning/xapi/samples/postactivityprofile/PostActivityProfileApplication.java +++ b/samples/post-activity-profile/src/main/java/dev/learning/xapi/samples/postactivityprofile/PostActivityProfileApplication.java @@ -31,7 +31,7 @@ public static void main(String[] args) { } @Override - public void run(String... args) throws Exception { + public void run(String... args) { // Post activity profile client.postActivityProfile(r -> r diff --git a/samples/post-agent-profile/src/main/java/dev/learning/xapi/samples/postagentprofile/PostAgentProfileApplication.java b/samples/post-agent-profile/src/main/java/dev/learning/xapi/samples/postagentprofile/PostAgentProfileApplication.java index a7a6cc2e..569ccf79 100644 --- a/samples/post-agent-profile/src/main/java/dev/learning/xapi/samples/postagentprofile/PostAgentProfileApplication.java +++ b/samples/post-agent-profile/src/main/java/dev/learning/xapi/samples/postagentprofile/PostAgentProfileApplication.java @@ -31,7 +31,7 @@ public static void main(String[] args) { } @Override - public void run(String... args) throws Exception { + public void run(String... args) { // Post Profile client diff --git a/samples/post-state/src/main/java/dev/learning/xapi/samples/poststate/PostStateApplication.java b/samples/post-state/src/main/java/dev/learning/xapi/samples/poststate/PostStateApplication.java index 8ec13ef9..952bc5c2 100644 --- a/samples/post-state/src/main/java/dev/learning/xapi/samples/poststate/PostStateApplication.java +++ b/samples/post-state/src/main/java/dev/learning/xapi/samples/poststate/PostStateApplication.java @@ -31,7 +31,7 @@ public static void main(String[] args) { } @Override - public void run(String... args) throws Exception { + public void run(String... args) { // Post State client.postState(r -> r.activityId("https://example.com/activity/1") diff --git a/samples/post-statement/src/main/java/dev/learning/xapi/samples/poststatement/PostStatementApplication.java b/samples/post-statement/src/main/java/dev/learning/xapi/samples/poststatement/PostStatementApplication.java index a1d244d7..e9763e80 100644 --- a/samples/post-statement/src/main/java/dev/learning/xapi/samples/poststatement/PostStatementApplication.java +++ b/samples/post-statement/src/main/java/dev/learning/xapi/samples/poststatement/PostStatementApplication.java @@ -33,7 +33,7 @@ public static void main(String[] args) { } @Override - public void run(String... args) throws Exception { + public void run(String... args) { // Post a statement ResponseEntity< diff --git a/samples/post-statements/src/main/java/dev/learning/xapi/samples/poststatements/PostStatementsApplication.java b/samples/post-statements/src/main/java/dev/learning/xapi/samples/poststatements/PostStatementsApplication.java index 57b40676..6a0cfd39 100644 --- a/samples/post-statements/src/main/java/dev/learning/xapi/samples/poststatements/PostStatementsApplication.java +++ b/samples/post-statements/src/main/java/dev/learning/xapi/samples/poststatements/PostStatementsApplication.java @@ -32,7 +32,7 @@ public static void main(String[] args) { } @Override - public void run(String... args) throws Exception { + public void run(String... args) { Statement attemptedStatement = Statement.builder() .agentActor(a -> a.name("A N Other").mbox("mailto:another@example.com")) diff --git a/samples/put-activity-profile/src/main/java/dev/learning/xapi/samples/putactivityprofile/PutActivityProfileApplication.java b/samples/put-activity-profile/src/main/java/dev/learning/xapi/samples/putactivityprofile/PutActivityProfileApplication.java index 1fc185e0..70fd40b5 100644 --- a/samples/put-activity-profile/src/main/java/dev/learning/xapi/samples/putactivityprofile/PutActivityProfileApplication.java +++ b/samples/put-activity-profile/src/main/java/dev/learning/xapi/samples/putactivityprofile/PutActivityProfileApplication.java @@ -31,7 +31,7 @@ public static void main(String[] args) { } @Override - public void run(String... args) throws Exception { + public void run(String... args) { // Put activity profile client.putActivityProfile(r -> r diff --git a/samples/put-agent-profile/src/main/java/dev/learning/xapi/samples/putagentprofile/PutAgentProfileApplication.java b/samples/put-agent-profile/src/main/java/dev/learning/xapi/samples/putagentprofile/PutAgentProfileApplication.java index 7e435046..2be716eb 100644 --- a/samples/put-agent-profile/src/main/java/dev/learning/xapi/samples/putagentprofile/PutAgentProfileApplication.java +++ b/samples/put-agent-profile/src/main/java/dev/learning/xapi/samples/putagentprofile/PutAgentProfileApplication.java @@ -31,7 +31,7 @@ public static void main(String[] args) { } @Override - public void run(String... args) throws Exception { + public void run(String... args) { // Put Profile client.putAgentProfile(r -> r.agent(a -> a.name("A N Other").mbox("mailto:another@example.com")) diff --git a/samples/put-state/src/main/java/dev/learning/xapi/samples/putstate/PutStateApplication.java b/samples/put-state/src/main/java/dev/learning/xapi/samples/putstate/PutStateApplication.java index e40b0658..6a61c1d2 100644 --- a/samples/put-state/src/main/java/dev/learning/xapi/samples/putstate/PutStateApplication.java +++ b/samples/put-state/src/main/java/dev/learning/xapi/samples/putstate/PutStateApplication.java @@ -31,7 +31,7 @@ public static void main(String[] args) { } @Override - public void run(String... args) throws Exception { + public void run(String... args) { // Put State client.putState(r -> r.activityId("https://example.com/activity/1") From 31f39608630c640f5050668307edd6ad175e02ad Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Wed, 12 Nov 2025 23:09:01 +0000 Subject: [PATCH 3/5] Remove unnecessary throws InterruptedException from test methods Co-authored-by: thomasturrell <1552612+thomasturrell@users.noreply.github.com> --- .../learning/xapi/client/XapiClientMultipartTests.java | 4 ++-- .../java/dev/learning/xapi/client/XapiClientTests.java | 8 ++++---- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/xapi-client/src/test/java/dev/learning/xapi/client/XapiClientMultipartTests.java b/xapi-client/src/test/java/dev/learning/xapi/client/XapiClientMultipartTests.java index 5015ce0e..b331b249 100644 --- a/xapi-client/src/test/java/dev/learning/xapi/client/XapiClientMultipartTests.java +++ b/xapi-client/src/test/java/dev/learning/xapi/client/XapiClientMultipartTests.java @@ -328,7 +328,7 @@ void whenPostingStatementsWithTimestampAndAttachmentThenNoExceptionIsThrown() @SuppressWarnings("null") @Test - void whenGettingStatementWithAttachmentThenResponseIsExpected() throws InterruptedException { + void whenGettingStatementWithAttachmentThenResponseIsExpected() { // single statement with two attachments final var body = @@ -370,7 +370,7 @@ void whenGettingStatementWithAttachmentThenResponseIsExpected() throws Interrupt @SuppressWarnings("null") @Test - void whenGettingStatementsWithAttachmentsThenResponseIsExpected() throws InterruptedException { + void whenGettingStatementsWithAttachmentsThenResponseIsExpected() { // two statements with overlapping attachments final var body = diff --git a/xapi-client/src/test/java/dev/learning/xapi/client/XapiClientTests.java b/xapi-client/src/test/java/dev/learning/xapi/client/XapiClientTests.java index c3ad4c2a..9de1dc59 100644 --- a/xapi-client/src/test/java/dev/learning/xapi/client/XapiClientTests.java +++ b/xapi-client/src/test/java/dev/learning/xapi/client/XapiClientTests.java @@ -102,7 +102,7 @@ void whenGettingStatementThenPathIsExpected() throws InterruptedException { } @Test - void whenGettingStatementThenBodyIsInstanceOfStatement() throws InterruptedException { + void whenGettingStatementThenBodyIsInstanceOfStatement() { mockWebServer.enqueue(new MockResponse().setStatus("HTTP/1.1 200 OK") @@ -1847,7 +1847,7 @@ void whenGettingActivityThenPathIsExpected() throws InterruptedException { } @Test - void whenGettingActivityThenBodyIsInstanceOfActivity() throws InterruptedException { + void whenGettingActivityThenBodyIsInstanceOfActivity() { mockWebServer.enqueue(new MockResponse().setStatus("HTTP/1.1 200 OK") @@ -1896,7 +1896,7 @@ void whenGettingAgentsThenPathIsExpected() throws InterruptedException { } @Test - void whenGettingAgentsThenBodyIsInstanceOfPerson() throws InterruptedException { + void whenGettingAgentsThenBodyIsInstanceOfPerson() { mockWebServer.enqueue(new MockResponse().setStatus("HTTP/1.1 200 OK") @@ -1951,7 +1951,7 @@ void whenGettingAboutThenPathIsExpected() throws InterruptedException { } @Test - void whenGettingAboutThenBodyIsInstanceOfAbout() throws InterruptedException { + void whenGettingAboutThenBodyIsInstanceOfAbout() { mockWebServer.enqueue(new MockResponse().setStatus("HTTP/1.1 200 OK") From 01de4dd78634338d7463159b4dda43e8d8d77ce3 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Wed, 12 Nov 2025 23:39:30 +0000 Subject: [PATCH 4/5] Remove additional unnecessary exception declarations from test methods Co-authored-by: thomasturrell <1552612+thomasturrell@users.noreply.github.com> --- .../dev/learning/xapi/model/ActivityTests.java | 2 +- .../learning/xapi/model/LanguageMapTests.java | 16 +++++++--------- .../dev/learning/xapi/model/StatementTests.java | 12 ++++++------ .../NotUndeterminedValidatorTests.java | 6 ++---- 4 files changed, 16 insertions(+), 20 deletions(-) diff --git a/xapi-model/src/test/java/dev/learning/xapi/model/ActivityTests.java b/xapi-model/src/test/java/dev/learning/xapi/model/ActivityTests.java index 546caf98..1f0e805d 100644 --- a/xapi-model/src/test/java/dev/learning/xapi/model/ActivityTests.java +++ b/xapi-model/src/test/java/dev/learning/xapi/model/ActivityTests.java @@ -160,7 +160,7 @@ void whenActivityIsBuiltWithStringIdThenIdIsExpected() { } @Test - void whenDeserializingActivityWithInvalidDisplayThenResultIsExpected() throws Exception { + void whenDeserializingActivityWithInvalidDisplayThenResultIsExpected() { final var json = "{\"objectType\":\"Activity\",\"id\":\"https://example.com/activity/simplestatement\",\"definition\":{\"name\":{\"a12345678\":\"Simple Statement\"}}}"; diff --git a/xapi-model/src/test/java/dev/learning/xapi/model/LanguageMapTests.java b/xapi-model/src/test/java/dev/learning/xapi/model/LanguageMapTests.java index 8a835902..a7835802 100644 --- a/xapi-model/src/test/java/dev/learning/xapi/model/LanguageMapTests.java +++ b/xapi-model/src/test/java/dev/learning/xapi/model/LanguageMapTests.java @@ -25,8 +25,7 @@ class LanguageMapTests { @ParameterizedTest @CsvSource({"en-GB, Colour", "en-US, Color", "de, Colour"}) - void givenUkAndUSKeyWhenGettingLocaleValueThenValueIsExpected(String locale, String expected) - throws Exception { + void givenUkAndUSKeyWhenGettingLocaleValueThenValueIsExpected(String locale, String expected) { final var languageMap = new LanguageMap(); @@ -43,7 +42,7 @@ void givenUkAndUSKeyWhenGettingLocaleValueThenValueIsExpected(String locale, Str } @Test - void givenFranceGermanyandUSKeyWhenGettingUKValueThenValueIsEnglish() throws Exception { + void givenFranceGermanyandUSKeyWhenGettingUKValueThenValueIsEnglish() { final var languageMap = new LanguageMap(); @@ -61,7 +60,7 @@ void givenFranceGermanyandUSKeyWhenGettingUKValueThenValueIsEnglish() throws Exc } @Test - void givenFrenchAndEnglishKeyWhenGettingUSValueThenValueIsEnglish() throws Exception { + void givenFrenchAndEnglishKeyWhenGettingUSValueThenValueIsEnglish() { final var languageMap = new LanguageMap(); @@ -78,7 +77,7 @@ void givenFrenchAndEnglishKeyWhenGettingUSValueThenValueIsEnglish() throws Excep } @Test - void givenFrenchAndUsKeyWhenGettingCanadaFrenchValueThenValueIsFrench() throws Exception { + void givenFrenchAndUsKeyWhenGettingCanadaFrenchValueThenValueIsFrench() { final var languageMap = new LanguageMap(); @@ -95,7 +94,7 @@ void givenFrenchAndUsKeyWhenGettingCanadaFrenchValueThenValueIsFrench() throws E } @Test - void givenMapIsEmptyWhenGettingGermanValueThenValueIsNull() throws Exception { + void givenMapIsEmptyWhenGettingGermanValueThenValueIsNull() { final var languageMap = new LanguageMap(); @@ -110,7 +109,7 @@ void givenMapIsEmptyWhenGettingGermanValueThenValueIsNull() throws Exception { } @Test - void givenUsAndUndKeyWhenGettingGermanValueThenValueIsUnd() throws Exception { + void givenUsAndUndKeyWhenGettingGermanValueThenValueIsUnd() { final var languageMap = new LanguageMap(); @@ -127,8 +126,7 @@ void givenUsAndUndKeyWhenGettingGermanValueThenValueIsUnd() throws Exception { } @Test - void givenUkAndUsKeyInMapUsedToConstructLanguageMapWhenGettingUKValueThenValueIsUK() - throws Exception { + void givenUkAndUsKeyInMapUsedToConstructLanguageMapWhenGettingUKValueThenValueIsUK() { final Map map = new HashMap<>(); map.put(Locale.UK, "Colour"); diff --git a/xapi-model/src/test/java/dev/learning/xapi/model/StatementTests.java b/xapi-model/src/test/java/dev/learning/xapi/model/StatementTests.java index b89b7f06..b8c528c6 100644 --- a/xapi-model/src/test/java/dev/learning/xapi/model/StatementTests.java +++ b/xapi-model/src/test/java/dev/learning/xapi/model/StatementTests.java @@ -991,7 +991,7 @@ void whenDeserializingStatementWithoutTimestampOffsetThenNoExceptionIsThrown() } @Test - void whenDeserializingStatementNullTimestampThenExceptionIsThrown() throws IOException { + void whenDeserializingStatementNullTimestampThenExceptionIsThrown() { Assertions.assertThrows(ValueInstantiationException.class, () -> { objectMapper.registerModule(new XapiStrictNullValuesModule()).readValue(""" @@ -1023,7 +1023,7 @@ void whenDeserializingStatementNullTimestampThenExceptionIsThrown() throws IOExc } @Test - void whenDeserializingStatementWithInvalidLocaleStringThenExceptionIsThrown() throws IOException { + void whenDeserializingStatementWithInvalidLocaleStringThenExceptionIsThrown() { Assertions.assertThrows(InvalidFormatException.class, () -> { objectMapper.registerModule(new XapiStrictLocaleModule()).readValue(""" @@ -1057,7 +1057,7 @@ void whenDeserializingStatementWithInvalidLocaleStringThenExceptionIsThrown() th } @Test - void whenDeserializingStatementWithNonStringLocaleThenExceptionIsThrown() throws IOException { + void whenDeserializingStatementWithNonStringLocaleThenExceptionIsThrown() { Assertions.assertThrows(MismatchedInputException.class, () -> { objectMapper.registerModule(new XapiStrictLocaleModule()).readValue(""" @@ -1091,7 +1091,7 @@ void whenDeserializingStatementWithNonStringLocaleThenExceptionIsThrown() throws } @Test - void whenDeserializingStatementWithNullPropertyThenExceptionIsThrown() throws IOException { + void whenDeserializingStatementWithNullPropertyThenExceptionIsThrown() { Assertions.assertThrows(ValueInstantiationException.class, () -> { objectMapper.registerModule(new XapiStrictNullValuesModule()).readValue(""" @@ -1291,7 +1291,7 @@ void whenDeserializingStatementWithTimestampWithoutOffsetThenResultisExpected() } @Test - void whenDeserializingStatementWithInvalidLocaleThenExceptionIsThrown() throws IOException { + void whenDeserializingStatementWithInvalidLocaleThenExceptionIsThrown() { Assertions.assertThrows(InvalidFormatException.class, () -> { objectMapper.registerModule(new XapiStrictLocaleModule()).readValue(""" @@ -1606,7 +1606,7 @@ void whenSigningStatementThenSignatureIsExpected() throws NoSuchAlgorithmExcepti @Test void whenSigningStatementThenSignatureIsValid() - throws NoSuchAlgorithmException, JsonMappingException, JsonProcessingException { + throws NoSuchAlgorithmException, JsonProcessingException { final var keyPairGenerator = KeyPairGenerator.getInstance("RSA"); keyPairGenerator.initialize(2048); diff --git a/xapi-model/src/test/java/dev/learning/xapi/model/validation/internal/validators/NotUndeterminedValidatorTests.java b/xapi-model/src/test/java/dev/learning/xapi/model/validation/internal/validators/NotUndeterminedValidatorTests.java index 108e44f6..92ecb75f 100644 --- a/xapi-model/src/test/java/dev/learning/xapi/model/validation/internal/validators/NotUndeterminedValidatorTests.java +++ b/xapi-model/src/test/java/dev/learning/xapi/model/validation/internal/validators/NotUndeterminedValidatorTests.java @@ -32,8 +32,7 @@ void whenValueIsNullThenResultIsTrue() { } @Test - void whenValueIsUndeterminedLocaleThenResultIsFalse() - throws NoSuchFieldException, SecurityException { + void whenValueIsUndeterminedLocaleThenResultIsFalse() { // When Value Is Undetermined Locale final var result = validator.isValid(Locale.forLanguageTag("und"), null); @@ -43,8 +42,7 @@ void whenValueIsUndeterminedLocaleThenResultIsFalse() } @Test - void whenValueIsNotUndeterminedLocaleThenResultIsTrue() - throws NoSuchFieldException, SecurityException { + void whenValueIsNotUndeterminedLocaleThenResultIsTrue() { // When Value Is Not Undetermined Locale final var result = validator.isValid(Locale.forLanguageTag("en-US"), null); From 82c5af3ae449c86ad7310b2cbcdd764fd09eca36 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Thu, 13 Nov 2025 07:44:27 +0000 Subject: [PATCH 5/5] Remove unused JsonMappingException import from StatementTests Co-authored-by: thomasturrell <1552612+thomasturrell@users.noreply.github.com> --- .../src/test/java/dev/learning/xapi/model/StatementTests.java | 1 - 1 file changed, 1 deletion(-) diff --git a/xapi-model/src/test/java/dev/learning/xapi/model/StatementTests.java b/xapi-model/src/test/java/dev/learning/xapi/model/StatementTests.java index b8c528c6..35252350 100644 --- a/xapi-model/src/test/java/dev/learning/xapi/model/StatementTests.java +++ b/xapi-model/src/test/java/dev/learning/xapi/model/StatementTests.java @@ -16,7 +16,6 @@ import static org.hamcrest.Matchers.startsWith; import com.fasterxml.jackson.core.JsonProcessingException; -import com.fasterxml.jackson.databind.JsonMappingException; import com.fasterxml.jackson.databind.ObjectMapper; import com.fasterxml.jackson.databind.exc.InvalidFormatException; import com.fasterxml.jackson.databind.exc.InvalidTypeIdException;