Skip to content

Commit 37cb172

Browse files
committed
minor chnages
1 parent 923de44 commit 37cb172

File tree

5 files changed

+33
-31
lines changed

5 files changed

+33
-31
lines changed

src/cmd/create/es.go

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ var (
1717

1818
ElasticSearchVersion string = "8.15.0"
1919
Nodes uint16 = 1
20+
esNamespace string = "default"
2021
)
2122

2223
// infoCmd represents the info command
@@ -38,8 +39,8 @@ var ElasticSearchCmd = &cobra.Command{
3839
{
3940
Name: args[0],
4041
Count: Nodes,
41-
Config: types.EsNodeConfig{
42-
NodeStoreAllowMMAP: false,
42+
Config: map[string]interface{}{
43+
"node.store.allow_mmap": false,
4344
},
4445
},
4546
},
@@ -51,8 +52,8 @@ var ElasticSearchCmd = &cobra.Command{
5152
Kind: "Elasticsearch",
5253
},
5354
metav1.ObjectMeta{
54-
Name: "default",
55-
Namespace: "elastic-system",
55+
Name: args[0],
56+
Namespace: esNamespace,
5657
},
5758
spec,
5859
"elasticsearches",
@@ -62,12 +63,13 @@ var ElasticSearchCmd = &cobra.Command{
6263
fmt.Println(err)
6364
}
6465
fmt.Println("Elastic search created")
65-
fmt.Printf("incluster url: http://%s.default.svc.cluster.local:9200 \n", args[0])
66-
fmt.Printf("Es Password can be retrieved using kubectl \n kubectl get secret %s-es-elastic-user -o go-template='{{.data.elastic | base64decode}}'\n", args[0])
66+
fmt.Printf("incluster url: http://%s-es-http.default.svc.cluster.local:9200 \n", args[0])
67+
fmt.Printf("Elasticsearch Password can be retrieved using kubectl \n kubectl get secret %s-es-elastic-user -n %s -o go-template='{{.data.elastic | base64decode}}'\n", args[0], esNamespace)
6768
},
6869
}
6970

7071
func init() {
7172
ElasticSearchCmd.Flags().StringVar(&ElasticSearchVersion, "version", ElasticSearchVersion, "elastic search version")
7273
ElasticSearchCmd.Flags().Uint16Var(&Nodes, "nodes", Nodes, "number of elastic search Nodes")
74+
ElasticSearchCmd.Flags().StringVar(&esNamespace, "namespace", esNamespace, "namespace to deploy create elasticsearch cluster on")
7375
}

src/cmd/create/flink.go

Lines changed: 17 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -15,9 +15,9 @@ import (
1515

1616
var (
1717
cpu string = "500m"
18-
memory string = "2048Mi"
18+
memory string = "1Gi"
1919
cpuLimit string = "1"
20-
memoryLimit string = "4096Mi"
20+
memoryLimit string = "2Gi"
2121
volumeSize string = "1Gi"
2222
taskslots uint8 = 1
2323
replicas uint8 = 1
@@ -55,7 +55,8 @@ var FlinkClusterCmd = &cobra.Command{
5555
}
5656
namespace := "flink"
5757

58-
flinkVersion := "v1_16"
58+
flinkVersion := "1.16"
59+
flinkVersionLong := "v1_16"
5960
ClaimName := fmt.Sprintf("%s-pvc", args[0])
6061
fmt.Printf("creating flink cluster %s\n", args[0])
6162

@@ -73,15 +74,16 @@ var FlinkClusterCmd = &cobra.Command{
7374
}
7475

7576
var spec types.FlinkDeploymentSpec
76-
taskmanagerImage := fmt.Sprintf("beamstackproj/beam-harness-%s:latest", flinkVersion)
77+
workerImage := "beamstackproj/beam-harness:latest"
7778

7879
if Previledged {
79-
flinkImage := fmt.Sprintf("beamstackproj/flink-%s-docker:latest", flinkVersion)
80+
// flinkImage := fmt.Sprintf("beamstackproj/flink-%s-docker:latest", flinkVersion)
81+
flinkImage := fmt.Sprintf("flink:%s", flinkVersion)
8082

8183
spec = types.FlinkDeploymentSpec{
8284
Image: &flinkImage,
8385
ImagePullPolicy: "IfNotPresent",
84-
FlinkVersion: flinkVersion,
86+
FlinkVersion: flinkVersionLong,
8587
FlinkConfiguration: map[string]string{
8688
"taskmanager.numberOfTaskSlots": fmt.Sprintf("%d", taskslots),
8789
},
@@ -124,7 +126,7 @@ var FlinkClusterCmd = &cobra.Command{
124126
Containers: []v1.Container{
125127
{
126128
Name: "worker",
127-
Image: taskmanagerImage,
129+
Image: workerImage,
128130
Args: []string{"-worker_pool"},
129131
Ports: []v1.ContainerPort{
130132
{
@@ -179,11 +181,12 @@ var FlinkClusterCmd = &cobra.Command{
179181
},
180182
}
181183
} else {
182-
flinkImage := fmt.Sprintf("beamstackproj/flink-%s:latest", flinkVersion)
184+
flinkImage := fmt.Sprintf("beamstackproj/flink-%s:latest", flinkVersionLong)
185+
// flinkImage := fmt.Sprintf("flink:%s", flinkVersion)
183186
spec = types.FlinkDeploymentSpec{
184187
Image: &flinkImage,
185188
ImagePullPolicy: "IfNotPresent",
186-
FlinkVersion: flinkVersion,
189+
FlinkVersion: flinkVersionLong,
187190
FlinkConfiguration: map[string]string{
188191
"taskmanager.numberOfTaskSlots": fmt.Sprintf("%d", taskslots),
189192
},
@@ -231,7 +234,7 @@ var FlinkClusterCmd = &cobra.Command{
231234
Containers: []v1.Container{
232235
{
233236
Name: "worker",
234-
Image: taskmanagerImage,
237+
Image: workerImage,
235238
Args: []string{"-worker_pool"},
236239
Ports: []v1.ContainerPort{
237240
{
@@ -294,5 +297,8 @@ func init() {
294297
FlinkClusterCmd.Flags().Uint8Var(&replicas, "replicas", replicas, "numbers of replicas sets for task manager")
295298
FlinkClusterCmd.Flags().Uint8Var(&taskslots, "taskslots", taskslots, "numbers of taskslots to be created for the task manager")
296299
FlinkClusterCmd.Flags().StringVar(&volumeSize, "volumeSize", volumeSize, "size of persistent volume to be attached to flink cluster")
297-
FlinkClusterCmd.Flags().BoolVar(&Previledged, "Previledged", Previledged, "")
300+
FlinkClusterCmd.Flags().BoolVarP(&Previledged, "previledged", "p", Previledged, "")
298301
}
302+
303+
// export ELASTIC_PASSWORD="admin"
304+
// export KIBANA_PASSWORD="kibana-pass"

src/cmd/deploy/pipeline.go

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -290,8 +290,7 @@ func DeployPipeline(cmd *cobra.Command, args []string) {
290290
Containers: []v1.Container{
291291
{
292292
Name: "beam-pipeline",
293-
Image: "beamstackproj/beam-harness-v1_16:latest",
294-
// Image: "localhost:5000/docker-ext-v1:latest",
293+
Image: "beamstackproj/beam-harness:latest",
295294
Command: []string{"python"},
296295
Args: []string{
297296
"-m",

src/cmd/initialize/init.go

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,8 @@ var Banner string = `
3333
____) ) _____ _____ ____ ___ _| |_ _____ ____ | | _
3434
| __ ( | ___ |(____ || \ /___)(_ _)(____ | / ___)| |_/ )
3535
| |__) )| ____|/ ___ || | | ||___ | | |_ / ___ |( (___ | _ (
36-
|______/ |_____)\_____||_|_|_|(___/ \__)\_____| \____)|_| \_)
36+
|______/ |_____)\_____||_|_|_|(___/ \__)\_____| \____)|_| \_)
37+
3738
`
3839

3940
var (
@@ -58,8 +59,8 @@ func init() {
5859
InitCmd.Flags().StringVarP(&Name, "name", "n", Name, "Name of profile. will be randomly generated if not provided.")
5960
InitCmd.Flags().StringVarP(&ConfigFile, "config", "c", ConfigFile, "Path to configuration file.")
6061
InitCmd.Flags().StringVarP(&DefaultOperator, "default-operator", "d", DefaultOperator, "Default operator.")
61-
InitCmd.Flags().StringVarP(&FlinkVersion, "flink-version", "f", FlinkVersion, "Flink version to be installed. Ignored if Flink is not specified for installation.")
62-
InitCmd.Flags().StringVarP(&SparkVersion, "spark-version", "s", SparkVersion, "Spark Version to be installed. Ignored if Spark is not specified for installation.")
62+
InitCmd.Flags().StringVarP(&FlinkVersion, "flink-version", "f", FlinkVersion, "Flink kubernetes operator version to be installed. Ignored if Flink is not specified for installation.")
63+
InitCmd.Flags().StringVarP(&SparkVersion, "spark-version", "s", SparkVersion, "Spark kubernetes operator Version to be installed. Ignored if Spark is not specified for installation.")
6364
InitCmd.Flags().BoolVarP(&Flink, "flink", "F", Flink, "If specified, flink is installed.")
6465
InitCmd.Flags().BoolVarP(&Spark, "spark", "S", Spark, "If specified, Spark is installed.")
6566
InitCmd.Flags().BoolVarP(&force, "force", "q", force, "If specified, will automatically reinitialize cluster")
@@ -68,8 +69,6 @@ func init() {
6869
}
6970

7071
func runInit(cmd *cobra.Command, args []string) {
71-
// fmt.Println("Initializing cluster ! !")
72-
// out, _ := glamour.Render(fmt.Sprintf("# %s", Banner), "dark")
7372
fmt.Print(Banner)
7473
currentContext, err := utils.GetCurrentContext()
7574
if err != nil {

src/types/es.go

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,9 @@
11
package types
22

3-
type EsNodeConfig struct {
4-
NodeStoreAllowMMAP bool `yaml:"node.store.allow_mmap"`
5-
}
6-
73
type EsNodeSet struct {
8-
Name string `yaml:"name"`
9-
Count uint16 `yaml:"count"`
10-
Config EsNodeConfig `yaml:"config"`
4+
Name string `yaml:"name"`
5+
Count uint16 `yaml:"count"`
6+
Config map[string]interface{} `yaml:"config"`
117
}
128

139
type EsSpec struct {

0 commit comments

Comments
 (0)