Merge pull request #34 from BasicPrimitives/loops

Fixed performance bug in loops layout optimization

Author: BasicPrimitives

changelog.md

@@ -1,3 +1,5 @@
+#### Version 5.8.1
+* Fixed perfromance bug in loops layout optimization
 #### Version 5.8.0
 * Added `loopsLayoutMode` property to `primitives.famdiagram.Config`. Property sets loops layout optimization mode in Family Diagram. See `Loops Layout Optimization` use case.
 * Added extra arrows to vertical segments of loops in family diagram

min/package.json

@@ -1,6 +1,6 @@
 {
   "name": "basicprimitives",
-  "version": "5.8.0",
+  "version": "5.8.1",
   "description": "Basic Primitives Diagrams for JavaScript - data visualization components library that implements organizational chart and multi-parent dependency diagrams, contains implementations of JavaScript Controls and PDF rendering plugins.",
   "main": "primitives.latest.js",
   "scripts": {

min/primitives.latest.js

@@ -1,5 +1,5 @@
 /**
- * @preserve Basic Primitives Diagrams v5.8.0
+ * @preserve Basic Primitives Diagrams v5.8.1
  * Copyright (c) 2013 - 2020 Basic Primitives Inc
  *
  * Non-commercial - Free
@@ -35,7 +35,7 @@
 
 var primitives = {
   common: {
-    version: "5.8.0"
+    version: "5.8.1"
   },
   orgdiagram: {},
   famdiagram: {},
@@ -26919,16 +26919,16 @@ primitives.common.getFamilyLoops = function (family, debug) {
         tempFamily.removeChildRelation(parentid, itemid);
         return cleanFamily.SKIP;
       })
-    }
-    var itemsToRemove = [];
-    tempFamily.loopTopo(this, function (itemid) {
-      itemsToRemove.push(itemid);
-    });
-    tempFamily.loopTopoReversed(this, function (itemid) {
-      itemsToRemove.push(itemid);
-    });
-    for (var index = 0; index < itemsToRemove.length; index += 1) {
-      tempFamily.removeNode(itemsToRemove[index]);
+      var itemsToRemove = [];
+      tempFamily.loopTopo(this, function (itemid) {
+        itemsToRemove.push(itemid);
+      });
+      tempFamily.loopTopoReversed(this, function (itemid) {
+        itemsToRemove.push(itemid);
+      });
+      for (var index = 0; index < itemsToRemove.length; index += 1) {
+        tempFamily.removeNode(itemsToRemove[index]);
+      }
     }
   });
 

min/primitives.min.js

@@ -39,16 +39,16 @@ primitives.common.getFamilyLoops = function (family, debug) {
         tempFamily.removeChildRelation(parentid, itemid);
         return cleanFamily.SKIP;
       })
-    }
-    var itemsToRemove = [];
-    tempFamily.loopTopo(this, function (itemid) {
-      itemsToRemove.push(itemid);
-    });
-    tempFamily.loopTopoReversed(this, function (itemid) {
-      itemsToRemove.push(itemid);
-    });
-    for (var index = 0; index < itemsToRemove.length; index += 1) {
-      tempFamily.removeNode(itemsToRemove[index]);
+      var itemsToRemove = [];
+      tempFamily.loopTopo(this, function (itemid) {
+        itemsToRemove.push(itemid);
+      });
+      tempFamily.loopTopoReversed(this, function (itemid) {
+        itemsToRemove.push(itemid);
+      });
+      for (var index = 0; index < itemsToRemove.length; index += 1) {
+        tempFamily.removeNode(itemsToRemove[index]);
+      }
     }
   });
 

src.primitives/algorithms/getFamilyLoops.js

@@ -8,7 +8,7 @@
 
 var primitives = {
   common: {
-    version: "5.8.0"
+    version: "5.8.1"
   },
   orgdiagram: {},
   famdiagram: {},

src.primitives/common/init.js

@@ -1,5 +1,5 @@
 /**
- * @preserve Basic Primitives Diagrams v5.8.0
+ * @preserve Basic Primitives Diagrams v5.8.1
  * Copyright (c) 2013 - 2020 Basic Primitives Inc
  *
  * Non-commercial - Free