Skip to content

Fix a wrong usage of gemspec usage, relax nokogiri & faraday_middleware requirement#182

Open
jasl wants to merge 1 commit into
Azure:masterfrom
jasl:relex-nokogiri
Open

Fix a wrong usage of gemspec usage, relax nokogiri & faraday_middleware requirement#182
jasl wants to merge 1 commit into
Azure:masterfrom
jasl:relex-nokogiri

Conversation

@jasl

@jasl jasl commented Jan 6, 2021

Copy link
Copy Markdown

In my experience, this usage maybe wrong

if RUBY_VERSION < "2.4.0"
  s.add_runtime_dependency("nokogiri",                "~> 1.10.4")
else
  s.add_runtime_dependency("nokogiri",                "~> 1.11.0.rc2")
end
  • this piece of codes should be running in developer's PC, not end users', a proof is https://rubygems.org/gems/azure-storage-blob which shows azure-storage-blob depends on nokogiri ~> 1.11.0.rc2
  • Relex the version to ~> 1.10 is enough for all versions of Rubies, the bundler can find the best match version

I found this because sparklemotion/nokogiri#2168 (comment)

In addition

I also relex faraday_middleware

@ghost

ghost commented Jan 6, 2021

Copy link
Copy Markdown

CLA assistant check
All CLA requirements met.

@coveralls

coveralls commented Jan 6, 2021

Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.05%) to 87.08% when pulling 726fb12 on jasl:relex-nokogiri into 05ea58a on Azure:master.

@jasl jasl changed the title Relax Nokogiri Fix a wrong usage of gemspec usage, relax nokogiri & faraday_middleware requirement Jan 6, 2021
@jasl

jasl commented Jan 6, 2021

Copy link
Copy Markdown
Author

BTW, if the PR merged, could you release a new version?

@nertzy nertzy left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. This is more in line with standard Ruby expectations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants