Skip to content

[cherry-pick v20260330] fix(security): bump Go to 1.25.10 and golang.org/x/net to v0.55.0#8565

Closed
djsly wants to merge 1 commit into
Azure:official/v20260330from
djsly:djsly/icm-796913379-cve-go-1.25.10-v20260330
Closed

[cherry-pick v20260330] fix(security): bump Go to 1.25.10 and golang.org/x/net to v0.55.0#8565
djsly wants to merge 1 commit into
Azure:official/v20260330from
djsly:djsly/icm-796913379-cve-go-1.25.10-v20260330

Conversation

@djsly

@djsly djsly commented May 22, 2026

Copy link
Copy Markdown
Collaborator

Summary

Cherry-pick of #8551 to official/vv20260330.

Bumps the Go toolchain and golang.org/x/net to address upstream CVEs:

Vulnerability CVE Component Fixed by
net/mail DoS via crafted addresses CVE-2026-39820 net/mail (stdlib) Go 1.25.10
cmd/go pack subcommand directory traversal CVE-2026-39817 cmd/go (stdlib) Go 1.25.10
HTTP/2 + IPv6 host parsing fixes (various, see x/net release notes) golang.org/x/net v0.55.0

Why bump to Go 1.25 (and not a 1.24.x patch)

Go 1.24 reached EOL in February 2026 and does NOT receive security backports. go1.25.10 is the only release stream that contains these fixes.

golang.org/x/net v0.51.0+ also requires go 1.25.0 in its own go.mod, so the Go bump is required regardless.

Verification

  • go mod tidy succeeds for every module in the branch.
  • go build ./... clean across every module.
  • PR CI must pull go 1.25 runners.

Release plan

Once merged, two tags are pushed off the resulting commit:

  • v0.v20260330.<N+1> (AgentBaker module)
  • aks-node-controller/v0.v20260330.<N+1> (aks-node-controller submodule)

🤖 Generated with GitHub Copilot CLI

IcM 796913379

Backport of Azure#8551 to official/v20260330.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Backport security/toolchain updates onto official/v20260330, aligning the repo’s Go toolchain and key golang.org/x/* dependencies with the upstream fix from #8551.

Changes:

  • Bump Go version directives across the main module and submodules to go 1.25.10.
  • Update golang.org/x/net (and related x/* deps) to newer versions in the main module and e2e/aks-node-controller modules.
  • Update GitHub Actions workflows to use Go 1.25, and fix an invalid fmt.Sprintf(... %w ...) usage in e2e config.

Reviewed changes

Copilot reviewed 15 out of 18 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
go.mod Bumps Go version; updates indirect golang.org/x/net, x/sys, x/text; reclassifies ignition as indirect.
go.sum Updates checksums for updated golang.org/x/* and related transitive deps.
e2e/go.mod Bumps Go version and updates golang.org/x/* deps (incl. x/crypto).
e2e/go.sum Updates checksums consistent with e2e dependency bumps.
e2e/config/config.go Replaces invalid %w in fmt.Sprintf with %v.
aks-node-controller/go.mod Bumps Go version and golang.org/x/sys indirect version.
aks-node-controller/go.sum Updates checksums for golang.org/x/net, x/sys, x/text.
vhdbuilder/prefetch/go.mod Bumps Go version for the prefetch submodule.
vhdbuilder/lister/go.mod Bumps Go version for the lister submodule.
image-fetcher/go.mod Bumps Go version for the image-fetcher submodule.
hack/tools/go.mod Bumps Go version for the tools module.
.github/workflows/validate-components.yml Updates CI Go version to 1.25.
.github/workflows/shellspec.yaml Updates CI Go version to 1.25.
.github/workflows/shellcheck.yml Updates CI Go version to 1.25.
.github/workflows/golangci-lint.yml Updates CI Go version to 1.25.
.github/workflows/go-test.yml Updates CI Go version to 1.25.
.github/workflows/copilot-setup-steps.yml Updates CI Go version to 1.25.
.github/workflows/check-coverage.yml Updates CI Go version to 1.25.

Comment thread vhdbuilder/lister/go.mod
Comment on lines 1 to 4
module github.com/Azure/agentbaker/vhdbuilder/lister

go 1.24.12
go 1.25.10

Comment thread image-fetcher/go.mod
Comment on lines 1 to 4
module github.com/Azure/agentbaker/image-fetcher

go 1.24.12
go 1.25.10

@djsly djsly changed the title [cherry-pick v20260330] fix(security): bump Go to 1.25.10 and golang.org/x/net to v0.55.0 [IcM 796913379] [cherry-pick v20260330] fix(security): bump Go to 1.25.10 and golang.org/x/net to v0.55.0 May 22, 2026
@djsly

djsly commented May 22, 2026

Copy link
Copy Markdown
Collaborator Author

Closing in favor of #8575 (recreated from Azure/AgentBaker branch — repo policy rejects fork-sourced PRs).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants