refactor(txe): normalize deploy and addAccount to oracle registry#23536
Draft
nchamo wants to merge 2 commits into
Draft
refactor(txe): normalize deploy and addAccount to oracle registry#23536nchamo wants to merge 2 commits into
nchamo wants to merge 2 commits into
Conversation
Collaborator
Flakey Tests🤖 says: This CI run detected 1 tests that failed, but were tolerated due to a .test_patterns.yml entry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why we are doing this
The
aztec_txe_deployandaztec_txe_addAccountoracles were the last two handlers with special-case pre-processing in the dispatcher. The dispatcher manually deserialized inputs, resolved artifacts, cached them in module-level maps, and mutated theinputsarray before forwarding to the session. This made the dispatcher responsible for domain logic that belongs in the oracle layer, and prevented these oracles from using the typedcallTxeHandlerregistry pattern that all other oracles use.Our fix
TXEArtifactResolverservice, shared across all sessions via injection from the dispatcher. Uses a singleMap<string, Promise<ResolvedArtifact>>for deduplication of both in-flight and completed computations.TXEOracleTopLevelContext, which now accepts raw typed parameters and handles artifact resolution internally.TXE_ORACLE_REGISTRYwith proper type mappings (STRfor contract path/initializer,U32for args length, etc.), sorpc_translator.tsusescallTxeHandlerlike every other oracle.