feat: merge-train/fairies#23459
Open
AztecBot wants to merge 11 commits into
Open
Conversation
Collaborator
Author
|
🤖 Auto-merge enabled after 4 hours of inactivity. This PR will be merged automatically once all checks pass. |
#23500) Forward-port of #23470 (originally merged to `backport-to-v4-next-staging` for the v4 release line). > [!IMPORTANT] > Do not merge until we get a green v4 nightly release. ## Summary The v4.3.0 release shipped contract artifact JSONs with `aztec_version: "dev"` baked in, which caused ci-compat-e2e to fail because the artifact version did not match the expected tested version. The root cause is that `REF_NAME` is not reliably populated when the release artifacts are built, so `stamp_aztec_version` in `noir-projects/noir-contracts/bootstrap.sh` was falling back to `"dev"`. The fix re-stamps the version at the point in the release process where the actual version is known: - `ci3/release_prep_package_json` now stamps `aztec_version` into `artifacts/*.json` at npm-publish time using the authoritative `$version` arg. - `release-image/Dockerfile` now re-stamps `aztec_version` into all shipped contract artifacts (accounts, noir-contracts.js, noir-test-contracts.js) using `$VERSION` at image build time. - `noir-projects/noir-contracts/bootstrap.sh` is simplified to always stamp `"dev"` (renamed to `stamp_dev_aztec_version`) — the real version is now applied at publish time by whichever path owns it. The `stamp_dev_aztec_version` helper preserves the `cat`/`rm` pattern from #23174 so artifact file permissions aren't clobbered. The `assertContractArtifactsVersion()` bypass from the original PR is omitted here because v5 doesn't have the bad v4.3.0 artifact in its compat matrix. ## Verification (from the original PR) - **npm release**: `DRY_RUN=1 ../../ci3/deploy_npm latest 5.1.0-test` produced artifacts with `aztec_version: "5.1.0-test"`. - **docker release**: built the docker image and inspected the contract artifacts inside — `aztec_version` matches `$VERSION`. Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BEGIN_COMMIT_OVERRIDE
feat(txe): add TXE oracle version check to bootstrap (#23324)
fix(txe): correct TXE_ORACLE_INTERFACE_HASH to match current oracle interface (#23460)
feat(aztec-nr): add Serialize/Deserialize for EphemeralArray (#23417)
refactor: move validation and error handling out of transport layer (#23422)
feat(pxe)!: add source and block-range filtering to get_logs_by_tag (#23326)
fix(txe): update TXE oracle interface hash for new AVM oracle methods (#23492)
chore(ci): capture sandbox diagnostics on acceptance test failure (#23495)
feat(aztec-nr)!: rename push_nullifier to push_nullifier_unsafe (#23488)
feat(aztec-nr)!: add explicit custom_sync_state hook to AztecConfig (#23446)
fix(ci): skip aztec-cli notify job when acceptance test is skipped (#23534)
fix: released contract artifact aztec version (forward port of #23470) (#23500)
END_COMMIT_OVERRIDE