Normalize address to lowercase in Go, revert lower() from SQL queries

Agent-Logs-Url: https://github.com/AudiusProject/api/sessions/9df9ff3f-61bc-492a-bfde-45791942537c

Co-authored-by: rickyrombo <3690498+rickyrombo@users.noreply.github.com>

Author: Copilot

api/dbv1/get_developer_apps.sql.go

@@ -9,7 +9,7 @@ SELECT
 FROM developer_apps da
 LEFT JOIN oauth_redirect_uris oau ON oau.client_id = da.address
 WHERE
-  (da.user_id = @user_id OR lower(da.address) = lower(@address))
+  (da.user_id = @user_id OR da.address = @address)
   AND da.is_current = true
   AND da.is_delete = false
 GROUP BY da.address, da.user_id, da.name, da.description, da.image_url, da.created_at
@@ -27,7 +27,7 @@ SELECT
 FROM developer_apps
 LEFT JOIN grants ON grants.grantee_address = developer_apps.address
 WHERE
-  (grants.user_id = @user_id OR lower(developer_apps.address) = lower(@address))
+  (grants.user_id = @user_id OR developer_apps.address = @address)
   AND grants.is_revoked = false
   AND grants.is_current = true
   AND developer_apps.is_current = true

api/dbv1/queries/get_developer_apps.sql

@@ -18,6 +18,10 @@ func (app *ApiServer) v1DeveloperApps(c *fiber.Ctx) error {
 		address = "0x" + address
 	}
 
+	// Normalize address to lowercase to ensure case-insensitive matching
+	// (addresses in the DB are stored as lowercase)
+	address = strings.ToLower(address)
+
 	developerApps, err := app.queries.GetDeveloperApps(c.Context(), dbv1.GetDeveloperAppsParams{
 		Address: address,
 	})

api/v1_developer_apps.go

@@ -8,14 +8,16 @@ import (
 	"github.com/stretchr/testify/assert"
 )
 
+const testDeveloperAppAddress = "0x7d7b6b7a97d1deefe3a1ccc5a13c48e8f055e0b6"
+
 func TestGetDeveloperAppsQueries(t *testing.T) {
 	app := testAppWithFixtures(t)
 	developerApps, err := app.queries.GetDeveloperApps(t.Context(), dbv1.GetDeveloperAppsParams{
 		UserID: 1,
 	})
 	assert.NoError(t, err)
 	assert.Len(t, developerApps, 1)
-	assert.Equal(t, "0x7d7b6b7a97d1deefe3a1ccc5a13c48e8f055e0b6", developerApps[0].Address)
+	assert.Equal(t, testDeveloperAppAddress, developerApps[0].Address)
 	// redirect_uris must be an empty slice (not nil) when no URIs are registered
 	assert.Equal(t, []string{}, developerApps[0].RedirectUris)
 }
@@ -26,11 +28,83 @@ func TestGetDeveloperApp(t *testing.T) {
 	var resp struct {
 		Data dbv1.GetDeveloperAppsRow
 	}
-	status, body := testGet(t, app, "/v1/developer_apps/0x7d7b6b7a97d1deefe3a1ccc5a13c48e8f055e0b6", &resp)
+	status, body := testGet(t, app, "/v1/developer_apps/"+testDeveloperAppAddress, &resp)
 	assert.Equal(t, 200, status)
 	assert.True(t, strings.Contains(string(body), `"user_id":"7eP5n"`))
 	assert.True(t, strings.Contains(string(body), `"name":"cool app"`))
 	assert.Equal(t, "cool app", resp.Data.Name)
 	// redirect_uris must be an empty slice (not nil) when no URIs are registered
 	assert.Equal(t, []string{}, resp.Data.RedirectUris)
 }
+
+func TestGetDeveloperAppUppercaseAddress(t *testing.T) {
+	app := testAppWithFixtures(t)
+
+	var resp struct {
+		Data dbv1.GetDeveloperAppsRow
+	}
+	// Uppercase address should still find the app (case-insensitive lookup)
+	status, _ := testGet(t, app, "/v1/developer_apps/0x7D7B6B7A97D1DEEFE3A1CCC5A13C48E8F055E0B6", &resp)
+	assert.Equal(t, 200, status)
+	assert.Equal(t, "cool app", resp.Data.Name)
+}
+
+func TestGetDeveloperAppMixedCaseAddress(t *testing.T) {
+	app := testAppWithFixtures(t)
+
+	var resp struct {
+		Data dbv1.GetDeveloperAppsRow
+	}
+	// Mixed-case address should still find the app (case-insensitive lookup)
+	status, _ := testGet(t, app, "/v1/developer_apps/0x7d7B6B7A97d1deEFe3A1ccc5A13c48E8F055e0B6", &resp)
+	assert.Equal(t, 200, status)
+	assert.Equal(t, "cool app", resp.Data.Name)
+}
+
+func TestGetDeveloperAppWithoutHexPrefix(t *testing.T) {
+	app := testAppWithFixtures(t)
+
+	var resp struct {
+		Data dbv1.GetDeveloperAppsRow
+	}
+	// Address without 0x prefix should still find the app
+	status, _ := testGet(t, app, "/v1/developer_apps/7D7B6B7A97D1DEEFE3A1CCC5A13C48E8F055E0B6", &resp)
+	assert.Equal(t, 200, status)
+	assert.Equal(t, "cool app", resp.Data.Name)
+}
+
+func TestGetDeveloperAppUppercaseAddress(t *testing.T) {
+	app := testAppWithFixtures(t)
+
+	var resp struct {
+		Data dbv1.GetDeveloperAppsRow
+	}
+	// Uppercase address should still find the app (case-insensitive lookup)
+	status, _ := testGet(t, app, "/v1/developer_apps/0x7D7B6B7A97D1DEEFE3A1CCC5A13C48E8F055E0B6", &resp)
+	assert.Equal(t, 200, status)
+	assert.Equal(t, "cool app", resp.Data.Name)
+}
+
+func TestGetDeveloperAppMixedCaseAddress(t *testing.T) {
+	app := testAppWithFixtures(t)
+
+	var resp struct {
+		Data dbv1.GetDeveloperAppsRow
+	}
+	// Mixed-case address should still find the app (case-insensitive lookup)
+	status, _ := testGet(t, app, "/v1/developer_apps/0x7d7B6B7A97d1deEFe3A1ccc5A13c48E8F055e0B6", &resp)
+	assert.Equal(t, 200, status)
+	assert.Equal(t, "cool app", resp.Data.Name)
+}
+
+func TestGetDeveloperAppWithoutHexPrefix(t *testing.T) {
+	app := testAppWithFixtures(t)
+
+	var resp struct {
+		Data dbv1.GetDeveloperAppsRow
+	}
+	// Address without 0x prefix should still find the app
+	status, _ := testGet(t, app, "/v1/developer_apps/7D7B6B7A97D1DEEFE3A1CCC5A13C48E8F055E0B6", &resp)
+	assert.Equal(t, 200, status)
+	assert.Equal(t, "cool app", resp.Data.Name)
+}