Skip to content

Commit ff66e37

Browse files
Merge pull request #1 from AtlasAnalyticsLab/fix/minor-fix-after-first-deploy
Fix/minor fix after first deploy
2 parents a035aff + 066c5d0 commit ff66e37

16 files changed

+512
-213
lines changed

DEVELOPMENT.md

Lines changed: 27 additions & 46 deletions
Original file line numberDiff line numberDiff line change
@@ -195,6 +195,17 @@ git push origin feature/team-member-[name]
195195
# Open PR on GitHub
196196
```
197197

198+
#### Adding Gallery Photos
199+
```bash
200+
git checkout -b feature/add-gallery-photos-2025-12-02
201+
# Add photos to images/picpic/
202+
bundle exec jekyll serve # Test locally
203+
git add images/picpic/
204+
git commit -m "content: add lab photos from [event]"
205+
git push origin feature/add-gallery-photos-2025-12-02
206+
# Open PR on GitHub
207+
```
208+
198209
#### Layout/Design Changes
199210
```bash
200211
git checkout -b feature/[component]-redesign
@@ -294,10 +305,10 @@ git push origin hotfix/critical-issue
294305
default.html (base template)
295306
├── homelay.html (homepage with carousel + news)
296307
├── textlay.html (simple text pages)
308+
├── gallerylay.html (gallery with masonry layout)
297309
├── team.html (team member grids)
298310
├── publications.html (publication list wrapper)
299311
├── gridlay.html (publications grid)
300-
├── gridlay2.html (generic grid)
301312
└── bib.html (individual bibliography items)
302313
```
303314

@@ -323,16 +334,15 @@ default.html (base template)
323334
- `.github/ISSUE_TEMPLATE/` - Issue templates
324335
- `bin/deploy` - Manual deployment script
325336

326-
#### Layouts (12 files)
337+
#### Layouts (8 files)
327338
1. **default.html** - Base template with `<html>`, header, footer
328339
2. **homelay.html** - Homepage two-column layout (main content + news sidebar)
329340
3. **textlay.html** - Full-width text layout for simple pages
330-
4. **team.html** - Team page with member grids
331-
5. **publications.html** - Publications page wrapper
332-
6. **gridlay.html** - Grid layout for publications
333-
7. **gridlay2.html** - Generic grid layout (available for future use)
341+
4. **gallerylay.html** - Gallery layout with CSS Grid masonry and optimized spacing
342+
5. **team.html** - Team page with member grids
343+
6. **publications.html** - Publications page wrapper
344+
7. **gridlay.html** - Grid layout for publications
334345
8. **bib.html** - Individual bibliography item rendering
335-
9. **piclay.html** - Picture gallery layout (unused, can be deleted)
336346

337347
#### Includes (10 files)
338348
1. **head.html** - HTML `<head>` section with metadata, stylesheets, CDN links
@@ -364,11 +374,11 @@ default.html (base template)
364374
5. **funding.md** - Funding acknowledgements
365375
6. **contact.md** - Contact information and directions
366376
7. **allnews.md** - Complete news archive
367-
8. **gallery.md** - Lab life photo gallery
377+
8. **gallery.md** - Lab life photo gallery with CSS Grid masonry layout
368378
9. **aboutwebsite.md** - Template usage guide
369379
10. **404.md** - Custom error page with navigation buttons
370380

371-
#### Stylesheets (6 files)
381+
#### Stylesheets (7 files)
372382
1. **css/main.scss** - Main stylesheet entry point (630 lines, cleaned and organized Nov 2025)
373383
- Imports all SASS partials
374384
- Defines layout system (layout-wide vs layout-fixed)
@@ -379,14 +389,15 @@ default.html (base template)
379389
4. **_sass/_components.scss** - Custom components (buttons, panels, cards)
380390
5. **_sass/_publications.scss** - Publication card styles (30% image width, top-aligned)
381391
6. **_sass/_themes.scss** - Light/dark theme CSS custom properties
392+
7. **_sass/_gallery.scss** - Gallery masonry layout styles (CSS Grid with responsive columns)
382393

383-
#### JavaScript (2 files)
394+
#### JavaScript (3 files)
384395
1. **js/theme-toggle.js** - Three-state theme controller (light/dark/auto)
385-
2. **js/npm.js** - Legacy npm-related script (likely unused, can be deleted)
396+
2. **js/gallery-masonry.js** - Gallery masonry fallback for browsers without CSS Grid masonry support
397+
3. **js/external-links.js** - Automatically opens external links in new tabs
386398

387-
#### Ruby Plugins (2 files)
388-
1. **_plugins/hideCustomBibtex.rb** - BibTeX keyword filter
389-
2. **_plugins/markdown.rb** - Markdown include tag
399+
#### Ruby Plugins (1 file)
400+
1. **_plugins/hideCustomBibtex.rb** - BibTeX keyword filter for bibliography entries
390401

391402
#### Image Directories (5 directories, 52+ files)
392403
1. **images/homepic/** - Homepage carousel (auto-loaded, 4 images)
@@ -867,19 +878,12 @@ headline: "Text with [link](OPENINGS_LINK)"
867878
- ✅ 22 PDFs from `assets/papers/`
868879
- ✅ 4 PDFs from `assets/vacancies/`
869880

870-
**Total Deleted:** 24+ items (~2-3MB freed)
871-
872-
### Remaining Cleanup Items (1 item)
873-
874-
1. **`_layouts/piclay.html`** - Picture gallery layout (unused)
875-
```bash
876-
rm _layouts/piclay.html
877-
```
881+
**Total Deleted:** 28+ items (~3MB freed)
878882

879883
### Files to Keep
880884

881885
**Essential Layouts (8 files):**
882-
- All active layouts: default, homelay, textlay, team, publications, gridlay, gridlay2, bib
886+
- All active layouts: default, homelay, textlay, gallerylay, team, publications, gridlay, bib
883887

884888
**Active Data Files (8 files):**
885889
- All team and content data files in `_data/`
@@ -972,29 +976,6 @@ headline: "Text with [link](OPENINGS_LINK)"
972976
- Check for slow-loading pages
973977
- Review CDN performance
974978

975-
### Next Cleanup (Immediate)
976-
977-
```bash
978-
# Delete remaining unused file
979-
rm _layouts/piclay.html
980-
981-
# Commit cleanup
982-
git add -A
983-
git commit -m "chore: remove unused file (piclay.html)"
984-
git push
985-
```
986-
987-
### Next Review
988-
989-
**Scheduled:** December 2025
990-
991-
**Tasks:**
992-
- [ ] Review and update this documentation
993-
- [ ] Check for new unused files
994-
- [ ] Audit image usage
995-
- [ ] Review security configurations
996-
- [ ] Update changelog with new features
997-
998979
---
999980

1000981
## Verification Commands

README.md

Lines changed: 84 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,8 @@
33
Official website for the **Atlas Analytics Lab** at Concordia University, Montreal. We focus on AI research in computational pathology, foundation models, and medical imaging.
44

55
**🌐 Live Site:** https://atlasanalyticslab.github.io
6-
**📧 Contact:** mahdi.hosseini@concordia.ca
6+
**📧 Contact:** mahdi.hosseini@concordia.ca
7+
**📊 Site Stats:** 8 layouts · 10 includes · 3 JS modules · 10 pages · Clean codebase (Dec 2025 audit)
78

89
---
910

@@ -143,10 +144,23 @@ Simply add images to this directory - they automatically appear in the carousel.
143144

144145
### Lab Life Gallery
145146

146-
**Directory:** `images/picpic/`
147+
**Directory:** `images/picpic/`
148+
**Layout:** CSS Grid Masonry (auto-reordering for tight packing)
147149

148150
Add photos of lab events, conferences, and activities. They automatically appear on the `/gallery/` page.
149151

152+
**Features:**
153+
- **Automatic image loading** - Just drop images in `images/picpic/`
154+
- **Masonry layout** - Images automatically reorder to minimize gaps
155+
- **Responsive grid** - 1 column (mobile) → 2 (tablet) → 3 (desktop) → 4 (large screens)
156+
- **Respects layout_wide setting** - Adapts to site-wide layout configuration
157+
- **Supported formats:** JPG, JPEG, PNG
158+
159+
**How it works:**
160+
- Images sorted by filename in reverse order (newest first)
161+
- CSS Grid masonry with JavaScript fallback for browser compatibility
162+
- No code changes needed when adding/removing photos
163+
150164
---
151165

152166
## Project Structure
@@ -222,6 +236,53 @@ yes | bash bin/deploy --src main --deploy gh-pages
222236

223237
---
224238

239+
## Architecture & Technology
240+
241+
### Core Technologies
242+
243+
**Static Site Generator:**
244+
- Jekyll 4.4.1 (Ruby-based)
245+
- Liquid templating engine
246+
- Kramdown Markdown processor
247+
248+
**Frontend Framework:**
249+
- Bootstrap 5 (Lumen theme)
250+
- Custom SCSS modules (5 partials)
251+
- Responsive design (5 breakpoints: 576px, 768px, 992px, 1200px, 1400px)
252+
253+
**JavaScript Modules (3 files):**
254+
1. `theme-toggle.js` - Three-state theme switcher (light/dark/auto)
255+
2. `gallery-masonry.js` - CSS Grid masonry fallback
256+
3. `external-links.js` - Auto-opens external links in new tabs
257+
258+
**Layout System:**
259+
- 8 layout templates (`_layouts/`)
260+
- 10 reusable components (`_includes/`)
261+
- Layout-wide mode: configurable full-width or fixed 1000px
262+
263+
### File Structure Overview
264+
265+
```
266+
├── _layouts/ # 8 page layouts (default, homelay, textlay, etc.)
267+
├── _includes/ # 10 reusable components (header, footer, etc.)
268+
├── _pages/ # 10 content pages (Markdown)
269+
├── _data/ # 8 YAML data files (team, publications, news)
270+
├── _sass/ # 5 SCSS modules (variables, components, themes, etc.)
271+
├── _plugins/ # 1 Ruby plugin (BibTeX filter)
272+
├── css/ # Main stylesheet entry point
273+
├── js/ # 3 JavaScript modules
274+
├── images/ # 5 subdirectories (team, publications, gallery, etc.)
275+
└── assets/ # Additional resources (PDFs, documents)
276+
```
277+
278+
**Code Quality:**
279+
- Comprehensive inline documentation (all files)
280+
- Standardized comment headers
281+
- Zero unused/redundant code (Dec 2025 audit)
282+
- Clean, maintainable codebase
283+
284+
---
285+
225286
## Support & Maintenance
226287

227288
### Troubleshooting
@@ -271,22 +332,34 @@ bundle install
271332
## Technology Stack
272333

273334
- **Static Site Generator:** Jekyll 4.4.1
274-
- **Hosting:** GitHub Pages
335+
- **Hosting:** GitHub Pages (automatic deployment)
275336
- **Frontend Framework:** Bootstrap 5 (Lumen theme via jsDelivr CDN)
276-
- **Template Engine:** Liquid
277-
- **Styling:** SCSS/SASS
278-
- **Theme:** Light/Dark mode with auto-detection
337+
- **Template Engine:** Liquid (Jekyll's templating system)
338+
- **Styling:** SCSS/SASS with 5 modular partials
339+
- **JavaScript:** 3 vanilla JS modules (theme switcher, gallery masonry, external links)
340+
- **Theme:** Light/Dark/Auto mode with CSS custom properties
341+
- **Ruby Plugin:** 1 custom Liquid filter (BibTeX keyword hiding)
342+
343+
**Build Stats:**
344+
- 8 layouts, 10 includes, 10 pages
345+
- 8 YAML data files
346+
- 5+ image directories with auto-loading
347+
- Clean codebase (0 unused files as of Dec 2025)
279348

280349
---
281350

282351
## Contributing
283352

284353
For lab members and collaborators, see `DEVELOPMENT.md` for detailed development documentation including:
285-
- Detailed file structure and design decisions
354+
- Git workflow and branching strategy
355+
- Detailed file structure and architecture
286356
- Comment standardization guidelines
287-
- Development history and changelog
288-
- Cleanup reports and maintenance tasks
289-
- URL management and configuration details
357+
- Development history and changelog
358+
- Code cleanup reports
359+
- Maintenance tasks and verification commands
360+
- URL management and configuration
361+
362+
Quick member instructions: `.github/Instructions_members.md`
290363

291364
---
292365

@@ -315,4 +388,4 @@ Concordia University, Montreal, QC, Canada
315388

316389
---
317390

318-
**Last Updated:** December 1, 2025
391+
**Last Updated:** December 2, 2025

_config.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ description: > # this means to ignore newlines until "baseurl:"
2727
Website of the Atlas Analytics Lab.
2828
baseurl: ""
2929
url: "https://atlasanalyticslab.github.io"
30-
layout_wide: false # Set to false to restore the previous fixed-width layout with generous side margins.
30+
layout_wide: true # Set to false to restore the previous fixed-width layout with generous side margins.
3131

3232
include:
3333
- .htaccess

_data/alumni_members.yml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -37,28 +37,28 @@
3737
#==============================================================================
3838

3939
- name: Ali Nasiri-Sarvi
40-
info_current: Research Assistant @ Atlas Analytics Lab, Research Associate @ Huawei
40+
info_current: MSc Graduate, Research Assistant @ Atlas Analytics Lab, Research Associate @ Huawei
4141
google_scholar: "https://scholar.google.com/citations?user=FzicxBkAAAAJ"
4242
linkedin: "https://ca.linkedin.com/in/ali-nasiri-sarvi"
4343

4444
- name: Haoyu He
45-
info_current: Graduated MSc, transferred to PhD @ Atlas Analytics Lab
45+
info_current: MSc Graduate, transferred to PhD @ Atlas Analytics Lab
4646

4747
- name: Damien Martins Gomes
48-
info_current: AI Scientist @ Thales
48+
info_current: MSc Graduate, AI Scientist @ Thales
4949
google_scholar: "https://scholar.google.ca/citations?user=ivIgsbMAAAAJ"
5050
linkedin: "https://fr.linkedin.com/in/damien-martins-gomes/fr"
5151

5252
- name: Vasudev Sharma
53-
info_current: ML Developer @ Botni.Vision
53+
info_current: MSc Graduate, ML Developer @ Botni.Vision
5454
linkedin: "https://ca.linkedin.com/in/vasudev-sharma-341171256"
5555

5656
- name: Cassandre Notton
57-
info_current: ML Engineer @ Quandela
57+
info_current: MSc Graduate, ML Engineer @ Quandela
5858
google_scholar: "https://scholar.google.com/citations?hl=en&user=H5zKrXcAAAAJ"
5959
linkedin: "https://ca.linkedin.com/in/cassandre-notton-69ba6a131"
6060

6161
- name: Denisha Thakkar
62-
info_current: ML Egnineer @ CIBC
62+
info_current: MSc Graduate, ML Egnineer @ CIBC
6363
linkedin: "https://ca.linkedin.com/in/denisha-thakkar"
6464

_includes/footer.html

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -25,10 +25,7 @@
2525
<div class="row g-4">
2626
<!-- Column: lab summary and modification notice (left-most). -->
2727
<div class="col-md-4">
28-
<p class="mb-2">&copy; {{ site.time | date: '%Y' }} Atlas Analytics Lab. Site made with
29-
<a href="https://jekyllrb.com">Jekyll</a>;
30-
<a href="{{ site.url }}{{ site.baseurl }}/aboutwebsite.html">copy and modify it for your own research group.</a>
31-
</p>
28+
<p class="mb-2">&copy; {{ site.time | date: '%Y' }} Atlas Analytics Lab.</p>
3229
<p class="mb-0">We are part of the
3330
<a href="https://www.concordia.ca/ginacody/computer-science-software-eng.html">Department of Computer Science and Software Engineering (CSSE)</a> at
3431
<a href="https://www.concordia.ca/">Concordia University</a>.

0 commit comments

Comments
 (0)