Move ConnectionSemaphore creation to NettyRequestSender constructor

Author: slandelle

client/src/main/java/org/asynchttpclient/DefaultAsyncHttpClient.java

@@ -17,9 +17,6 @@
 package org.asynchttpclient;
 
 import static org.asynchttpclient.util.Assertions.assertNotNull;
-import io.netty.channel.EventLoopGroup;
-import io.netty.util.HashedWheelTimer;
-import io.netty.util.Timer;
 
 import java.util.concurrent.atomic.AtomicBoolean;
 import java.util.function.Predicate;
@@ -30,11 +27,14 @@
 import org.asynchttpclient.filter.RequestFilter;
 import org.asynchttpclient.handler.resumable.ResumableAsyncHandler;
 import org.asynchttpclient.netty.channel.ChannelManager;
-import org.asynchttpclient.netty.channel.ConnectionSemaphore;
 import org.asynchttpclient.netty.request.NettyRequestSender;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
+import io.netty.channel.EventLoopGroup;
+import io.netty.util.HashedWheelTimer;
+import io.netty.util.Timer;
+
 /**
  * Default and threadsafe implementation of {@link AsyncHttpClient}.
  */
@@ -83,8 +83,7 @@ public DefaultAsyncHttpClient(AsyncHttpClientConfig config) {
         nettyTimer = allowStopNettyTimer ? newNettyTimer() : config.getNettyTimer();
 
         channelManager = new ChannelManager(config, nettyTimer);
-        ConnectionSemaphore connectionSemaphore = ConnectionSemaphore.newConnectionSemaphore(config);
-        requestSender = new NettyRequestSender(config, channelManager, connectionSemaphore, nettyTimer, new AsyncHttpClientState(closed));
+        requestSender = new NettyRequestSender(config, channelManager, nettyTimer, new AsyncHttpClientState(closed));
         channelManager.configureBootstraps(requestSender);
     }
 

client/src/main/java/org/asynchttpclient/netty/request/NettyRequestSender.java

@@ -84,12 +84,11 @@ public final class NettyRequestSender {
 
     public NettyRequestSender(AsyncHttpClientConfig config,//
             ChannelManager channelManager,//
-            ConnectionSemaphore connectionSemaphore,//
             Timer nettyTimer,//
             AsyncHttpClientState clientState) {
         this.config = config;
         this.channelManager = channelManager;
-        this.connectionSemaphore = connectionSemaphore;
+        this.connectionSemaphore = ConnectionSemaphore.newConnectionSemaphore(config);
         this.nettyTimer = nettyTimer;
         this.clientState = clientState;
         requestFactory = new NettyRequestFactory(config);