style: move parameter range to the end

Follow the existing AST convention that Range is the last constructor field and the last factory/helper parameter. This updates ParameterNode and Node.createParameter accordingly, and adjusts all call sites.

Author: jtenner

src/ast.ts

@@ -181,12 +181,10 @@ export abstract class Node {
     name: IdentifierExpression,
     type: TypeNode,
     initializer: Expression | null,
-    range: Range,
-    decorators: DecoratorNode[] | null = null
+    decorators: DecoratorNode[] | null,
+    range: Range
   ): ParameterNode {
-    let parameter = new ParameterNode(parameterKind, name, type, initializer, range);
-    parameter.decorators = decorators;
-    return parameter;
+    return new ParameterNode(parameterKind, name, type, initializer, decorators, range);
   }
 
   // special
@@ -971,14 +969,13 @@ export class ParameterNode extends Node {
     public type: TypeNode,
     /** Initializer expression, if any. */
     public initializer: Expression | null,
+    /** Decorators, if any, preserved so transforms can rewrite them before validation. */
+    public decorators: DecoratorNode[] | null,
     /** Source range. */
     range: Range
   ) {
     super(NodeKind.Parameter, range);
   }
-
-  /** Decorators, if any, preserved so transforms can rewrite them before validation. */
-  decorators: DecoratorNode[] | null = null;
   /** Implicit field declaration, if applicable. */
   implicitFieldDeclaration: FieldDeclaration | null = null;
   /** Common flags indicating specific traits. */

src/parser.ts

@@ -803,7 +803,7 @@ export class Parser extends DiagnosticEmitter {
               return null;
             }
             this.reportInvalidParameterDecorators(tn);
-            let param = Node.createParameter(kind, name, type, null, tn.range(paramStart, tn.pos), decorators);
+            let param = Node.createParameter(kind, name, type, null, decorators, tn.range(paramStart, tn.pos));
             if (!parameters) parameters = [ param ];
             else parameters.push(param);
           } else {
@@ -815,7 +815,7 @@ export class Parser extends DiagnosticEmitter {
               }
             }
             if (isSignature) {
-              let param = Node.createParameter(kind, name, Node.createOmittedType(tn.range(tn.pos)), null, tn.range(paramStart, tn.pos), decorators);
+              let param = Node.createParameter(kind, name, Node.createOmittedType(tn.range(tn.pos)), null, decorators, tn.range(paramStart, tn.pos));
               if (!parameters) parameters = [ param ];
               else parameters.push(param);
               this.error(
@@ -869,6 +869,7 @@ export class Parser extends DiagnosticEmitter {
             firstParamNameNoType,
             Node.createOmittedType(firstParamNameNoType.range.atEnd),
             null,
+            null,
             firstParamNameNoType.range
           );
           if (!parameters) parameters = [ param ];
@@ -1506,8 +1507,8 @@ export class Parser extends DiagnosticEmitter {
         identifier,
         type,
         initializer,
-        Range.join(assert(startRange), tn.range()),
-        decorators
+        decorators,
+        Range.join(assert(startRange), tn.range())
       );
       param.flags |= accessFlags;
       return param;
@@ -4040,6 +4041,7 @@ export class Parser extends DiagnosticEmitter {
                 identifier,
                 Node.createOmittedType(identifier.range.atEnd),
                 null,
+                null,
                 identifier.range
               )
             ],

src/program.ts

@@ -2780,6 +2780,7 @@ export class Program extends DiagnosticEmitter {
                 declaration.name,
                 typeNode,
                 null,
+                null,
                 declaration.name.range
               )
             ],
@@ -4096,7 +4097,10 @@ export class PropertyPrototype extends DeclaredElement {
           new ParameterNode(
             ParameterKind.Default,
             fieldDeclaration.name,
-            typeNode, null, nativeRange
+            typeNode,
+            null,
+            null,
+            nativeRange
           )
         ],
         new NamedTypeNode(