Antalya 26.4: 26.3 Antalya port - fixes for s3Cluster distributed calls#1880
Open
zvonand wants to merge 2 commits into
Open
Antalya 26.4: 26.3 Antalya port - fixes for s3Cluster distributed calls#1880zvonand wants to merge 2 commits into
zvonand wants to merge 2 commits into
Conversation
…next commit) --- Original cherry-pick message follows: Merge pull request #1646 from Altinity/frontport/antalya-26.3/fix_remote_calls 26.3 Antalya port - fixes for s3Cluster distributed calls # Conflicts: # src/Processors/QueryPlan/ObjectFilterStep.cpp # src/Processors/QueryPlan/ObjectFilterStep.h # src/Processors/QueryPlan/ReadFromRemote.cpp # src/QueryPipeline/RemoteQueryExecutor.h # src/Storages/ObjectStorage/StorageObjectStorageCluster.cpp # tests/integration/test_database_iceberg/test.py # tests/integration/test_s3_cluster/test.py
Kept 26.4's const-ref signature for ObjectFilterStep constructor (bucket 2: 26.4 improved the parameter from value to const-ref). Kept 26.4's detailed comment in ObjectFilterStep.h (bucket 2: 26.4 added more descriptive documentation). Kept both setDistributedFanout (26.4 addition) and the source PR's setRemoteFunction/setShardCount in RemoteQueryExecutor.h and ReadFromRemote.cpp — they serve different purposes. Kept 26.4's inline virtuals expression in StorageObjectStorageCluster.cpp instead of getVirtualsList() (bucket 2: getVirtualsList does not exist on antalya-26.4; the verbose expression is the equivalent). In test_s3_cluster: kept new tests test_remote_hedged, test_remote_no_hedged, test_joins from source PR; kept 26.4's two-parameter test_hive_partitioning (with use_partition_strategy) instead of source PR's one-parameter version; dropped test_graceful_shutdown (pre-existing in 26.3, not added by PR #1646). In test_database_iceberg: kept both test_invalid_auth_header_format (26.4) and _test_cluster_joins (source PR).
zvonand
added
releasy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Frontports for Antalya 26.3
CI/CD Options
Exclude tests:
Regression jobs to run:
Cherry-picked from #1646.