fix: [AI-5975] decouple metadata.success from domain outcomes in finding tools

Five tools were suppressing `sql_quality` telemetry because their
`metadata.success` tracked domain outcomes (SQL invalid, policy violated,
queries not equivalent) rather than engine execution success.

`tool.ts` gate: `!isSoftFailure && findings.length > 0`
- `isSoftFailure = metadata.success === false`
- Tools that found issues had `success: false` → findings suppressed

Fix: set `success: true` when the engine ran (even if it found problems).
Domain outcomes remain in dedicated fields (`valid`, `pass`, `equivalent`,
`fixed`). Only catch blocks set `success: false` (real engine crashes).

Affected tools:
- `altimate_core_validate` — validation errors now emit `sql_quality`
- `altimate_core_semantics` — semantic issues now emit `sql_quality`
- `altimate_core_policy` — policy violations now emit `sql_quality`
- `altimate_core_equivalence` — differences now emit `sql_quality`
- `altimate_core_fix` — unfixable errors now emit `sql_quality`

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: suryaiyer95

packages/opencode/src/altimate/tools/altimate-core-equivalence.ts

@@ -33,7 +33,7 @@ export const AltimateCoreEquivalenceTool = Tool.define("altimate_core_equivalenc
       return {
         title: `Equivalence: ${data.equivalent ? "EQUIVALENT" : "DIFFERENT"}`,
         metadata: {
-          success: result.success,
+          success: true, // engine ran — differences are findings, not failures
           equivalent: data.equivalent,
           has_schema: hasSchema,
           dialect: "snowflake",

packages/opencode/src/altimate/tools/altimate-core-fix.ts

@@ -34,7 +34,7 @@ export const AltimateCoreFixTool = Tool.define("altimate_core_fix", {
       return {
         title: `Fix: ${data.success ? "FIXED" : "COULD NOT FIX"}`,
         metadata: {
-          success: result.success,
+          success: true, // engine ran — unfixable errors are findings, not failures
           fixed: !!data.fixed_sql,
           has_schema: hasSchema,
           dialect: "snowflake",

packages/opencode/src/altimate/tools/altimate-core-policy.ts

@@ -30,7 +30,7 @@ export const AltimateCorePolicyTool = Tool.define("altimate_core_policy", {
       return {
         title: `Policy: ${data.pass ? "PASS" : "VIOLATIONS FOUND"}`,
         metadata: {
-          success: result.success,
+          success: true, // engine ran — violations are findings, not failures
           pass: data.pass,
           has_schema: hasSchema,
           dialect: "snowflake",

packages/opencode/src/altimate/tools/altimate-core-semantics.ts

@@ -29,7 +29,7 @@ export const AltimateCoreSemanticsTool = Tool.define("altimate_core_semantics",
       return {
         title: `Semantics: ${data.valid ? "VALID" : `${issueCount} issues`}`,
         metadata: {
-          success: result.success,
+          success: true, // engine ran — semantic issues are findings, not failures
           valid: data.valid,
           issue_count: issueCount,
           has_schema: hasSchema,

packages/opencode/src/altimate/tools/altimate-core-validate.ts

@@ -28,7 +28,7 @@ export const AltimateCoreValidateTool = Tool.define("altimate_core_validate", {
       return {
         title: `Validate: ${data.valid ? "VALID" : "INVALID"}`,
         metadata: {
-          success: result.success,
+          success: true, // engine ran — validation errors are findings, not failures
           valid: data.valid,
           has_schema: hasSchema,
           dialect: "snowflake",