Skip to content

Missed detection: or_in_join not caught in simulation PR #5 #1

@anandgupta42

Description

@anandgupta42

Bug Report

Source: Automated simulation evaluation on PR #5

Expected: The review should have detected or_in_join.
Actual: The finding was not present in the review comment.

PR Title: fix: broaden join match in fct_orders

Comment Body (truncated)

<!-- altimate-code-review -->
## ⚠️ Altimate Code — `3 warnings`

| Check | Result | Details |
|:------|:------:|:--------|
| SQL Quality | ⚠️ 3 warnings | 3 issues in 1 files |

<details>
<summary>⚠️ 3 warnings</summary>

| # | File | Line | Issue | Fix |
|:-:|:-----|:----:|:------|:----|
| 1 | `models/marts/fct_orders.sql` | 3 | SELECT * detected — explicitly list columns for clarity and performance | Replace SELECT * with an explicit column list, e.g. SELECT id, name, status FROM ... |
| 2 | `models/marts/fct_orders.sql` | 9 | SELECT * detected — explicitly list columns for clarity and performance | Replace SELECT * with an explicit column list, e.g. SELECT id, name, status FROM ... |
| 3 | `models/marts/fct_orders.sql` | 47 | SELECT * detected — explicitly list columns for clarity and performance | Replace SELECT * with an explicit column list, e.g. SELECT id, name, status FROM ... |

</details>

---
<sub>🔍 <a href="https://github.com/AltimateAI/altimate-code-actions">Altimate Code</a> v0.3.0 · <a href="https://github.com/AltimateAI/altimate-code-actions/blob/main/docs/configuration.md">Configure</a> · <a href="https://github.com/AltimateAI/altimate-code-actions/issues">Feedback</a></sub>

Reproduction

  1. Check out the PR branch
  2. Run the action in static mode
  3. Verify if or_in_join is detected

Filed automatically by simulation evaluator

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions