Fix performance

Author: vkucera

PWGHF/D2H/TableProducer/dataCreatorCharmHadPiReduced.cxx

@@ -1330,6 +1330,7 @@ struct HfDataCreatorCharmHadPiReduced {
 
         if constexpr (doMc) {
           std::vector<typename TTracks::iterator> beautyHadDauTracks{};
+          beautyHadDauTracks.reserve(charmHadDauTracks.size());
           for (const auto& track : charmHadDauTracks) {
             beautyHadDauTracks.push_back(track);
           }

PWGHF/D2H/TableProducer/dataCreatorCharmResoReduced.cxx

@@ -443,8 +443,8 @@ struct HfDataCreatorCharmResoReduced {
   template <typename Coll, typename Tr>
   bool buildAndSelectV0(const Coll& collision, const std::array<int, 3>& dDaughtersIds, const std::array<Tr, 2>& dauTracks)
   {
-    auto trackPos = dauTracks[0];
-    auto trackNeg = dauTracks[1];
+    const auto& trackPos = dauTracks[0];
+    const auto& trackNeg = dauTracks[1];
     // single-tracks selection
     if (!selectV0Daughter(trackPos, dDaughtersIds) || !selectV0Daughter(trackNeg, dDaughtersIds))
       return false;

PWGHF/D2H/TableProducer/dataCreatorJpsiHadReduced.cxx

@@ -913,6 +913,7 @@ struct HfDataCreatorJpsiHadReduced {
 
           if constexpr (doMc) {
             std::vector<typename TTracks::iterator> beautyHadDauTracks{};
+            beautyHadDauTracks.reserve(jPsiDauTracks.size());
             for (const auto& track : jPsiDauTracks) {
               beautyHadDauTracks.push_back(track);
             }
@@ -1034,6 +1035,7 @@ struct HfDataCreatorJpsiHadReduced {
 
             if constexpr (doMc) {
               std::vector<typename TTracks::iterator> beautyHadDauTracks{};
+              beautyHadDauTracks.reserve(jPsiDauTracks.size());
               for (const auto& track : jPsiDauTracks) {
                 beautyHadDauTracks.push_back(track);
               }

PWGHF/HFC/TableProducer/femtoDreamProducer.cxx

@@ -264,7 +264,7 @@ struct HfFemtoDreamProducer {
   }
 
   /// Function to retrieve the nominal magnetic field in kG (0.1T) and convert it directly to T
-  void getMagneticFieldTesla(aod::BCsWithTimestamps::iterator bc)
+  void getMagneticFieldTesla(const aod::BCsWithTimestamps::iterator& bc)
   {
     initCCDB(bc, runNumber, ccdb, !isRun3 ? ccdbPathGrp : ccdbPathGrpMag, lut, !isRun3);
   }

PWGHF/HFL/Tasks/taskElectronWeakBoson.cxx

@@ -366,7 +366,7 @@ struct HfTaskElectronWeakBoson {
     return std::make_pair(trackCount - 1, isoMomentum);
   }
 
-  void recoMassZee(KFParticle kfpIsoEle,
+  void recoMassZee(KFParticle const& kfpIsoEle,
                    int charge,
                    float centrality,
                    TrackEle const& tracks)

PWGHF/TableProducer/candidateCreatorLb.cxx

@@ -248,7 +248,7 @@ struct HfCandidateCreatorLb {
         rowCandidateProngs(lcCand.globalIndex(), trackPion.globalIndex());
         // calculate invariant mass
         auto arrayMomenta = std::array{pvecLc, pvecPion};
-        massLcPi = RecoDecay::m(std::move(arrayMomenta), std::array{massLc, massPi});
+        massLcPi = RecoDecay::m(arrayMomenta, std::array{massLc, massPi});
         if (lcCand.isSelLcToPKPi() > 0) {
           hMassLbToLcPi->Fill(massLcPi);
         }

PWGHF/TableProducer/candidateCreatorXicToXiPiPi.cxx

@@ -311,7 +311,7 @@ struct HfCandidateCreatorXicToXiPiPi {
 
       // get invariant mass of Xic candidate
       auto arrayMomenta = std::array{pVecXi, pVecPi0, pVecPi1};
-      massXiPiPi = RecoDecay::m(std::move(arrayMomenta), std::array{MassXiMinus, MassPiPlus, MassPiPlus});
+      massXiPiPi = RecoDecay::m(arrayMomenta, std::array{MassXiMinus, MassPiPlus, MassPiPlus});
 
       // get track impact parameters
       // This modifies track momenta!
@@ -336,9 +336,9 @@ struct HfCandidateCreatorXicToXiPiPi {
 
       // get invariant mass of Xi-pi pairs
       auto arrayMomentaXiPi0 = std::array{pVecXi, pVecPi0};
-      massXiPi0 = RecoDecay::m(std::move(arrayMomentaXiPi0), std::array{MassXiMinus, MassPiPlus});
+      massXiPi0 = RecoDecay::m(arrayMomentaXiPi0, std::array{MassXiMinus, MassPiPlus});
       auto arrayMomentaXiPi1 = std::array{pVecXi, pVecPi1};
-      massXiPi1 = RecoDecay::m(std::move(arrayMomentaXiPi1), std::array{MassXiMinus, MassPiPlus});
+      massXiPi1 = RecoDecay::m(arrayMomentaXiPi1, std::array{MassXiMinus, MassPiPlus});
 
       // get uncertainty of the decay length
       float phi, theta;

PWGHF/TableProducer/trackIndexSkimCreator.cxx

@@ -1933,7 +1933,7 @@ struct HfTrackIndexSkimCreator {
                                 aod::BCsWithTimestamps const&,
                                 std::vector<int64_t> const& vecPvContributorGlobId,
                                 std::vector<o2::track::TrackParCov> const& vecPvContributorTrackParCov,
-                                std::vector<int64_t> vecCandPvContributorGlobId,
+                                std::vector<int64_t> const& vecCandPvContributorGlobId,
                                 std::array<float, 3>& pvCoord,
                                 std::array<float, 6>& pvCovMatrix)
   {

PWGHF/TableProducer/treeCreatorTccToD0D0Pi.cxx

@@ -646,7 +646,7 @@ struct HfTreeCreatorTccToD0D0Pi {
             auto massKpipi1 = RecoDecay::m(std::array{pVecD1Prong0, pVecD1Prong1, pVecSoftPi}, std::array{massD1Daus[0], massD1Daus[1], MassPiPlus});
             auto massKpipi2 = RecoDecay::m(std::array{pVecD2Prong0, pVecD2Prong1, pVecSoftPi}, std::array{massD2Daus[0], massD2Daus[1], MassPiPlus});
             auto arrayMomentaDDpi = std::array{pVecD1, pVecD2, pVecSoftPi};
-            const auto massD0D0Pi = RecoDecay::m(std::move(arrayMomentaDDpi), std::array{MassD0, MassD0, MassPiPlus});
+            const auto massD0D0Pi = RecoDecay::m(arrayMomentaDDpi, std::array{MassD0, MassD0, MassPiPlus});
             const auto deltaMassD0D0Pi = massD0D0Pi - (massD01 + massD02);
 
             deltaMassD01 = massKpipi1 - massD01;