Skip to content

Commit b5abdc6

Browse files
vkuceravkucera
committed
Fix readability
1 parent b5c5976 commit b5abdc6

File tree

101 files changed

+948
-848
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

101 files changed

+948
-848
lines changed

‎PWGHF/D2H/Macros/HFInvMassFitter.cxx‎

Lines changed: 14 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -56,8 +56,7 @@ using namespace RooFit;
5656

5757
ClassImp(HFInvMassFitter);
5858

59-
HFInvMassFitter::HFInvMassFitter() : TNamed(),
60-
mHistoInvMass(nullptr),
59+
HFInvMassFitter::HFInvMassFitter() : mHistoInvMass(nullptr),
6160
mFitOption("L,E"),
6261
mMinMass(0),
6362
mMaxMass(5),
@@ -128,8 +127,7 @@ HFInvMassFitter::HFInvMassFitter() : TNamed(),
128127
// default constructor
129128
}
130129

131-
HFInvMassFitter::HFInvMassFitter(const TH1* histoToFit, Double_t minValue, Double_t maxValue, Int_t fitTypeBkg, Int_t fitTypeSgn) : TNamed(),
132-
mHistoInvMass(nullptr),
130+
HFInvMassFitter::HFInvMassFitter(const TH1* histoToFit, Double_t minValue, Double_t maxValue, Int_t fitTypeBkg, Int_t fitTypeSgn) : mHistoInvMass(nullptr),
133131
mFitOption("L,E"),
134132
mMinMass(minValue),
135133
mMaxMass(maxValue),
@@ -260,7 +258,7 @@ void HFInvMassFitter::doFit()
260258
if (mTypeOfBkgPdf == NoBkg) { // MC
261259
mRooNSgn = new RooRealVar("mRooNSig", "number of signal", 0.3 * mIntegralHisto, 0., 1.2 * mIntegralHisto); // signal yield
262260
mTotalPdf = new RooAddPdf("mMCFunc", "MC fit function", RooArgList(*sgnPdf), RooArgList(*mRooNSgn)); // create total pdf
263-
if (!strcmp(mFitOption.Data(), "Chi2")) {
261+
if (strcmp(mFitOption.Data(), "Chi2") == 0) {
264262
mTotalPdf->chi2FitTo(dataHistogram, Range("signal"));
265263
} else {
266264
mTotalPdf->fitTo(dataHistogram, Range("signal"));
@@ -272,13 +270,13 @@ void HFInvMassFitter::doFit()
272270
} else { // data
273271
mBkgPdf = new RooAddPdf("mBkgPdf", "background fit function", RooArgList(*bkgPdf), RooArgList(*mRooNBkg));
274272
if (mTypeOfSgnPdf == GausSec) { // two peak fit
275-
if (!strcmp(mFitOption.Data(), "Chi2")) {
273+
if (strcmp(mFitOption.Data(), "Chi2") == 0) {
276274
mBkgPdf->chi2FitTo(dataHistogram, Range("SBL,SBR,SEC"), Save());
277275
} else {
278276
mBkgPdf->fitTo(dataHistogram, Range("SBL,SBR,SEC"), Save());
279277
}
280278
} else { // single peak fit
281-
if (!strcmp(mFitOption.Data(), "Chi2")) {
279+
if (strcmp(mFitOption.Data(), "Chi2") == 0) {
282280
mBkgPdf->chi2FitTo(dataHistogram, Range("SBL,SBR"), Save());
283281
} else {
284282
mBkgPdf->fitTo(dataHistogram, Range("SBL,SBR"), Save());
@@ -287,7 +285,7 @@ void HFInvMassFitter::doFit()
287285
// define the frame to evaluate background sidebands chi2 (bg pdf needs to be plotted within sideband ranges)
288286
RooPlot* frameTemporary = mass->frame(Title(Form("%s_temp", mHistoInvMass->GetTitle())));
289287
dataHistogram.plotOn(frameTemporary, Name("data_for_bkgchi2"));
290-
mBkgPdf->plotOn(frameTemporary, Range("SBL", "SBR"), Name("Bkg_sidebands"));
288+
mBkgPdf->plotOn(frameTemporary, Range("SBL", true), Name("Bkg_sidebands"));
291289
mChiSquareOverNdfBkg = frameTemporary->chiSquare("Bkg_sidebands", "data_for_bkgchi2"); // calculate reduced chi2 / NDF of background sidebands (pre-fit)
292290
delete frameTemporary;
293291
RooAbsPdf* mBkgPdfPrefit{nullptr};
@@ -311,15 +309,15 @@ void HFInvMassFitter::doFit()
311309
}
312310
mSgnPdf = new RooAddPdf("mSgnPdf", "signal fit function", RooArgList(*sgnPdf), RooArgList(*mRooNSgn));
313311
// create reflection template and fit to reflection
314-
if (mHistoTemplateRefl) {
312+
if (mHistoTemplateRefl != nullptr) {
315313
RooAbsPdf* reflPdf = createReflectionFitFunction(mWorkspace); // create reflection pdf
316314
RooDataHist reflHistogram("reflHistogram", "refl for fit", *mass, Import(*mHistoTemplateRefl));
317315
mReflFrame = mass->frame();
318316
mReflOnlyFrame = mass->frame(Title(Form("%s", mHistoTemplateRefl->GetTitle())));
319317
reflHistogram.plotOn(mReflOnlyFrame);
320318
mRooNRefl = new RooRealVar("mNRefl", "number of reflection", 0.5 * mHistoTemplateRefl->Integral(), 0, mHistoTemplateRefl->Integral());
321319
RooAddPdf reflFuncTemp("reflFuncTemp", "template reflection fit function", RooArgList(*reflPdf), RooArgList(*mRooNRefl));
322-
if (!strcmp(mFitOption.Data(), "Chi2")) {
320+
if (strcmp(mFitOption.Data(), "Chi2") == 0) {
323321
reflFuncTemp.chi2FitTo(reflHistogram);
324322
} else {
325323
reflFuncTemp.fitTo(reflHistogram);
@@ -330,7 +328,7 @@ void HFInvMassFitter::doFit()
330328
mRooNRefl->setConstant(kTRUE);
331329
setReflFuncFixed(); // fix reflection pdf parameter
332330
mTotalPdf = new RooAddPdf("mTotalPdf", "background + signal + reflection fit function", RooArgList(*bkgPdf, *sgnPdf, *reflPdf), RooArgList(*mRooNBkg, *mRooNSgn, *mRooNRefl));
333-
if (!strcmp(mFitOption.Data(), "Chi2")) {
331+
if (strcmp(mFitOption.Data(), "Chi2") == 0) {
334332
mTotalPdf->chi2FitTo(dataHistogram);
335333
} else {
336334
mTotalPdf->fitTo(dataHistogram);
@@ -350,7 +348,7 @@ void HFInvMassFitter::doFit()
350348
mSgnPdf->plotOn(mResidualFrame, Normalization(1.0, RooAbsReal::RelativeExpected), LineColor(kBlue));
351349
} else {
352350
mTotalPdf = new RooAddPdf("mTotalPdf", "background + signal pdf", RooArgList(*bkgPdf, *sgnPdf), RooArgList(*mRooNBkg, *mRooNSgn));
353-
if (!strcmp(mFitOption.Data(), "Chi2")) {
351+
if (strcmp(mFitOption.Data(), "Chi2") == 0) {
354352
mTotalPdf->chi2FitTo(dataHistogram);
355353
} else {
356354
mTotalPdf->fitTo(dataHistogram);
@@ -576,7 +574,7 @@ void HFInvMassFitter::drawFit(TVirtualPad* pad, Int_t writeFitInfo)
576574
textInfoLeft->AddText(Form("B (%d#sigma) = %.0f #pm %.0f", mNSigmaForSidebands, mBkgYield, mBkgYieldErr));
577575
textInfoLeft->AddText(Form("S/B (%d#sigma) = %.4g ", mNSigmaForSidebands, mRawYield / mBkgYield));
578576
}
579-
if (mReflPdf) {
577+
if (mReflPdf != nullptr) {
580578
textInfoLeft->AddText(Form("Refl/Sig = %.3f #pm %.3f ", mReflOverSgn, 0.0));
581579
}
582580
if (mTypeOfBkgPdf != NoBkg) {
@@ -610,7 +608,7 @@ void HFInvMassFitter::drawFit(TVirtualPad* pad, Int_t writeFitInfo)
610608
mInvMassFrame->GetXaxis()->SetTitle(Form("%s", mHistoInvMass->GetXaxis()->GetTitle()));
611609
mInvMassFrame->Draw();
612610
highlightPeakRegion(mInvMassFrame);
613-
if (mHistoTemplateRefl) {
611+
if (mHistoTemplateRefl != nullptr) {
614612
mReflFrame->Draw("same");
615613
}
616614
}
@@ -643,8 +641,9 @@ void HFInvMassFitter::drawResidual(TVirtualPad* pad)
643641
// draw peak region with vertical lines
644642
void HFInvMassFitter::highlightPeakRegion(const RooPlot* plot, Color_t color, Width_t width, Style_t style) const
645643
{
646-
if (!mHighlightPeakRegion)
644+
if (!mHighlightPeakRegion) {
647645
return;
646+
}
648647
double yMin = plot->GetMinimum();
649648
double yMax = plot->GetMaximum();
650649
const Double_t mean = mRooMeanSgn->getVal();

‎PWGHF/D2H/Macros/HFInvMassFitter.h‎

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -70,9 +70,9 @@ class HFInvMassFitter : public TNamed
7070
~HFInvMassFitter() override;
7171
void setHistogramForFit(const TH1* histoToFit)
7272
{
73-
if (mHistoInvMass) {
74-
delete mHistoInvMass;
75-
}
73+
74+
delete mHistoInvMass;
75+
7676
mHistoInvMass = dynamic_cast<TH1*>(histoToFit->Clone("mHistoInvMass"));
7777
mHistoInvMass->SetDirectory(nullptr);
7878
}
@@ -99,7 +99,7 @@ class HFInvMassFitter : public TNamed
9999
mParamSgn = sigmaLimit;
100100
}
101101
void setParticlePdgMass(Double_t mass) { mMassParticle = mass; }
102-
Double_t getParticlePdgMass() { return mMassParticle; }
102+
Double_t getParticlePdgMass() const { return mMassParticle; }
103103
void setInitialGaussianMean(Double_t mean)
104104
{
105105
mMass = mean;
@@ -190,7 +190,7 @@ class HFInvMassFitter : public TNamed
190190
}
191191
void setTemplateReflections(const TH1* histoRefl, Int_t fitTypeRefl = DoubleGaus)
192192
{
193-
if (!histoRefl) {
193+
if (histoRefl == nullptr) {
194194
mEnableReflections = kFALSE;
195195
}
196196
mHistoTemplateRefl = dynamic_cast<TH1*>(histoRefl->Clone("mHistoTemplateRefl"));
@@ -213,11 +213,10 @@ class HFInvMassFitter : public TNamed
213213
[[nodiscard]] Double_t getSigmaUncertainty() const { return mRooSigmaSgn->getError(); }
214214
[[nodiscard]] Double_t getReflOverSig() const
215215
{
216-
if (mReflPdf) {
216+
if (mReflPdf != nullptr) {
217217
return mReflOverSgn;
218-
} else {
219-
return 0;
220218
}
219+
return 0;
221220
}
222221
void calculateSignal(Double_t& signal, Double_t& signalErr) const;
223222
void countSignal(Double_t& signal, Double_t& signalErr) const;

‎PWGHF/D2H/Macros/runMassFitter.C‎

Lines changed: 27 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ int runMassFitter(const TString& configFileName = "config_massfitter.json");
4747
template <typename ValueType>
4848
void readArray(const Value& jsonArray, std::vector<ValueType>& output)
4949
{
50-
for (auto it = jsonArray.Begin(); it != jsonArray.End(); it++) {
50+
for (const auto* it = jsonArray.Begin(); it != jsonArray.End(); it++) {
5151
auto value = it->template Get<ValueType>();
5252
output.emplace_back(value);
5353
}
@@ -70,7 +70,7 @@ int runMassFitter(const TString& configFileName)
7070
{
7171
// load config
7272
FILE* configFile = fopen(configFileName.Data(), "r");
73-
if (!configFile) {
73+
if (configFile == nullptr) {
7474
throw std::runtime_error("ERROR: Missing configuration json file: " + configFileName);
7575
}
7676

@@ -208,15 +208,15 @@ int runMassFitter(const TString& configFileName)
208208
const double massPDG = TDatabasePDG::Instance()->GetParticle(particles[particleName.Data()].second.c_str())->Mass();
209209

210210
// load inv-mass histograms
211-
auto inputFile = TFile::Open(inputFileName.Data());
212-
if (!inputFile || !inputFile->IsOpen()) {
211+
auto* inputFile = TFile::Open(inputFileName.Data());
212+
if ((inputFile == nullptr) || !inputFile->IsOpen()) {
213213
return -1;
214214
}
215215

216216
TFile* inputFileRefl = nullptr;
217217
if (enableRefl) {
218218
inputFileRefl = TFile::Open(reflFileName.Data());
219-
if (!inputFileRefl || !inputFileRefl->IsOpen()) {
219+
if ((inputFileRefl == nullptr) || !inputFileRefl->IsOpen()) {
220220
return -1;
221221
}
222222
}
@@ -232,10 +232,10 @@ int runMassFitter(const TString& configFileName)
232232
hMassRefl[iSliceVar] = inputFileRefl->Get<TH1>(reflHistoName[iSliceVar].data());
233233
hMassSgn[iSliceVar] = inputFileRefl->Get<TH1>(fdHistoName[iSliceVar].data());
234234
hMassSgn[iSliceVar]->Add(inputFileRefl->Get<TH1>(promptHistoName[iSliceVar].data()));
235-
if (!hMassRefl[iSliceVar]) {
235+
if (hMassRefl[iSliceVar] == nullptr) {
236236
throw std::runtime_error("ERROR: MC reflection histogram not found! Exit!");
237237
}
238-
if (!hMassSgn[iSliceVar]) {
238+
if (hMassSgn[iSliceVar] == nullptr) {
239239
throw std::runtime_error("ERROR: MC prompt or FD histogram not found! Exit!");
240240
}
241241
}
@@ -247,47 +247,47 @@ int runMassFitter(const TString& configFileName)
247247
hMass[iSliceVar]->Add(inputFile->Get<TH1>(fdSecPeakHistoName[iSliceVar].data()));
248248
}
249249
}
250-
if (!hMass[iSliceVar]) {
250+
if (hMass[iSliceVar] == nullptr) {
251251
throw std::runtime_error("ERROR: input histogram for fit not found! Exit!");
252252
}
253253
hMass[iSliceVar]->SetDirectory(nullptr);
254254
}
255255
inputFile->Close();
256256

257257
// define output histos
258-
auto hRawYieldsSignal = new TH1D("hRawYieldsSignal", ";" + sliceVarName + "(" + sliceVarUnit + ");raw yield",
259-
nSliceVarBins, sliceVarLimits.data());
260-
auto hRawYieldsSignalCounted = new TH1D("hRawYieldsSignalCounted", ";" + sliceVarName + "(" + sliceVarUnit + ");raw yield via bin count",
261-
nSliceVarBins, sliceVarLimits.data());
262-
auto hRawYieldsSigma = new TH1D(
258+
auto* hRawYieldsSignal = new TH1D("hRawYieldsSignal", ";" + sliceVarName + "(" + sliceVarUnit + ");raw yield",
259+
nSliceVarBins, sliceVarLimits.data());
260+
auto* hRawYieldsSignalCounted = new TH1D("hRawYieldsSignalCounted", ";" + sliceVarName + "(" + sliceVarUnit + ");raw yield via bin count",
261+
nSliceVarBins, sliceVarLimits.data());
262+
auto* hRawYieldsSigma = new TH1D(
263263
"hRawYieldsSigma", ";" + sliceVarName + "(" + sliceVarUnit + ");width (GeV/#it{c}^{2})",
264264
nSliceVarBins, sliceVarLimits.data());
265-
auto hRawYieldsMean = new TH1D(
265+
auto* hRawYieldsMean = new TH1D(
266266
"hRawYieldsMean", ";" + sliceVarName + "(" + sliceVarUnit + ");mean (GeV/#it{c}^{2})",
267267
nSliceVarBins, sliceVarLimits.data());
268-
auto hRawYieldsSignificance = new TH1D(
268+
auto* hRawYieldsSignificance = new TH1D(
269269
"hRawYieldsSignificance",
270270
";" + sliceVarName + "(" + sliceVarUnit + ");significance (3#sigma)", nSliceVarBins, sliceVarLimits.data());
271-
auto hRawYieldsSgnOverBkg =
271+
auto* hRawYieldsSgnOverBkg =
272272
new TH1D("hRawYieldsSgnOverBkg", ";" + sliceVarName + "(" + sliceVarUnit + ");S/B (3#sigma)",
273273
nSliceVarBins, sliceVarLimits.data());
274-
auto hRawYieldsBkg =
274+
auto* hRawYieldsBkg =
275275
new TH1D("hRawYieldsBkg", ";" + sliceVarName + "(" + sliceVarUnit + ");Background (3#sigma)",
276276
nSliceVarBins, sliceVarLimits.data());
277-
auto hRawYieldsChiSquareBkg =
277+
auto* hRawYieldsChiSquareBkg =
278278
new TH1D("hRawYieldsChiSquareBkg",
279279
";" + sliceVarName + "(" + sliceVarUnit + ");#chi^{2}/#it{ndf}", nSliceVarBins, sliceVarLimits.data());
280-
auto hRawYieldsChiSquareTotal =
280+
auto* hRawYieldsChiSquareTotal =
281281
new TH1D("hRawYieldsChiSquareTotal",
282282
";" + sliceVarName + "(" + sliceVarUnit + ");#chi^{2}/#it{ndf}", nSliceVarBins, sliceVarLimits.data());
283-
auto hReflectionOverSignal =
283+
auto* hReflectionOverSignal =
284284
new TH1D("hReflectionOverSignal", ";" + sliceVarName + "(" + sliceVarUnit + ");Refl/Signal",
285285
nSliceVarBins, sliceVarLimits.data());
286286

287287
const Int_t nConfigsToSave = 6;
288-
auto hFitConfig = new TH2F("hfitConfig", "Fit Configurations", nConfigsToSave, 0, 6, nSliceVarBins, sliceVarLimits.data());
288+
auto* hFitConfig = new TH2F("hfitConfig", "Fit Configurations", nConfigsToSave, 0, 6, nSliceVarBins, sliceVarLimits.data());
289289
const char* hFitConfigXLabel[nConfigsToSave] = {"mass min", "mass max", "rebin num", "fix sigma", "bkg func", "sgn func"};
290-
hFitConfig->SetStats(0);
290+
hFitConfig->SetStats(false);
291291
hFitConfig->LabelsDeflate("X");
292292
hFitConfig->LabelsDeflate("Y");
293293
hFitConfig->LabelsOption("v");
@@ -310,8 +310,8 @@ int runMassFitter(const TString& configFileName)
310310
TH1* histToFix = nullptr;
311311
if (isFix) {
312312
if (fixManual.empty()) {
313-
auto fixInputFile = TFile::Open(fixFileName.data());
314-
if (!fixInputFile) {
313+
auto* fixInputFile = TFile::Open(fixFileName.data());
314+
if (fixInputFile == nullptr) {
315315
throw std::runtime_error("Cannot open file for fixed " + var);
316316
}
317317
const std::string histName = "hRawYields" + var;
@@ -364,7 +364,7 @@ int runMassFitter(const TString& configFileName)
364364
for (unsigned int iSliceVar = 0; iSliceVar < nSliceVarBins; iSliceVar++) {
365365
const Int_t iCanvas = std::floor(static_cast<float>(iSliceVar) / nCanvasesMax);
366366

367-
hMassForFit[iSliceVar] = static_cast<TH1*>(hMass[iSliceVar]->Rebin(nRebin[iSliceVar]));
367+
hMassForFit[iSliceVar] = hMass[iSliceVar]->Rebin(nRebin[iSliceVar]);
368368
TString ptTitle =
369369
Form("%0.2f < " + sliceVarName + " < %0.2f " + sliceVarUnit, sliceVarMin[iSliceVar], sliceVarMax[iSliceVar]);
370370
hMassForFit[iSliceVar]->SetTitle(Form("%s;%s;Counts per %0.1f MeV/#it{c}^{2}",
@@ -373,8 +373,8 @@ int runMassFitter(const TString& configFileName)
373373
hMassForFit[iSliceVar]->SetName(Form("MassForFit%d", iSliceVar));
374374

375375
if (enableRefl) {
376-
hMassForRefl[iSliceVar] = static_cast<TH1*>(hMassRefl[iSliceVar]->Rebin(nRebin[iSliceVar]));
377-
hMassForSgn[iSliceVar] = static_cast<TH1*>(hMassSgn[iSliceVar]->Rebin(nRebin[iSliceVar]));
376+
hMassForRefl[iSliceVar] = hMassRefl[iSliceVar]->Rebin(nRebin[iSliceVar]);
377+
hMassForSgn[iSliceVar] = hMassSgn[iSliceVar]->Rebin(nRebin[iSliceVar]);
378378
}
379379

380380
Double_t reflOverSgn = 0;

‎PWGHF/D2H/TableProducer/candidateCreatorCharmResoReduced.cxx‎

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -184,11 +184,10 @@ struct HfCandidateCreatorCharmResoReduced {
184184
{
185185
if (!cfgDmesCuts.keepSideBands) {
186186
return (invMass >= cfgDmesCuts.cutsD->get(ptBin, "invMassSignalLow") && invMass <= cfgDmesCuts.cutsD->get(ptBin, "invMassSignalHigh"));
187-
} else {
188-
return ((invMass >= cfgDmesCuts.cutsD->get(ptBin, "invMassLeftSBLow") && invMass <= cfgDmesCuts.cutsD->get(ptBin, "invMassLeftSBHigh")) ||
189-
(invMass >= cfgDmesCuts.cutsD->get(ptBin, "invMassRightSBLow") && invMass <= cfgDmesCuts.cutsD->get(ptBin, "invMassRightSBHigh")) ||
190-
(invMass >= cfgDmesCuts.cutsD->get(ptBin, "invMassSignalLow") && invMass <= cfgDmesCuts.cutsD->get(ptBin, "invMassSignalHigh")));
191187
}
188+
return ((invMass >= cfgDmesCuts.cutsD->get(ptBin, "invMassLeftSBLow") && invMass <= cfgDmesCuts.cutsD->get(ptBin, "invMassLeftSBHigh")) ||
189+
(invMass >= cfgDmesCuts.cutsD->get(ptBin, "invMassRightSBLow") && invMass <= cfgDmesCuts.cutsD->get(ptBin, "invMassRightSBHigh")) ||
190+
(invMass >= cfgDmesCuts.cutsD->get(ptBin, "invMassSignalLow") && invMass <= cfgDmesCuts.cutsD->get(ptBin, "invMassSignalHigh")));
192191
}
193192

194193
/// Basic selection of D candidates

‎PWGHF/D2H/TableProducer/candidateCreatorLbReduced.cxx‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -109,8 +109,8 @@ struct HfCandidateCreatorLbReduced {
109109
}
110110

111111
template <typename Config>
112-
inline std::pair<float, float> computeInvMass2LcPiWindow(Config const& configs,
113-
float invMassWindowLcPiTolerance)
112+
std::pair<float, float> computeInvMass2LcPiWindow(Config const& configs,
113+
float invMassWindowLcPiTolerance)
114114
{
115115

116116
myInvMassWindowLcPi = 0.0f;

‎PWGHF/D2H/TableProducer/candidateSelectorB0ToDPiReduced.cxx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ struct HfCandidateSelectorB0ToDPiReduced {
9797

9898
o2::analysis::HfMlResponseB0ToDPi<float, true> hfMlResponse;
9999
float outputMlNotPreselected = -1.;
100-
std::vector<float> outputMl = {};
100+
std::vector<float> outputMl;
101101
o2::ccdb::CcdbApi ccdbApi;
102102

103103
TrackSelectorPi selectorPion;

‎PWGHF/D2H/TableProducer/candidateSelectorBplusToD0PiReduced.cxx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ struct HfCandidateSelectorBplusToD0PiReduced {
9797

9898
o2::analysis::HfMlResponseBplusToD0PiReduced<float> hfMlResponse;
9999
float outputMlNotPreselected = -1.;
100-
std::vector<float> outputMl = {};
100+
std::vector<float> outputMl;
101101
o2::ccdb::CcdbApi ccdbApi;
102102

103103
HfHelper hfHelper;

‎PWGHF/D2H/TableProducer/candidateSelectorBsToDsPiReduced.cxx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,7 @@ struct HfCandidateSelectorBsToDsPiReduced {
9393
Configurable<bool> loadModelsFromCCDB{"loadModelsFromCCDB", false, "Flag to enable or disable the loading of models from CCDB"};
9494

9595
o2::analysis::HfMlResponseBsToDsPi<float> hfMlResponse;
96-
std::vector<float> outputMl = {};
96+
std::vector<float> outputMl;
9797
o2::ccdb::CcdbApi ccdbApi;
9898

9999
TrackSelectorPi selectorPion;

‎PWGHF/D2H/TableProducer/candidateSelectorLbToLcPiReduced.cxx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ struct HfCandidateSelectorLbToLcPiReduced {
9494

9595
o2::analysis::HfMlResponseLbToLcPi<float> hfMlResponse;
9696
float outputMlNotPreselected = -1.;
97-
std::vector<float> outputMl = {};
97+
std::vector<float> outputMl;
9898
o2::ccdb::CcdbApi ccdbApi;
9999

100100
TrackSelectorPi selectorPion;

‎PWGHF/D2H/TableProducer/dataCreatorCharmHadPiReduced.cxx‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -349,8 +349,8 @@ struct HfDataCreatorCharmHadPiReduced {
349349
registry.get<TH1>(HIST("hEvents"))->GetXaxis()->SetBinLabel(iBin + 1, labels[iBin].data());
350350
}
351351

352-
std::string charmHadTitle = "";
353-
std::string histMassTitle = "";
352+
std::string charmHadTitle;
353+
std::string histMassTitle;
354354
if (doprocessDplusPiData || doprocessDplusPiDataWithMl || doprocessDplusPiDataWithQvec || doprocessDplusPiDataWithMlAndQvec || doprocessDplusPiMc || doprocessDplusPiMcWithMl) {
355355
charmHadTitle = "D^{#plus}";
356356
histMassTitle = "Dplus";
@@ -402,7 +402,7 @@ struct HfDataCreatorCharmHadPiReduced {
402402
doprocessDstarPiMc || doprocessDstarPiMcWithMl) {
403403
const auto& workflows = initContext.services().get<RunningWorkflowInfo const>();
404404
for (const DeviceSpec& device : workflows.devices) {
405-
if (device.name.compare("hf-data-creator-charm-had-pi-reduced") == 0) {
405+
if (device.name == "hf-data-creator-charm-had-pi-reduced") {
406406
// init HF event selection helper
407407
hfEvSelMc.init(device, registry);
408408
break;

0 commit comments

Comments
 (0)