Skip to content

Commit 47bd75c

Browse files
committed
tfbuilder: remove not needed monitoring metric
1 parent d4047e7 commit 47bd75c

File tree

1 file changed

+1
-15
lines changed

1 file changed

+1
-15
lines changed

src/TfBuilder/TfBuilderInputUCX.cxx

Lines changed: 1 addition & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -58,8 +58,6 @@ static ucs_status_t ucp_am_data_cb(void *arg, const void *header, size_t header_
5858
(void) header;
5959
(void) header_length;
6060

61-
const auto lMetaDecodeStart = std::chrono::steady_clock::now();
62-
6361
if (param->recv_attr & UCP_AM_RECV_ATTR_FLAG_RNDV) {
6462
/* Rendezvous request arrived, data contains an internal UCX descriptor,
6563
* which has to be passed to ucp_am_recv_data_nbx function to confirm
@@ -75,7 +73,7 @@ static ucs_status_t ucp_am_data_cb(void *arg, const void *header, size_t header_
7573
if (lInputUcx->createMetadata(data, length, lMeta)) {
7674
lInputUcx->pushMetadata(std::move(lMeta));
7775
}
78-
DDMON("tfbuilder", "recv.meta_decode_ms", since<std::chrono::milliseconds>(lMetaDecodeStart));
76+
7977
return UCS_OK;
8078
}
8179

@@ -545,7 +543,6 @@ void TfBuilderInputUCX::stop()
545543
/// Receive buffer allocation thread
546544
void TfBuilderInputUCX::StfPreprocessThread(const unsigned pThreadIdx)
547545
{
548-
using clock = std::chrono::steady_clock;
549546
DDDLOG("Starting ucx preprocess thread {}", pThreadIdx);
550547

551548
auto &lTokenInfo = mAvailableStfs[pThreadIdx];
@@ -563,8 +560,6 @@ void TfBuilderInputUCX::StfPreprocessThread(const unsigned pThreadIdx)
563560

564561
const std::string &lStfSenderId = lStfMeta.stf_sender_id();
565562

566-
const auto lAllocStart = clock::now();
567-
568563
// Allocate data memory for txgs
569564
using UCXIovTxg = UCXIovStfHeader::UCXIovTxg;
570565

@@ -577,8 +572,6 @@ void TfBuilderInputUCX::StfPreprocessThread(const unsigned pThreadIdx)
577572
mTimeFrameBuilder.allocDataBuffers(lTxgSizes, lStfRdmaInfo->mTxgPtrs);
578573
assert (lStfRdmaInfo->mTxgPtrs.size() == std::size_t(lStfMeta.stf_txg_iov().size()));
579574

580-
DDMON("tfbuilder", "recv.data_alloc_ms", since<std::chrono::milliseconds>(lAllocStart));
581-
582575
{ // make sure all remote keys are unpacked
583576
// We make this in two passes in order to minimize impact on the RDMA thread.
584577
// Only take writer key lock if a region needs to be mapped.
@@ -849,8 +842,6 @@ void TfBuilderInputUCX::DataHandlerThread(const unsigned pThreadIdx)
849842
/// FMQ message creating thread
850843
void TfBuilderInputUCX::StfPostprocessThread(const unsigned pThreadIdx)
851844
{
852-
using clock = std::chrono::steady_clock;
853-
854845
DDDLOG("Starting ucx postprocess thread {}", pThreadIdx);
855846
// Deserialization object (stf ID)
856847
IovDeserializer lStfReceiver(mTimeFrameBuilder);
@@ -866,9 +857,6 @@ void TfBuilderInputUCX::StfPostprocessThread(const unsigned pThreadIdx)
866857
const std::string &lStfSenderId = lStfMeta.stf_sender_id();
867858
const auto &lTxgPtrs = lStfRdmaInfo->mTxgPtrs;
868859

869-
auto lFmqPrepareStart = clock::now();
870-
871-
DDMON("tfbuilder", "recv.rma_get_total_ms", lStfRdmaInfo->mRdmaTimeMs);
872860
DDMON_RATE("tfbuilder", "receive_time", (lStfRdmaInfo->mRdmaTimeMs / 1000.0));
873861

874862
// signal in flight STF is finished (or error)
@@ -907,8 +895,6 @@ void TfBuilderInputUCX::StfPostprocessThread(const unsigned pThreadIdx)
907895
// copy header meta
908896
auto lStfHdr = std::make_unique<IovStfHdrMeta>(std::move(lStfMeta.stf_hdr_meta()));
909897

910-
DDMON("tfbuilder", "recv.fmq_msg_ms", since<std::chrono::milliseconds>(lFmqPrepareStart));
911-
912898
const SubTimeFrame::Header lStfHeader = lStfReceiver.peek_tf_header(*lStfHdr.get());
913899
assert (lTfId == lStfHeader.mId);
914900

0 commit comments

Comments
 (0)