Fix AbstractRefAccessor::isLoaded must check type size, pointer may be 0 for loaded data

shahor02 · shahor02 · commit f6263762dc8c · 2021-10-22T21:22:50.000+02:00
diff --git a/DataFormats/common/include/CommonDataFormat/AbstractRefAccessor.h b/DataFormats/common/include/CommonDataFormat/AbstractRefAccessor.h
@@ -25,7 +25,7 @@ namespace dataformats
 {
 
 /*
-  AbstractRefAccessor allows to register multiple containers of objects convertible to type T and 
+  AbstractRefAccessor allows to register multiple containers of objects convertible to type T and
   to access them by providing a global index indicating the registered source ID and the
   index within the original container
 */
@@ -45,7 +45,7 @@ class AbstractRefAccessor
 
   bool isLoaded(int src) const
   {
-    return mContainerPtr[src] != nullptr;
+    return mSizeOfs[src] != 0;
   }
 
   /// get object as user provided type from explicitly provided source, index

Original file line number	Diff line number	Diff line change
`@@ -25,7 +25,7 @@ namespace dataformats`
`25`	`25`	`{`
`26`	`26`
`27`	`27`	`/*`
`28`		`- AbstractRefAccessor allows to register multiple containers of objects convertible to type T and`
	`28`	`+ AbstractRefAccessor allows to register multiple containers of objects convertible to type T and`
`29`	`29`	`to access them by providing a global index indicating the registered source ID and the`
`30`	`30`	`index within the original container`
`31`	`31`	`*/`
`@@ -45,7 +45,7 @@ class AbstractRefAccessor`
`45`	`45`
`46`	`46`	`bool isLoaded(int src) const`
`47`	`47`	`{`
`48`		`- return mContainerPtr[src] != nullptr;`
	`48`	`+ return mSizeOfs[src] != 0;`
`49`	`49`	`}`
`50`	`50`
`51`	`51`	`/// get object as user provided type from explicitly provided source, index`