Skip to content

Commit e4196fc

Browse files
committed
AOD: Fix memory access problem
Fixing access to strangeness tracking LUT (when vertexID was -1). This was crashing PbPb GRID jobs and should fix https://alice.its.cern.ch/jira/browse/O2-4302
1 parent f410015 commit e4196fc

File tree

1 file changed

+11
-8
lines changed

1 file changed

+11
-8
lines changed

Detectors/AOD/src/AODProducerWorkflowSpec.cxx

Lines changed: 11 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1128,14 +1128,17 @@ void AODProducerWorkflowDPL::fillMCTrackLabelsTable(MCTrackLabelCursorType& mcTr
11281128

11291129
// filling the tables with the strangeness tracking labels
11301130
auto sTrackLabels = data.getStrangeTracksMCLabels();
1131-
mcTrackLabelCursor.reserve(mVertexStrLUT[vertexId + 1] + mcTrackLabelCursor.lastIndex());
1132-
for (int iS{mVertexStrLUT[vertexId]}; iS < mVertexStrLUT[vertexId + 1]; ++iS) {
1133-
auto& collStrTrk = mCollisionStrTrk[iS];
1134-
auto& label = sTrackLabels[collStrTrk.second];
1135-
MCLabels labelHolder;
1136-
labelHolder.labelID = label.isValid() ? (*mToStore[label.getSourceID()][label.getEventID()])[label.getTrackID()] : -1;
1137-
labelHolder.labelMask = (label.isFake() << 15) | (label.isNoise() << 14);
1138-
mcTrackLabelCursor(labelHolder.labelID, labelHolder.labelMask);
1131+
// check if vertexId and vertexId + 1 maps into mVertexStrLUT
1132+
if (!(vertexId < 0 || vertexId >= mVertexStrLUT.size() - 1)) {
1133+
mcTrackLabelCursor.reserve(mVertexStrLUT[vertexId + 1] + mcTrackLabelCursor.lastIndex());
1134+
for (int iS{mVertexStrLUT[vertexId]}; iS < mVertexStrLUT[vertexId + 1]; ++iS) {
1135+
auto& collStrTrk = mCollisionStrTrk[iS];
1136+
auto& label = sTrackLabels[collStrTrk.second];
1137+
MCLabels labelHolder;
1138+
labelHolder.labelID = label.isValid() ? (*mToStore[label.getSourceID()][label.getEventID()])[label.getTrackID()] : -1;
1139+
labelHolder.labelMask = (label.isFake() << 15) | (label.isNoise() << 14);
1140+
mcTrackLabelCursor(labelHolder.labelID, labelHolder.labelMask);
1141+
}
11391142
}
11401143
}
11411144

0 commit comments

Comments
 (0)