Skip to content

Commit bd0c527

Browse files
committed
DPL: improve tests for boolean options
1 parent 5ac37dc commit bd0c527

File tree

2 files changed

+8
-0
lines changed

2 files changed

+8
-0
lines changed

Framework/Core/test/test_BoostOptionsRetriever.cxx

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@ BOOST_AUTO_TEST_CASE(TrivialBoostOptionsRetrieverTest) {
3434
};
3535
const char* args[] = {
3636
"test",
37+
"--someBool",
3738
"--someInt", "1",
3839
"--someFloat", "0.5",
3940
"--someDouble", "0.5",
@@ -47,6 +48,7 @@ BOOST_AUTO_TEST_CASE(TrivialBoostOptionsRetrieverTest) {
4748
bpo::store(parse_command_line(sizeof(args)/sizeof(char*), args, opts), vm);
4849
bpo::notify(vm);
4950
BOOST_CHECK(vm["someInt"].as<int>() == 1);
51+
BOOST_CHECK(vm["someBool"].as<bool>() == true);
5052
BOOST_CHECK(vm["someString"].as<std::string>() == "foobar");
5153
BOOST_CHECK(vm["someFloat"].as<float>() == 0.5);
5254
BOOST_CHECK(vm["someDouble"].as<double>() == 0.5);

Framework/Core/test/test_Variants.cxx

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,12 @@ BOOST_AUTO_TEST_CASE(VariantTest) {
3939
ss << d;
4040
BOOST_CHECK(std::string(d.get<const char *>()) == "foo");
4141

42+
Variant e(true);
43+
BOOST_CHECK_EQUAL(e.get<bool>(), true);
44+
45+
Variant f(false);
46+
BOOST_CHECK_EQUAL(f.get<bool>(), false);
47+
4248
BOOST_CHECK(ss.str() == "1010.110.2foo");
4349
// Spotted valgrind error while deleting a vector of variants.
4450
std::vector<Variant> vector{1, 1.2, 1.1f, "foo"};

0 commit comments

Comments
 (0)