CCDB log improvement + DPL summary of most severe error (#5380)

* Improve error message in CCDB
* Print most severe error (not first error)

Author: jgrosseo

CCDB/src/CcdbApi.cxx

@@ -798,7 +798,7 @@ void* CcdbApi::navigateURLsAndRetrieveContent(CURL* curl_handle, std::string con
         }
       }
     } else if (response_code == 404) {
-      LOG(ERROR) << "Requested resource does not exist";
+      LOG(ERROR) << "Requested resource does not exist: " << url;
       errorflag = true;
     } else {
       errorflag = true;

Framework/Core/include/Framework/DeviceInfo.h

@@ -45,7 +45,7 @@ struct DeviceInfo {
   /// A circular buffer for the severity of each of the entries
   /// in the circular buffer associated to the device.
   std::vector<LogParsingHelpers::LogLevel> historyLevel;
-  std::string firstError;
+  std::string firstSevereError;
   std::string lastError;
   /// An unterminated string which is not ready to be printed yet
   std::string unprinted;

Framework/Core/include/Framework/LogParsingHelpers.h

@@ -26,6 +26,7 @@ struct LogParsingHelpers {
     Info,
     Warning,
     Error,
+    Fatal,
     Unknown,
     Size
   };

Framework/Core/src/LogParsingHelpers.cxx

@@ -20,6 +20,7 @@ char const* const LogParsingHelpers::LOG_LEVELS[(int)LogParsingHelpers::LogLevel
   "INFO",
   "WARNING",
   "ERROR",
+  "FATAL",
   "UNKNOWN"};
 using LogLevel = o2::framework::LogParsingHelpers::LogLevel;
 
@@ -52,6 +53,8 @@ LogLevel LogParsingHelpers::parseTokenLevel(std::string_view const s)
     return LogLevel::Warning;
   } else if (s.compare(LABELPOS, 8, "[ERROR] ") == 0) {
     return LogLevel::Error;
+  } else if (s.compare(LABELPOS, 8, "[FATAL] ") == 0) {
+    return LogLevel::Fatal;
   }
   return LogLevel::Unknown;
 }

Framework/Core/src/runDataProcessing.cxx

@@ -279,7 +279,7 @@ int calculateExitCode(DeviceSpecs& deviceSpecs, DeviceInfos& infos)
     auto& spec = deviceSpecs[di];
     if (exitCode == 0 && info.maxLogLevel >= LogParsingHelpers::LogLevel::Error) {
       LOG(ERROR) << "SEVERE: Device " << spec.name << " (" << info.pid << ") had at least one "
-                 << "message above severity ERROR: " << std::regex_replace(info.firstError, regexp, "");
+                 << "message above severity ERROR: " << std::regex_replace(info.firstSevereError, regexp, "");
       exitCode = 1;
     }
   }
@@ -870,14 +870,16 @@ LogProcessingState processChildrenOutput(DriverInfo& driverInfo,
       }
       // We keep track of the maximum log error a
       // device has seen.
+      bool maxLogLevelIncreased = false;
       if (logLevel > info.maxLogLevel && logLevel > LogParsingHelpers::LogLevel::Info &&
           logLevel != LogParsingHelpers::LogLevel::Unknown) {
         info.maxLogLevel = logLevel;
+        maxLogLevelIncreased = true;
       }
-      if (logLevel == LogParsingHelpers::LogLevel::Error) {
+      if (logLevel >= LogParsingHelpers::LogLevel::Error) {
         info.lastError = token;
-        if (info.firstError.empty()) {
-          info.firstError = token;
+        if (info.firstSevereError.empty() || maxLogLevelIncreased) {
+          info.firstSevereError = token;
         }
       }
       s.remove_prefix(pos + delimiter.length());
@@ -1102,11 +1104,11 @@ int runStateMachine(DataProcessorSpecs const& workflow,
     auto initDebugGUI = []() -> DebugGUI* {
       uv_lib_t supportLib;
       int result = 0;
-  #ifdef __APPLE__
+#ifdef __APPLE__
       result = uv_dlopen("libO2FrameworkGUISupport.dylib", &supportLib);
-  #else
+#else
       result = uv_dlopen("libO2FrameworkGUISupport.so", &supportLib);
-  #endif
+#endif
       if (result == -1) {
         LOG(ERROR) << uv_dlerror(&supportLib);
         return nullptr;