Skip to content

Commit 9a841ed

Browse files
committed
On track operation failure produce WARNING instead of ERROR
1 parent 71dd95b commit 9a841ed

File tree

2 files changed

+12
-12
lines changed

2 files changed

+12
-12
lines changed

DataFormats/Reconstruction/src/Track.cxx

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -358,8 +358,8 @@ bool TrackPar::propagateParamToDCA(const Point3D<float>& vtx, float b, std::arra
358358
auto tmpT(*this); // operate on the copy to recover after the failure
359359
alp += std::asin(sn);
360360
if (!tmpT.rotateParam(alp) || !tmpT.propagateParamTo(xv, b)) {
361-
LOG(ERROR) << "failed to propagate to alpha=" << alp << " X=" << xv << " for vertex "
362-
<< vtx.X() << ' ' << vtx.Y() << ' ' << vtx.Z() << " | Track is: ";
361+
LOG(WARNING) << "failed to propagate to alpha=" << alp << " X=" << xv << " for vertex "
362+
<< vtx.X() << ' ' << vtx.Y() << ' ' << vtx.Z() << " | Track is: ";
363363
tmpT.printParam();
364364
return false;
365365
}
@@ -826,7 +826,7 @@ bool TrackParCov::rotate(float alpha)
826826
{
827827
// rotate to alpha frame
828828
if (fabs(getSnp()) > Almost1) {
829-
LOGF(ERROR, "Precondition is not satisfied: |sin(phi)|>1 ! {:f}", getSnp());
829+
LOGF(WARNING, "Precondition is not satisfied: |sin(phi)|>1 ! {:f}", getSnp());
830830
return false;
831831
}
832832
//
@@ -903,7 +903,7 @@ bool TrackParCov::propagateToDCA(const o2::dataformats::VertexBase& vtx, float b
903903
auto tmpT(*this); // operate on the copy to recover after the failure
904904
alp += std::asin(sn);
905905
if (!tmpT.rotate(alp) || !tmpT.propagateTo(xv, b)) {
906-
LOG(ERROR) << "failed to propagate to alpha=" << alp << " X=" << xv << vtx << " | Track is: ";
906+
LOG(WARNING) << "failed to propagate to alpha=" << alp << " X=" << xv << vtx << " | Track is: ";
907907
tmpT.print();
908908
return false;
909909
}
@@ -1381,7 +1381,7 @@ float TrackParCov::getPredictedChi2(const TrackParCov& rhs, MatrixDSym5& covToSe
13811381
}
13821382
buildCombinedCovMatrix(rhs, covToSet);
13831383
if (!covToSet.Invert()) {
1384-
LOG(ERROR) << "Cov.matrix inversion failed: " << covToSet;
1384+
LOG(WARNING) << "Cov.matrix inversion failed: " << covToSet;
13851385
return 2. * HugeF;
13861386
}
13871387
double chi2diag = 0., chi2ndiag = 0., diff[kNParams];
@@ -1471,7 +1471,7 @@ bool TrackParCov::update(const TrackParCov& rhs)
14711471
MatrixDSym5 covI; // perform matrix operations in double!
14721472
buildCombinedCovMatrix(rhs, covI);
14731473
if (!covI.Invert()) {
1474-
LOG(ERROR) << "Cov.matrix inversion failed: " << covI;
1474+
LOG(WARNING) << "Cov.matrix inversion failed: " << covI;
14751475
return false;
14761476
}
14771477
return update(rhs, covI);

Detectors/Base/src/Propagator.cxx

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -315,7 +315,7 @@ bool Propagator::propagateToDCA(const o2::dataformats::VertexBase& vtx, o2::trac
315315
auto tmpT(track); // operate on the copy to recover after the failure
316316
alp += std::asin(sn);
317317
if (!tmpT.rotate(alp) || !propagateToX(tmpT, xv, bZ, mass, 0.85, maxStep, matCorr, tofInfo, signCorr)) {
318-
LOG(ERROR) << "failed to propagate to alpha=" << alp << " X=" << xv << vtx << " | Track is: ";
318+
LOG(WARNING) << "failed to propagate to alpha=" << alp << " X=" << xv << vtx << " | Track is: ";
319319
tmpT.print();
320320
return false;
321321
}
@@ -360,7 +360,7 @@ bool Propagator::propagateToDCABxByBz(const o2::dataformats::VertexBase& vtx, o2
360360
auto tmpT(track); // operate on the copy to recover after the failure
361361
alp += std::asin(sn);
362362
if (!tmpT.rotate(alp) || !PropagateToXBxByBz(tmpT, xv, mass, 0.85, maxStep, matCorr, tofInfo, signCorr)) {
363-
LOG(ERROR) << "failed to propagate to alpha=" << alp << " X=" << xv << vtx << " | Track is: ";
363+
LOG(WARNING) << "failed to propagate to alpha=" << alp << " X=" << xv << vtx << " | Track is: ";
364364
tmpT.print();
365365
return false;
366366
}
@@ -405,8 +405,8 @@ bool Propagator::propagateToDCA(const Point3D<float>& vtx, o2::track::TrackPar&
405405
auto tmpT(track); // operate on the copy to recover after the failure
406406
alp += std::asin(sn);
407407
if (!tmpT.rotateParam(alp) || !propagateToX(tmpT, xv, bZ, mass, 0.85, maxStep, matCorr, tofInfo, signCorr)) {
408-
LOG(ERROR) << "failed to propagate to alpha=" << alp << " X=" << xv << " for vertex "
409-
<< vtx.X() << ' ' << vtx.Y() << ' ' << vtx.Z() << " | Track is: ";
408+
LOG(WARNING) << "failed to propagate to alpha=" << alp << " X=" << xv << " for vertex "
409+
<< vtx.X() << ' ' << vtx.Y() << ' ' << vtx.Z() << " | Track is: ";
410410
tmpT.printParam();
411411
return false;
412412
}
@@ -449,8 +449,8 @@ bool Propagator::propagateToDCABxByBz(const Point3D<float>& vtx, o2::track::Trac
449449
auto tmpT(track); // operate on the copy to recover after the failure
450450
alp += std::asin(sn);
451451
if (!tmpT.rotateParam(alp) || !PropagateToXBxByBz(tmpT, xv, mass, 0.85, maxStep, matCorr, tofInfo, signCorr)) {
452-
LOG(ERROR) << "failed to propagate to alpha=" << alp << " X=" << xv << " for vertex "
453-
<< vtx.X() << ' ' << vtx.Y() << ' ' << vtx.Z() << " | Track is: ";
452+
LOG(WARNING) << "failed to propagate to alpha=" << alp << " X=" << xv << " for vertex "
453+
<< vtx.X() << ' ' << vtx.Y() << ' ' << vtx.Z() << " | Track is: ";
454454
tmpT.printParam();
455455
return false;
456456
}

0 commit comments

Comments
 (0)