DPL: decouple DataAllocator from TableBuilder (#2983)

If one needs DataAllocator to create arrow tables, the
TableBuilder.h header should be included before DataAllocator.h.

This way we avoid rebuilding everything when ASoA.h changes.

We should probably do the same for boost and ROOT.

Author: ktf

Framework/Core/include/Framework/AODReaderHelpers.h

@@ -11,6 +11,7 @@
 #ifndef o2_framework_readers_AODReaderHelpers_INCLUDED_H
 #define o2_framework_readers_AODReaderHelpers_INCLUDED_H
 
+#include "Framework/TableBuilder.h"
 #include "Framework/AlgorithmSpec.h"
 
 namespace o2

Framework/Core/include/Framework/DataAllocator.h

@@ -26,7 +26,7 @@
 #include "Framework/TypeTraits.h"
 #include "Framework/Traits.h"
 #include "Framework/SerializationMethods.h"
-#include "Framework/TableBuilder.h"
+#include "Framework/FunctionalHelpers.h"
 
 #include "Headers/DataHeader.h"
 #include <TClass.h>
@@ -130,9 +130,12 @@ class DataAllocator
       std::string* s = new std::string(args...);
       adopt(spec, s);
       return *s;
-    } else if constexpr (std::is_base_of_v<TableBuilder, T>) {
-      TableBuilder* tb = new TableBuilder(args...);
-      adopt(spec, tb);
+    } else if constexpr (std::is_base_of_v<struct TableBuilder, T>) {
+      TableBuilder* tb = nullptr;
+      call_if_defined<struct TableBuilder>([&](auto* p) {
+        tb = new std::decay_t<decltype(*p)>(args...);
+        adopt(spec, tb);
+      });
       return *tb;
     } else if constexpr (sizeof...(Args) == 0) {
       if constexpr (is_messageable<T>::value == true) {
@@ -189,7 +192,7 @@ class DataAllocator
   /// Adopt a TableBuilder in the framework and serialise / send
   /// it as an Arrow table to all consumers of @a spec once done
   void
-    adopt(const Output& spec, TableBuilder*);
+    adopt(const Output& spec, struct TableBuilder*);
 
   /// Adopt a raw buffer in the framework and serialize / send
   /// it to the consumers of @a spec once done.

Framework/Core/include/Framework/TableTreeHelpers.h

@@ -13,6 +13,7 @@
 #include "TFile.h"
 #include "TTreeReader.h"
 #include "TTreeReaderValue.h"
+#include "TableBuilder.h"
 
 // =============================================================================
 namespace o2

Framework/Core/src/CommonDataProcessors.cxx

@@ -18,6 +18,7 @@
 #include "Framework/DataDescriptorMatcher.h"
 #include "Framework/DataProcessorSpec.h"
 #include "Framework/DataSpecUtils.h"
+#include "Framework/TableBuilder.h"
 #include "Framework/EndOfStreamContext.h"
 #include "Framework/InitContext.h"
 #include "Framework/InputSpec.h"

Framework/Core/src/DataAllocator.cxx

@@ -8,6 +8,7 @@
 // granted to it by virtue of its status as an Intergovernmental Organization
 // or submit itself to any jurisdiction.
 #include "Framework/CompilerBuiltins.h"
+#include "Framework/TableBuilder.h"
 #include "Framework/DataAllocator.h"
 #include "Framework/MessageContext.h"
 #include "Framework/ArrowContext.h"

Framework/TestWorkflows/src/o2AODDummy.cxx

@@ -7,6 +7,7 @@
 // In applying this license CERN does not waive the privileges and immunities
 // granted to it by virtue of its status as an Intergovernmental Organization
 // or submit itself to any jurisdiction.
+#include "Framework/TableBuilder.h"
 #include "Framework/runDataProcessing.h"
 
 #include <ROOT/RDataFrame.hxx>