DPL: drop "using namespace" at top-level (#5006)

Author: ktf

Framework/Core/include/Framework/ASoA.h

@@ -27,8 +27,6 @@
 #include <cassert>
 #include <fmt/format.h>
 
-using o2::framework::runtime_error_f;
-
 namespace o2::soa
 {
 template <typename... C>
@@ -1091,7 +1089,7 @@ class Table
       auto label = T::columnLabel();
       auto index = mTable->schema()->GetAllFieldIndices(label);
       if (index.empty() == true) {
-        throw runtime_error_f("Unable to find column with label %s", label);
+        throw o2::framework::runtime_error_f("Unable to find column with label %s", label);
       }
       return mTable->column(index[0]).get();
     } else {

Framework/Core/include/Framework/DataInputDirector.h

@@ -18,11 +18,8 @@
 #include <regex>
 #include "rapidjson/fwd.h"
 
-namespace o2
+namespace o2::framework
 {
-namespace framework
-{
-using namespace rapidjson;
 
 struct FileNameHolder {
   std::string fileName;
@@ -130,11 +127,10 @@ struct DataInputDirector {
   bool mDebugMode = false;
   bool mAlienSupport = false;
 
-  bool readJsonDocument(Document* doc);
+  bool readJsonDocument(rapidjson::Document* doc);
   bool isValid();
 };
 
-} // namespace framework
-} // namespace o2
+} // namespace o2::framework
 
 #endif // o2_framework_DataInputDirector_H_INCLUDED

Framework/Core/include/Framework/DataOutputDirector.h

@@ -20,9 +20,7 @@
 
 #include "rapidjson/fwd.h"
 
-namespace o2
-{
-namespace framework
+namespace o2::framework
 {
 using namespace rapidjson;
 
@@ -105,7 +103,6 @@ struct DataOutputDirector {
   const std::tuple<std::string, std::string, int> memptyanswer = std::make_tuple(std::string(""), std::string(""), -1);
 };
 
-} // namespace framework
-} // namespace o2
+} // namespace o2::framework
 
 #endif // o2_framework_DataOutputDirector_H_INCLUDED

Framework/Core/test/Mocking.h

@@ -14,10 +14,9 @@
 #include "Framework/SimpleOptionsRetriever.h"
 #include "../src/WorkflowHelpers.h"
 
-using namespace o2::framework;
-
-std::unique_ptr<ConfigContext> makeEmptyConfigContext()
+std::unique_ptr<o2::framework::ConfigContext> makeEmptyConfigContext()
 {
+  using namespace o2::framework;
   // FIXME: Ugly... We need to fix ownership and make sure the ConfigContext
   //        either owns or shares ownership of the registry.
   std::vector<std::unique_ptr<ParamRetriever>> retrievers;