Description
The weapon visual data declarations in scripts/scr_culture_visuals/scr_culture_visuals.gml contain repetitive boilerplate code. Each weapon entry repeats the same base.weapon_data structure with display_type and new_weapon_draw: true.
Location
- File:
scripts/scr_culture_visuals/scr_culture_visuals.gml
- Approximate lines: 1256-1352 (and potentially other weapon declarations)
Impact
- Increases maintenance friction when patterns change
- Violates DRY principle
- Creates unnecessary code duplication
Context
This issue was identified during code review of PR #878 where new 30k weapons were added, highlighting the repetitive pattern.
References
Description
The weapon visual data declarations in
scripts/scr_culture_visuals/scr_culture_visuals.gmlcontain repetitive boilerplate code. Each weapon entry repeats the samebase.weapon_datastructure withdisplay_typeandnew_weapon_draw: true.Location
scripts/scr_culture_visuals/scr_culture_visuals.gmlImpact
Context
This issue was identified during code review of PR #878 where new 30k weapons were added, highlighting the repetitive pattern.
References