From 6550daec80c259d512feb741e258ebdb954b7bdf Mon Sep 17 00:00:00 2001 From: mitchell Date: Thu, 17 Apr 2025 11:23:32 -0400 Subject: [PATCH] First attempt building for Apple Silicon. --- .github/workflows/build.yml | 4 +++- activestate.yaml | 6 ++---- installers/install.sh | 2 ++ test/integration/upgen_int_test.go | 3 --- 4 files changed, 7 insertions(+), 8 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 7cdf586358..9cb6bbbc14 100755 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -40,6 +40,7 @@ jobs: sys: - {os: ubuntu-latest} - {os: macos-13, shell: zsh} + - {os: macos-latest, shell: zsh} - {os: windows-2019} - {os: ubuntu-24.04-arm} fail-fast: false @@ -523,6 +524,7 @@ jobs: with: name: | session-build-ubuntu-latest - session-build-macos-11 + session-build-macos-13 + session-build-macos-latest session-build-windows-2019 session-build-ubuntu-24.04-arm diff --git a/activestate.yaml b/activestate.yaml index fac0bab6f8..8106686473 100644 --- a/activestate.yaml +++ b/activestate.yaml @@ -39,9 +39,7 @@ constants: export CGO_ENABLED=0 PATH="${GOROOT}/bin:${GOPATH}/bin:${PATH}" BUILD_EXEC_TARGET=$constants.BUILD_EXEC_TARGET - - # add the GOARCH as infix to BUILD_TARGET_DIR if not amd64 - BUILD_TARGET_DIR=$constants.BUILD_TARGET_PREFIX_DIR/${GOARCH#amd64} + BUILD_TARGET_DIR=$constants.BUILD_TARGET_PREFIX_DIR/ - name: SCRIPT_EXT if: ne .OS.Name "Windows" value: .sh @@ -245,7 +243,7 @@ scripts: GOOS=windows go build -o .github/deps/Windows/amd64/bin/parallelize.exe github.com/ActiveState/cli/scripts/ci/parallelize/ GOOS=linux go build -o .github/deps/Linux/amd64/bin/parallelize github.com/ActiveState/cli/scripts/ci/parallelize/ GOOS=linux GOARCH=arm64 go build -o .github/deps/Linux/arm64/bin/parallelize github.com/ActiveState/cli/scripts/ci/parallelize/ - GOOS=darwin go build -o .github/deps/macOS/amd64/bin/parallelize github.com/ActiveState/cli/scripts/ci/parallelize/ + GOOS=darwin GOARCH=amd64 go build -o .github/deps/macOS/amd64/bin/parallelize github.com/ActiveState/cli/scripts/ci/parallelize/ - name: test language: bash standalone: true diff --git a/installers/install.sh b/installers/install.sh index 8a9143f80a..3da8f73405 100755 --- a/installers/install.sh +++ b/installers/install.sh @@ -82,6 +82,8 @@ Linux) Darwin) OS="darwin" ARCH="amd64" + arch="`uname -m`" + if [ $arch = "arm64" ]; then ARCH="arm64"; fi DOWNLOADEXT=".tar.gz" SHA256SUM="shasum -a 256" ;; diff --git a/test/integration/upgen_int_test.go b/test/integration/upgen_int_test.go index 91a299ad7f..776b08aea6 100644 --- a/test/integration/upgen_int_test.go +++ b/test/integration/upgen_int_test.go @@ -30,9 +30,6 @@ func (suite *UpdateGenIntegrationTestSuite) TestUpdateBits() { ext = ".zip" } hostArch := runtime.GOARCH - if runtime.GOOS == "darwin" && hostArch == "arm64" { - hostArch = "amd64" - } platform := runtime.GOOS + "-" + hostArch archivePath := filepath.Join(root, "build/update", constants.ChannelName, constants.VersionNumber, platform, fmt.Sprintf("state-%s-%s%s", platform, constants.Version, ext))