From da0df0fd57a41476cf26dc21fdb03a3c1f3f77bb Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=E5=9F=83=E5=8D=9A=E6=8B=89=E9=85=B1?= <vhtmfu@outlook.com>
Date: Sun, 1 Mar 2026 12:39:25 +0800
Subject: [PATCH] fix: call unmountPlugin before reloading plugin script

When loadPlugin.js reloads a plugin, Acode loads the new script directly.
The new script's init() then calls acode.setPluginUnmount(id, newDestroy),
which is a simple assignment that replaces the old destroy callback.
At that point the old destroy  which holds references to the old sidebar
app, commands, event listeners, etc.  is lost forever.

Fix: call acode.unmountPlugin(pluginId) before loading the new script,
so the old destroy() runs while it still exists. Also remove the old
<script> tag so the browser fetches the new source.
---
 src/lib/loadPlugin.js | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)

diff --git a/src/lib/loadPlugin.js b/src/lib/loadPlugin.js
index 9c3d50a83..14aa18a50 100644
--- a/src/lib/loadPlugin.js
+++ b/src/lib/loadPlugin.js
@@ -8,6 +8,27 @@ export default async function loadPlugin(pluginId, justInstalled = false) {
 	const baseUrl = await helpers.toInternalUri(Url.join(PLUGIN_DIR, pluginId));
 	const cacheFile = Url.join(CACHE_STORAGE, pluginId);
 
+	// Unmount the old version before loading the new one.
+	// This MUST be done here by the framework, not by the new plugin code itself,
+	// because once the new script loads, it calls acode.setPluginUnmount(id, newDestroy)
+	// which overwrites the old version's destroy callback. At that point the old
+	// destroy — which holds references to the old sidebar app, commands, event
+	// listeners, etc. — is lost and can never be called. Letting the framework
+	// invoke unmountPlugin() first ensures the OLD destroy() runs while it still
+	// exists, so all old-version resources are properly cleaned up.
+	try {
+		acode.unmountPlugin(pluginId);
+	} catch (e) {
+		// unmountPlugin() itself is safe when no callback is registered (it no-ops),
+		// but a plugin's destroy() callback may throw. We catch here so a faulty
+		// cleanup in the old version does not block reloading the new one.
+		console.error(`Error while unmounting plugin "${pluginId}":`, e);
+	}
+
+	// Remove the old <script> tag so the browser fetches the new source.
+	const oldScript = document.getElementById(`${pluginId}-mainScript`);
+	if (oldScript) oldScript.remove();
+
 	const pluginJson = await fsOperation(
 		Url.join(PLUGIN_DIR, pluginId, "plugin.json"),
 	).readFile("json");