Prefer readability in field names

Author: mwcampbell

common/src/lib.rs

@@ -736,10 +736,10 @@ impl Flag {
 #[cfg_attr(feature = "serde", serde(deny_unknown_fields))]
 #[repr(C)]
 pub struct Color {
-    pub r: u8,
-    pub g: u8,
-    pub b: u8,
-    pub a: u8,
+    pub red: u8,
+    pub green: u8,
+    pub blue: u8,
+    pub alpha: u8,
 }
 
 // The following is based on the technique described here:
@@ -1367,13 +1367,13 @@ macro_rules! color_property_methods {
             #[test]
             fn setter_should_update_the_property() {
                 let mut node = Node::new(Role::Unknown);
-                node.$setter(Color { r: 255, g: 255, b: 255, a: 255 });
-                assert_eq!(node.$getter(), Some(Color { r: 255, g: 255, b: 255, a: 255 }));
+                node.$setter(Color { red: 255, green: 255, blue: 255, alpha: 255 });
+                assert_eq!(node.$getter(), Some(Color { red: 255, green: 255, blue: 255, alpha: 255 }));
             }
             #[test]
             fn clearer_should_reset_the_property() {
                 let mut node = Node::new(Role::Unknown);
-                node.$setter(Color { r: 255, g: 255, b: 255, a: 255 });
+                node.$setter(Color { red: 255, green: 255, blue: 255, alpha: 255 });
                 node.$clearer();
                 assert!(node.$getter().is_none());
             }

consumer/src/text.rs

@@ -1178,8 +1178,8 @@ inherited_properties! {
     (language, &'a str, set_language, "en", "fr"),
     (font_size, f64, set_font_size, 12.0, 24.0),
     (font_weight, f64, set_font_weight, 400.0, 700.0),
-    (background_color, Color, set_background_color, accesskit::Color { r: 255, g: 255, b: 255, a: 255 }, accesskit::Color { r: 255, g: 0, b: 0, a: 255 }),
-    (foreground_color, Color, set_foreground_color, accesskit::Color { r: 0, g: 0, b: 0, a: 255 }, accesskit::Color { r: 0, g: 0, b: 255, a: 255 }),
+    (background_color, Color, set_background_color, accesskit::Color { red: 255, green: 255, blue: 255, alpha: 255 }, accesskit::Color { red: 255, green: 0, blue: 0, alpha: 255 }),
+    (foreground_color, Color, set_foreground_color, accesskit::Color { red: 0, green: 0, blue: 0, alpha: 255 }, accesskit::Color { red: 0, green: 0, blue: 255, alpha: 255 }),
     (overline, TextDecoration, set_overline, accesskit::TextDecoration::Solid, accesskit::TextDecoration::Dotted),
     (strikethrough, TextDecoration, set_strikethrough, accesskit::TextDecoration::Dotted, accesskit::TextDecoration::Dashed),
     (underline, TextDecoration, set_underline, accesskit::TextDecoration::Dashed, accesskit::TextDecoration::Double),