Skip to content

Allow input files in massive_star that list largest radius first#87

Merged
zingale merged 12 commits into
AMReX-Astro:mainfrom
melilly:descending-radius
Mar 14, 2026
Merged

Allow input files in massive_star that list largest radius first#87
zingale merged 12 commits into
AMReX-Astro:mainfrom
melilly:descending-radius

Conversation

@melilly

@melilly melilly commented Feb 13, 2026

Copy link
Copy Markdown
Contributor

No description provided.

Comment thread massive_star/init_1d.H
@melilly melilly marked this pull request as ready for review February 18, 2026 21:22
@melilly melilly changed the title [WIP] Allow input files in massive_star that list largest radius first Allow input files in massive_star that list largest radius first Mar 13, 2026
@zingale

zingale commented Mar 13, 2026

Copy link
Copy Markdown
Member

has this been fixed now?

@melilly

melilly commented Mar 14, 2026

Copy link
Copy Markdown
Contributor Author

has this been fixed now?

Yes, ulimit -s 32768 and commit 012537f fix the segfault we were seeing.

@zingale zingale merged commit c015349 into AMReX-Astro:main Mar 14, 2026
10 checks passed
@melilly melilly deleted the descending-radius branch March 14, 2026 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants