Skip to content

Commit 8e05d3f

Browse files
author
Marian Ganisin
authored
Merge pull request #128 from 3scale-qe/crd_fixes
fixes for crd client
2 parents 829d8c1 + a9a9da5 commit 8e05d3f

File tree

3 files changed

+5
-3
lines changed

3 files changed

+5
-3
lines changed

threescale_api/client.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -292,7 +292,7 @@ def request(self, method='GET', url=None, path='', params: dict = None,
292292
293293
"""
294294
if 'resource' in kwargs:
295-
del(kwargs['resource'])
295+
del kwargs['resource']
296296
full_url = url if url else urljoin(self.url, path)
297297
full_url = full_url + ".json"
298298
headers = headers or {}

threescale_api/defaults.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -351,8 +351,10 @@ def _lazy_load(self, **kwargs) -> 'DefaultResource':
351351
fetched = self.fetch(**kwargs)
352352
if isinstance(fetched, dict):
353353
self._entity = fetched
354-
else:
354+
elif fetched is not None:
355355
self._entity = fetched._entity
356+
else:
357+
return None
356358
return self
357359

358360
def read(self, **kwargs) -> 'DefaultResource':

threescale_api/resources.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ def url(self) -> str:
4444

4545

4646
class Limits(DefaultClient):
47-
def __init__(self, *args, entity_name='limit', entity_collection='limits', metric,
47+
def __init__(self, *args, entity_name='limit', entity_collection='limits', metric=None,
4848
**kwargs):
4949
super().__init__(*args, entity_name=entity_name,
5050
entity_collection=entity_collection, **kwargs)

0 commit comments

Comments
 (0)