From a46b11a89aa6316bd9d32518b1d39a1cbfba5342 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E7=8E=8B=E8=89=AF?= <841369634@qq.com> Date: Mon, 27 Apr 2026 18:05:27 +0800 Subject: [PATCH] perf: Raise `Model does not exist` instead of a null pointer exception --- .../impl/base_generate_human_message_step.py | 8 ++++---- apps/models_provider/serializers/model_serializer.py | 4 ++-- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/apps/application/chat_pipeline/step/generate_human_message_step/impl/base_generate_human_message_step.py b/apps/application/chat_pipeline/step/generate_human_message_step/impl/base_generate_human_message_step.py index 2c6afb47e8b..2fc62897eee 100644 --- a/apps/application/chat_pipeline/step/generate_human_message_step/impl/base_generate_human_message_step.py +++ b/apps/application/chat_pipeline/step/generate_human_message_step/impl/base_generate_human_message_step.py @@ -57,13 +57,13 @@ def to_human_message(prompt: str, content=no_references_setting.get('value').replace('{question}', problem)) else: return HumanMessage(content=prompt.replace('{data}', "").replace('{question}', problem)) - temp_data = "" + temp_len = 0 data_list = [] for p in paragraph_list: content = f"{p.title}:{p.content}" - temp_data += content - if len(temp_data) > max_paragraph_char_number: - row_data = content[0:max_paragraph_char_number - len(temp_data)] + temp_len += len(content) + if temp_len > max_paragraph_char_number: + row_data = content[0:max_paragraph_char_number - temp_len] data_list.append(f"{row_data}") break else: diff --git a/apps/models_provider/serializers/model_serializer.py b/apps/models_provider/serializers/model_serializer.py index be41df50462..d28727d2d69 100644 --- a/apps/models_provider/serializers/model_serializer.py +++ b/apps/models_provider/serializers/model_serializer.py @@ -150,8 +150,8 @@ def one_meta(self, with_valid=False): super().is_valid(raise_exception=True) model = QuerySet(Model).filter(id=self.data.get("id"), workspace_id=self.data.get('workspace_id', 'None')).first() - if model is None: - raise AppApiException(500, _('Model does not exist')) + if model is None: + raise AppApiException(500, _('Model does not exist')) return {'id': str(model.id), 'provider': model.provider, 'name': model.name, 'model_type': model.model_type, 'model_name': model.model_name, 'status': model.status,