Skip to content

Commit b811721

Browse files
committed
Merge pull request #2 from instructure/urlfix
fix url result passback
2 parents 61388e1 + fe99ea6 commit b811721

File tree

1 file changed

+3
-6
lines changed

1 file changed

+3
-6
lines changed

src/main/java/org/imsglobal/pox/IMSPOXRequest.java

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -517,7 +517,7 @@ public String getResponse(String description, String major, String severity,
517517

518518
static final String resultDataText = "<resultData><text>%s</text></resultData>";
519519

520-
static final String resultDataUrl = "<resultData><text>%s</text></resultData>";
520+
static final String resultDataUrl = "<resultData><url>%s</url></resultData>";
521521

522522
public static void sendReplaceResult(String url, String key, String secret, String sourcedid, String score) throws IOException, OAuthException {
523523
sendReplaceResult(url, key, secret, sourcedid, score, null);
@@ -530,11 +530,8 @@ public static void sendReplaceResult(String url, String key, String secret, Stri
530530
public static void sendReplaceResult(String url, String key, String secret, String sourcedid, String score, String resultData, Boolean isUrl) throws IOException, OAuthException {
531531
String dataXml = "";
532532
if (resultData != null) {
533-
if (isUrl) {
534-
dataXml = String.format(resultDataUrl, StringEscapeUtils.escapeXml(resultData));
535-
} else {
536-
dataXml = String.format(resultDataText, StringEscapeUtils.escapeXml(resultData));
537-
}
533+
String format = isUrl ? resultDataUrl : resultDataText;
534+
dataXml = String.format(format, StringEscapeUtils.escapeXml(resultData));
538535
}
539536
String xml = String.format(replaceResultMessage, StringEscapeUtils.escapeXml(sourcedid),
540537
StringEscapeUtils.escapeXml(score), dataXml);

0 commit comments

Comments
 (0)