Skip to content

Commit 6203915

Browse files
authored
Merge pull request #22 from IMSGlobal/cleanup_deps
Cleanup deps
2 parents 1005424 + 9b34caa commit 6203915

File tree

2 files changed

+9
-18
lines changed

2 files changed

+9
-18
lines changed

pom.xml

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -69,6 +69,7 @@
6969
<groupId>javax.servlet</groupId>
7070
<artifactId>servlet-api</artifactId>
7171
<version>2.5</version>
72+
<scope>provided</scope>
7273
</dependency>
7374
<dependency>
7475
<groupId>org.apache.commons</groupId>
@@ -91,11 +92,6 @@
9192
<version>1.9.3</version>
9293
<type>jar</type>
9394
</dependency>
94-
<dependency>
95-
<groupId>commons-logging</groupId>
96-
<artifactId>commons-logging</artifactId>
97-
<version>1.1.1</version>
98-
</dependency>
9995
<dependency>
10096
<groupId>net.oauth.core</groupId>
10197
<artifactId>oauth-provider</artifactId>
@@ -144,11 +140,6 @@
144140
<version>1.7.4</version>
145141
<type>jar</type>
146142
</dependency>
147-
<dependency>
148-
<groupId>cglib</groupId>
149-
<artifactId>cglib</artifactId>
150-
<version>2.2</version>
151-
</dependency>
152143
<dependency>
153144
<groupId>org.powermock</groupId>
154145
<artifactId>powermock-module-junit4</artifactId>

src/main/java/org/imsglobal/lti2/LTI2Servlet.java

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -25,15 +25,15 @@
2525
import java.util.Map;
2626
import java.util.Properties;
2727
import java.util.TreeMap;
28+
import java.util.logging.Level;
29+
import java.util.logging.Logger;
2830

2931
import javax.servlet.ServletConfig;
3032
import javax.servlet.ServletException;
3133
import javax.servlet.http.HttpServlet;
3234
import javax.servlet.http.HttpServletRequest;
3335
import javax.servlet.http.HttpServletResponse;
3436

35-
import org.apache.commons.logging.Log;
36-
import org.apache.commons.logging.LogFactory;
3737
import org.apache.http.HttpStatus;
3838
import org.codehaus.jackson.map.ObjectMapper;
3939
import org.codehaus.jackson.map.ObjectWriter;
@@ -80,7 +80,7 @@
8080
public class LTI2Servlet extends HttpServlet {
8181

8282
private static final long serialVersionUID = 1L;
83-
private static Log M_log = LogFactory.getLog(LTI2Servlet.class);
83+
private static Logger M_log = Logger.getLogger(LTI2Servlet.class.getName());
8484

8585
protected ServiceOffered LTI2ResultItem = null;
8686
protected ServiceOffered LTI2LtiLinkSettings = null;
@@ -125,7 +125,7 @@ protected void doPost(HttpServletRequest request, HttpServletResponse response)
125125
} catch (Exception e) {
126126
String ipAddress = request.getRemoteAddr();
127127
String uri = request.getRequestURI();
128-
M_log.warn("General LTI2 Failure URI="+uri+" IP=" + ipAddress);
128+
M_log.log(Level.WARNING, "General LTI2 Failure URI="+uri+" IP=" + ipAddress);
129129
e.printStackTrace();
130130
response.setStatus(HttpServletResponse.SC_INTERNAL_SERVER_ERROR);
131131
doErrorJSON(request, response, null, "General failure", e);
@@ -179,7 +179,7 @@ protected void doRequest(HttpServletRequest request, HttpServletResponse respons
179179
}
180180

181181
response.setStatus(HttpServletResponse.SC_NOT_IMPLEMENTED);
182-
M_log.warn("Unknown request="+uri);
182+
M_log.log(Level.WARNING, "Unknown request="+uri);
183183
doErrorJSON(request, response, null, "Unknown request="+uri, null);
184184
}
185185

@@ -440,7 +440,7 @@ public void registerToolProviderProfile(HttpServletRequest request,HttpServletRe
440440
response.setContentType(StandardServices.TOOLPROXY_ID_FORMAT);
441441
response.setStatus(HttpServletResponse.SC_CREATED);
442442
String jsonText = JSONValue.toJSONString(jsonResponse);
443-
M_log.debug(jsonText);
443+
M_log.log(Level.FINE, jsonText);
444444
PrintWriter out = response.getWriter();
445445
out.println(jsonText);
446446
}
@@ -477,7 +477,7 @@ public void handleResultRequest(HttpServletRequest request,HttpServletResponse r
477477
response.setContentType(StandardServices.RESULT_FORMAT);
478478
response.setStatus(HttpServletResponse.SC_OK);
479479
String jsonText = JSONValue.toJSONString(jsonResponse);
480-
M_log.debug(jsonText);
480+
M_log.log(Level.FINE, jsonText);
481481
PrintWriter out = response.getWriter();
482482
out.println(jsonText);
483483
return;
@@ -624,7 +624,7 @@ public void doErrorJSON(HttpServletRequest request,HttpServletResponse response,
624624
throws java.io.IOException
625625
{
626626
if (e != null) {
627-
M_log.error(e.getLocalizedMessage(), e);
627+
M_log.log(Level.WARNING, e.getLocalizedMessage(), e);
628628
}
629629
M_log.info(message);
630630
String output = IMSJSONRequest.doErrorJSON(request, response, json, message, e);

0 commit comments

Comments
 (0)