build(testenv): modify default feature

The feature now depends on `bdk_chain/default`. Now default feature
gates the persistence test utils rather than std.

Author: 110CodingP

crates/bitcoind_rpc/Cargo.toml

@@ -22,7 +22,7 @@ bdk_core = { path = "../core", version = "0.6.1", default-features = false }
 
 [dev-dependencies]
 bdk_bitcoind_rpc = { path = "." }
-bdk_testenv = { path = "../testenv" }
+bdk_testenv = { path = "../testenv", features = ["download"]}
 bdk_chain = { path = "../chain" }
 
 [features]

crates/chain/Cargo.toml

@@ -27,7 +27,7 @@ rusqlite = { version = "0.31.0", features = ["bundled"], optional = true }
 [dev-dependencies]
 rand = "0.8"
 proptest = "1.2.0"
-bdk_testenv = { path = "../testenv" }
+bdk_testenv = { path = "../testenv", features = ["download"]}
 criterion = { version = "0.2" }
 
 [features]

crates/electrum/Cargo.toml

@@ -17,7 +17,7 @@ bdk_core = { path = "../core", version = "0.6.1" }
 electrum-client = { version = "0.24.0", features = [ "proxy" ], default-features = false }
 
 [dev-dependencies]
-bdk_testenv = { path = "../testenv" }
+bdk_testenv = { path = "../testenv", features = ["download"]}
 bdk_chain = { path = "../chain" }
 criterion = { version = "0.2" }
 

crates/esplora/Cargo.toml

@@ -23,7 +23,7 @@ futures = { version = "0.3.26", optional = true }
 [dev-dependencies]
 esplora-client = { version = "0.12.0" }
 bdk_chain = { path = "../chain" }
-bdk_testenv = { path = "../testenv" }
+bdk_testenv = { path = "../testenv", features = ["download"]}
 tokio = { version = "1", features = ["rt", "rt-multi-thread", "macros"] }
 
 [features]

crates/testenv/Cargo.toml

@@ -25,8 +25,7 @@ tempfile = "3.20.0"
 bdk_testenv = { path = "." }
 
 [features]
-default = ["std" , "download", "miniscript"]
-miniscript = ["std", "bdk_chain/default"]
+default = ["bdk_chain/default"]
 download = ["electrsd/bitcoind_25_0", "electrsd/esplora_a33e97e1"]
 std = ["bdk_chain/std"]
 serde = ["bdk_chain/serde"]

crates/testenv/src/lib.rs

@@ -1,6 +1,6 @@
 #![cfg_attr(coverage_nightly, feature(coverage_attribute))]
 
-#[cfg(feature = "std")]
+#[cfg(feature = "default")]
 pub mod persist_test_utils;
 pub mod utils;
 

crates/testenv/src/persist_test_utils.rs

@@ -1,6 +1,5 @@
 //! This module provides utility functions for testing custom persistence backends.
 use crate::{block_id, hash};
-#[cfg(feature = "miniscript")]
 use bdk_chain::{
     bitcoin::ScriptBuf, indexer::keychain_txout, DescriptorExt, DescriptorId, SpkIterator,
 };
@@ -14,7 +13,6 @@ use std::sync::Arc;
 
 use crate::utils::{create_test_tx, create_txout};
 
-#[cfg(feature = "miniscript")]
 use crate::utils::{parse_descriptor, spk_at_index};
 
 const ADDRS: [&str; 2] = [
@@ -127,7 +125,6 @@ pub fn persist_txgraph_changeset<Store, CreateStore, Initialize, Persist>(
 /// We create a dummy [`keychain_txout::ChangeSet`], persist it and check if loaded `ChangeSet`
 /// matches the persisted one. We then create another such dummy `ChangeSet`, persist it and load it
 /// to check if merged `ChangeSet` is returned.
-#[cfg(feature = "miniscript")]
 pub fn persist_indexer_changeset<Store, CreateStore, Initialize, Persist>(
     file_name: &str,
     create_store: CreateStore,
@@ -748,7 +745,6 @@ pub fn persist_anchors<Store, CreateStore, Initialize, Persist>(
 /// We create a dummy [`keychain_txout::ChangeSet`] with only `last_revealed` field populated,
 /// persist it and check if loaded `ChangeSet` matches the persisted one. We then create another
 /// such dummy `ChangeSet`, persist it and load it to check if merged `ChangeSet` is returned.
-#[cfg(feature = "miniscript")]
 pub fn persist_last_revealed<Store, CreateStore, Initialize, Persist>(
     file_name: &str,
     create_store: CreateStore,
@@ -805,7 +801,6 @@ pub fn persist_last_revealed<Store, CreateStore, Initialize, Persist>(
 /// We create a dummy [`keychain_txout::ChangeSet`] with only `spk_cache` field populated, persist
 /// it and check if loaded `ChangeSet` matches the persisted one. We then create another such dummy
 /// `ChangeSet`, persist it and load it to check if merged `ChangeSet` is returned.
-#[cfg(feature = "miniscript")]
 pub fn persist_spk_cache<Store, CreateStore, Initialize, Persist>(
     file_name: &str,
     create_store: CreateStore,

crates/testenv/src/utils.rs

@@ -3,7 +3,7 @@ use bdk_chain::bitcoin::{
 };
 use core::str::FromStr;
 
-#[cfg(feature = "miniscript")]
+#[cfg(feature = "default")]
 use bdk_chain::miniscript::{descriptor::KeyMap, Descriptor, DescriptorPublicKey};
 
 #[allow(unused_macros)]
@@ -128,7 +128,7 @@ pub fn create_test_tx(
 }
 
 /// Generates `script_pubkey` corresponding to `index` on keychain of `descriptor`.
-#[cfg(feature = "miniscript")]
+#[cfg(feature = "default")]
 pub fn spk_at_index(
     descriptor: &Descriptor<DescriptorPublicKey>,
     index: u32,
@@ -141,7 +141,7 @@ pub fn spk_at_index(
 }
 
 /// Parses a descriptor string.
-#[cfg(feature = "miniscript")]
+#[cfg(feature = "default")]
 pub fn parse_descriptor(descriptor: &str) -> (Descriptor<DescriptorPublicKey>, KeyMap) {
     use bdk_chain::bitcoin::key::Secp256k1;
     let secp = Secp256k1::signing_only();